August 2009 - Wine-devel - list.winehq.org

re: DxDiag Demo Patch
by Dan Kegel 08 Aug '09

08 Aug '09

Henri wrote: > However, what really needs clarification is the copyright status of this. The web page about the project http://kegel.com/wine/sweng/2009/ makes it clear that the work had to be LGPL, and the students were fine with that. The final presentation about that code, http://kegel.com/wine/sweng/2009/dxdiag_presentation.ppt says "Features: ... Now free and open source Previous implementation was owned by Microsoft Could not ship with Wine" so they understood that they were writing free software that would ship with wine. The authors, according to that presentation, are Allen Hair, Brian Nguyen, David Woo, David Hwang, Linh Pham, and Edward Chang. I'm pretty sure it's ok to merge. - Dan

1 0

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput
by Vitaliy Margolen 08 Aug '09

08 Aug '09

Andrew Eikum wrote: > --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy.

2 2

Crash in riched20 caused by cryptui
by Juan Lang 07 Aug '09

07 Aug '09

Hi Dylan, I wonder if you might be able to shed insight into this. cryptui uses riched20 to display some text, and inserting an icon into a richedit control causes a crash: Assertion failed: (~para->member.para.nFlags & MEPF_REWRAP), function ME_GetCursorCoordinates, file caret.c, line 183. If I comment out the assertion, the icon gets displayed, a little offset from where I expected it, but no other crashes appear. I'm inserting the icon with: IRichEditOle_InsertObject(richEditOle, &reObject); (in cryptui's main.c.) The call stack isn't all that interesting, so I followed the call flow a little by hand. IRichEditOle_InsertObject is a wrapper that calls IRichEditOle_fnInsertObject. This calls ME_InsertOLEFromCursor, which calls ME_InternalInsertTextFromCursor. This calls ME_InsertRunAtCursor. ME_InsertRunAtCursor sets the MEPF_REWRAP flag: cursor->pPara->member.para.nFlags |= MEPF_REWRAP; which, I believe, is what leads to the assertion. Might you shed some insight into what the assertion is protecting against, or better yet how I might avoid it? If you have any interest in looking at it, I can send you a small .c file with instructions on how to reproduce the crash. Thanks, --Juan

1 0

Re: winemp3: a fix for security alert CVE-2006-1655
by Juan Lang 07 Aug '09

07 Aug '09

Hi Aric, I'm not trying to correct you here, I just don't understand a comment, so I'm asking for clarification: + int idx; + if(sfb > 21) return; /* similarity fix related to CVE-2006-1655 */ What is a "similarity fix"? Or did you mean "similar to fix for CVE..." instead? Thanks, --Juan

2 2

Re: [3/3] user32/tests: Add tests for SendInput with unicode
by Dmitry Timoshkov 07 Aug '09

07 Aug '09

"Andrew Eikum" <aeikum(a)codeweavers.com> wrote: > --- > dlls/user32/tests/input.c | 210 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 210 insertions(+), 0 deletions(-) It would be more natural and would simplify the code to add these tests to msg.c. Also, please try to avoid names like g_keyStatus, lastKeyDown, UnicodeWndProc and similar. key_status, last_key_down, unicode_wnd_proc look much more readable. -- Dmitry.

2 1

Re: secur32: Implement QueryContextAttributes for SECPKG_ATTR_CONNECTION_INFO
by Henri Verbeet 07 Aug '09

07 Aug '09

2009/8/7 Juan Lang <juan.lang(a)gmail.com>: >+ return SEC_E_UNSUPPORTED_FUNCTION; Is this return value intentional?

2 1

Re: [PATCH 3/5] wined3d: Merge the context->current_rt check for rendertarget readback with the code above.
by Stefan Dösinger 07 Aug '09

07 Aug '09

Am Friday 07 August 2009 08:51:20 schrieb Henri Verbeet: > - * 3) lastActiveRenderTarget != target && oldTid != newTid: > - * This is tricky. We have to get a context with the old drawable I don't see anything wrong with this patch in particular(so go ahead and apply it), but I am wondering how the case of switching the render target from a new thread works with the new TLS-based context management. My guess is that the problem is not applicable any longer, since there isn't really such a thing as thread switching any more. Its just a new render target for the other thread. Is that right? Or are there any other considerations for this case? Now it hurts that I didn't write a test for this special case when I fixed it a while ago - I don't even remember which game triggered it - maybe Age of Empires 3, but I am not sure.

2 1

Re: comctl32: fix pressed button theming
by Dmitry Timoshkov 07 Aug '09

07 Aug '09

"André Hentschel" <nerv(a)dawncrow.de> wrote: > --- a/dlls/comctl32/theme_button.c > +++ b/dlls/comctl32/theme_button.c > @@ -30,8 +30,22 @@ > #include "uxtheme.h" > #include "tmschema.h" > #include "comctl32.h" > +#include "wine/winuser16.h" I very much doubt that win16 apps have an idea about theming, or BM_SETSTATE16 is supposed to be handled by comctl32. -- Dmitry.

1 0

Re: [lostwages] Set about page to use h3 instead of h2 as text is too large
by Yuri Khan 07 Aug '09

07 Aug '09

On Thu, Aug 6, 2009 at 19:50, Scott Ritchie<scott(a)open-vote.org> wrote: > -<h2>Open Source and User Driven</h2> > +<h3>Open Source and User Driven</h3> Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS.

2 1

Request for vista testing
by Mike Kaplinskiy 07 Aug '09

07 Aug '09

Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike.

1 0