August 2009 - Wine-devel - list.winehq.org

Re: d3d10core/tests: Add acceptable error code for Win7
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/26 Ge van Geldorp <ggeldorp(a)vmware.com>: > hr = IDXGIFactory_EnumAdapters(factory, 0, &adapter); > - ok(SUCCEEDED(hr), "EnumAdapters failed, hr %#x\n", hr); > + ok(SUCCEEDED(hr) || hr == DXGI_ERROR_NOT_FOUND, "EnumAdapters failed, hr %#x\n", hr); Is that in a VM? It's fine to skip the test if there are no adapters, but I don't think that's supposed to happen on real hardware.

1 0

Re: wrc: Fix a memory leak on output file name (Smatch)
by Alexandre Julliard 26 Aug '09

26 Aug '09

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > The memory is released just thereafter (process end), but this is a leak anyway It's not a leak. There's no point in wasting time freeing memory in main(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg - italian translation update
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > - LTEXT "Wine puÃ² simulare diverse versioni e stili di Windows per ogni applicazione", > + LTEXT "Wine può simulare diverse versioni e stili di Windows per ogni applicazione", Looks like you messed up the encoding of the original file somehow. Probably interpreted utf-8 as ISO 8859-1.

1 0

Re: [PATCH 1/2] gdiplus: Implement GdipIsVisibleRegionPoint
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Andrew Eikum <aeikum(a)codeweavers.com>: > +GpStatus WINGDIPAPI GdipIsVisibleRegionPointI(GpRegion* region, INT x, INT y, GpGraphics *graphics, BOOL *res) > +{ > + TRACE("(%p, %d, %d, %p, %p)\n", region, x, y, graphics, res); > + > + if(!region || !res) > + return InvalidParameter; It's a bit redundant to do that check twice. Shouldn't hurt much though.

1 0

Re: oleview initial italian translation
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > @@ -1,6 +1,6 @@ > /* > - * OleView (En.rc) > - * English Language Support > + * OleView (It.rc) > + * Italian Language Support > * > * Copyright 2006 Piotr Caban > * That doesn't look right. How did you create these patches?

1 0

Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)
by Paul Chitescu 26 Aug '09

26 Aug '09

On Tuesday 25 August 2009 19:27:23 Kirill Smelkov wrote: > Signed-off-by: Kirill Smelkov <kirr(a)mns.spb.ru> > --- > fonts/.gitignore | 58 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 58 > insertions(+), 0 deletions(-) > > diff --git a/fonts/.gitignore b/fonts/.gitignore > index a857f0d..523a9a4 100644 > --- a/fonts/.gitignore > +++ b/fonts/.gitignore > @@ -37,3 +37,61 @@ > /vgasysg.fon > /vgasysr.fon > /vgasyst.fon > + > +courier-1250-96-13.fnt [...] > +system-950-96-16.fnt Git knows shell glob patterns so why not just a line: *.fnt http://www.kernel.org/pub/software/scm/git/docs/gitignore.html

2 1

Re: tools/wine.inf: fix New Zealand DST
by Dmitry Timoshkov 26 Aug '09

26 Aug '09

"Austin English" <austinenglish(a)gmail.com> wrote: > Reported in wine-users. Two points: 1. These data are auto generated. 2. Existing data for New Zealand Standard Time,"TZI" do match what XP SP3 has, a new one doesn't. -- Dmitry.

2 2

about video memory detection in wine
by Sun, Sunny 25 Aug '09

25 Aug '09

Hi You are using the hardcoded method to get the vidmem now (in function IWineD3DImpl_FillGLCaps), first you call glGetString(GL_RENDERER) to get the GPU renderer string, and then you use this string to set the vidmem in your code. Unfortunately you don't get all of the ATI GPU's string now, for our workstation GPU, the string is always like "ATI FireGL V8700", so you don't recognize this GPU and consider it as ATI_RADEON_9500, then 64MB is set which doesn't support 1280x1024 resolution (Out of adapter memory). I think you can first detect GL_ATI_meminfo in glGetString(GL_EXTENSIONS); if GL_ATI_meminfo exists, then you can use glGetIntegerv(GL_VBO_FREE_MEMORY_ATI, param) to get the current free video memory, you can see more info at: http://www.opengl.org/registry/specs/ATI/meminfo.txt if GL_ATI_meminfo doesn't exist, you can fall back to the original method. Please tell me if you have any questions. Regards, Sunny, Sun

7 20

Re: [1/5] user32:edit Use a dialog mode after receiving WM_GETDLGCODE message.
by Juan Lang 25 Aug '09

25 Aug '09

Hi Sergey, one very minor comment on this patch: + len = SendMessage(hwEdit, WM_GETTEXTLENGTH, 0, 0); + ok(13 == len, "expected 11, got %d\n", len); Nit: you mean "expected 13", not 11. The same is true for every instance where 13 is the expected length. --Juan

1 0

Re: shdocvw.inf: add default registry key HKCU, "Software\Microsoft\Internet Explorer\Settings
by Alexandre Julliard 25 Aug '09

25 Aug '09

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > @@ -142,6 +142,7 @@ HKLM,"Software\Microsoft\Windows\CurrentVersion\URL\Prefixes","www",,"http://" > [Settings.Reg] > HKCU,"Software\Microsoft\Internet Explorer\Main","Start Page",2,"http://www.winehq.org" > HKCU,"Software\Microsoft\Internet Explorer\Main","Search Page",2,"http://www.google.com" > +HKCU,"Software\Microsoft\Internet Explorer\Settings",,,"" This will create an empty value that doesn't exist on Windows. Please create a proper value instead. -- Alexandre Julliard julliard(a)winehq.org

1 0