August 2009 - Wine-devel - list.winehq.org

Re: mapi32/tests: Skip tests if no default email client is installed
by Eric Pouech 25 Aug '09

25 Aug '09

+static BOOL HaveDefaultMailClient() this should be +static BOOL HaveDefaultMailClient(void) A+ -- Eric Pouech

1 0

Re: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior
by Alexandre Julliard 25 Aug '09

25 Aug '09

Jeff Zaroyko <jeffzaroyko(a)gmail.com> writes: > This fixes bug 15181, test included - passes on Windows 95, 2003, XP, > 2008, Vista and Windows 7 beta that I've tested. > > From 52ff2d29ba9fbffbe8da46a7523338e8b946bbcd Mon Sep 17 00:00:00 2001 > From: Jeff Zaroyko <jeffz(a)jeffz.name> > Date: Sun, 23 Aug 2009 12:38:17 +1000 > Subject: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior > > As a Profile entry and under Control Panel\International sLanguage is not > LOCALE_SLANGUAGE but instead appears to be LOCALE_SABBREVLANGNAME. > > I've verified this is the case for 95, XP, 2003, 2008, Vista and Win 7. > > With the sLanguage override set GetLocaleInfo for LOCALE_SLANGUAGE still > returns the LOCALE_SLANGUAGE string and not the "override", which suggests > that the Control Panel\International sLanguage override should be ignored > by GetLocaleInfo for LOCALE_SLANGUAGE. You shouldn't need any special casing for this, just change the existing mappings to use the appropriate value. -- Alexandre Julliard julliard(a)winehq.org

2 2

Build failure on current git
by Stefan Leichter 24 Aug '09

24 Aug '09

Hello, building current git fails for me with: make: Entering directory `/usr/src/wine/wine-build/dlls/winemp3.acm' ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -shared ../../../wine-git/dlls/winemp3.acm/winemp3.acm.spec mpegl3.o -o winemp3.acm.so -lwinmm -luser32 -lkernel32 ../../libs/port/libwine_port.a -lmpg123 mpegl3.o: In function `mp3_horse': /usr/src/wine/wine-build/dlls/winemp3.acm/../../../wine-git/dlls/winemp3.acm/mpegl3.c:153: undefined reference to `mpg123_feed' collect2: ld returned 1 exit status winegcc: ccache failed make: *** [winemp3.acm.so] Fehler 2 make: Leaving directory `/usr/src/wine/wine-build/dlls/winemp3.acm' sle(a)sle3:/usr/src/wine/wine-build$ dpkg --list | grep mpg123 ii libmpg123-0 1.4.3-4 MPEG layer 1/2/3 audio decoder -- runtime li ii libmpg123-dev 1.4.3-4 MPEG layer 1/2/3 audio decoder -- developmen ii mpg321 0.2.10.6 mpg123 clone that doesn't use floating point

2 1

Re: Build failure on current git
by Robert Förster 24 Aug '09

24 Aug '09

according to the mpg123 NEWS file mpg123_feed was introduced with 1.5.0 if this is actually the lowest version to compile with, it should be checked by ./configure if possible. linking against system libmpg123 does have other issues however. im building a 32 bit wine on a 64 bit box here and i have installed a 32 bit libary of libmpg123 of course, however: mpegl3.o: In function `MPEG3_Reset': mpegl3.c:(.text+0xca): undefined reference to `mpg123_feedseek' the symbol is actually mpg123_feedseek_64 (which seems to be the case on a pure 32 bit box too according to one reporter) mpg123_findseek is correct for 64 bit however as there isn't mpg123_findseek_64 in my 64 bit libary.

1 0

winemp3.acm: link to system libmpg123.so
by Robert Förster 24 Aug '09

24 Aug '09

im getting undefined references to mpg123_feedseek. im on amd64, building a 32 bit wine, so of course i have a 32 bit lib of mpg123 around, which however seems to export mpg123_feedseek_64 instead. could that be covered too please? (i have reports that this is happening on plain x86 boxes too.) Robert

1 0

Re: wined3d: delete meaningless UNIX GL driver version parsing
by Stefan Dösinger 24 Aug '09

24 Aug '09

Am Monday 24 August 2009 18:02:37 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > here's the patch not to report UNIX GL driver version numbers to MS-Windows > apps, as suggested by Stefan and Roderick on 2009-05-25. > > On "early 2009" NVidia MacOS, it will remove > err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 > NVIDIA-1.5.44" The patch is fine with me. On a related note, it would be helpful if people who have an Intel GPU on their windows machines could update to the newest drivers and report the driver versions, so we can add then to the driver version table. the d3d9 visual test writes the driver version to stdout at the beginning.

2 1

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.
by Alexandre Julliard 24 Aug '09

24 Aug '09

Huw Davies <huw(a)codeweavers.com> writes: > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in > index d6f71a0..cebf659 100644 > --- a/dlls/msdaps/Makefile.in > +++ b/dlls/msdaps/Makefile.in > @@ -5,6 +5,7 @@ VPATH = @srcdir@ > MODULE = msdaps.dll > IMPORTS = oleaut32 rpcrt4 kernel32 ntdll > EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0x06210e88, 0x01f5, 0x11d1, { 0xb5, 0x12, 0x00, 0x80, 0xc7, 0x81, 0xc3, 0x84 } }" > +EXTRAIDLFLAGS = -a2 Won't this break the 64-bit build? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: shlwapi/tests: Remove test that crashes on Win7
by Reece Dunn 24 Aug '09

24 Aug '09

2009/8/24 Ge van Geldorp <ggeldorp(a)vmware.com>: > Changelog: > shlwapi/tests: Remove test that crashes on Win7 - ret = IStream_Clone(stream, NULL); - ok(ret == E_NOTIMPL, "expected E_NOTIMPL, got 0x%08x\n", ret); + /* Passing a NULL pointer crashes on Win7 */ If you are going to change this to a comment, could you please say which argument passing NULL to causes the crash. Thanks, - Reece

1 0

Re: ddraw: Separate reference counting for IDirectDraw7 and IDDS4 from IDDS3, IDDS2 and IDDS (try 2)
by Stefan Dösinger 24 Aug '09

24 Aug '09

I think it is better to separate the vtables first - ie, give IDirectDrawSurface4, IDirectDrawSurface2 and IDirectDrawSurface their own vtable Also the last iteration of Michael Karcher's patches missed out some getters, like IDirect3DDevice*::GetRenderTarget. There may be other functions that need to be adjusted to AddRef/Release version specific refcounts.

2 1

Re: netapi32/tests: Fix tests on Win7
by Greg Geldorp 24 Aug '09

24 Aug '09

From: Austin English > On Mon, Aug 24, 2009 at 7:19 AM, Ge van Geldorp<ggeldorp at vmware.com> wrote: > - ok(totalEntries > 0, "at least one transport\n"); > + ok(totalEntries > 0 || broken(totalEntries == 0) /* Win7 */, > > Should probably be win_skip rather than broken, so that a similar > failure on wine isn't ignored. My understanding is that broken() always returns false on Wine, so this shouldn't have any effect on Wine? Ge.

2 1