September 2009 - Wine-devel

cppcheck Sept 18
by chris ahrendt 19 Sep '09

19 Sep '09

[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 chris

1 0

Re: clock: fix license in Swedish resources
by Austin English 18 Sep '09

18 Sep '09

2009/9/15 Austin English <austinenglish(a)gmail.com>: > Wine is LGPL, not GPL. Also, convert to UTF-8. > > -- > -Austin Something wrong with these two patches? -- -Austin

1 0

WineHQ Scheduled Downtime
by Jeremy Newman 18 Sep '09

18 Sep '09

WineHQ.org will be going off-line today starting at 14:30 US Central time. At this time we are performing hardware upgrades and maintenance. The system will be off-line from 20 minutes up to an hour. Services Affected: * WineHQ.org website * Bugzilla * Forums * AppDB * mailing lists * GIT and CVS -Newman

1 0

Re: [PATCH 1/3] winex11.drv: Check the current context in X11DRV_wglMakeCurrent().
by Roderick Colenbrander 18 Sep '09

18 Sep '09

Hi, I'm not sure if we should skip the glXMakeCurrent(null, null) call in GLX as in case of GLX it doesn't hurt. Second I'm not sure if we need to put the SetLastError code in winex11 or in gdi32/opengl.c. I think it should be in there as we don't need any X11 info. Roderick 2009/9/18 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this patch series fixes a bug which happens on windows with wined3d. There a > second call to wglMakeCurrent(NULL, NULL) fails, which will in one case > result in an early return in context_set_current(), which doesn't set the > the current context to NULL in such a case, but frees the variable. So on > the next call to context_set_current() (e.g. from > WineD3D_CreateFakeGLContext()) the memory in old->... could be some other > random memory and the app could crash. > > The first patch adds a fix for winex11.drv to change the behaviour to the > one on xp. The second patch adds a test case to opengl32/tests. And the > third one fixes the behaviour in wined3d. > > Cheers > Rico > > --- > dlls/winex11.drv/opengl.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > > > > >

2 1

Re: gdi32/bitblt: GdiAlphaBlend - Check for NULL Pointer (incl. testcase)
by Paul Vriens 18 Sep '09

18 Sep '09

On 09/18/2009 01:42 PM, Markus Stockhausen wrote: > Hi, > > as I was encouraged to resent the patch from last week in git format I > hope it will be better this time. > > Best regards > > > ------------------------------------------------------------------------ > > Hi Markus, After reading this patch again, it seems to me it's not a 100% correct. There is a slight difference in passing hdcSrc as NULL compared to retrieving dcSrc via get_dc_ptr. The actual test sets hdcSrc to NULL, so the corresponding test in the implementation should be: if (!hdcSrc) return FALSE; dcSrc = get_dc_ptr ( hdcSrc ); Now, I don't know whether get_dc_ptr can fail but that's a different matter. -- Cheers, Paul.

2 3

Re: New testcase for creating nested storage objects
by Nikolay Sivov 18 Sep '09

18 Sep '09

Markus Stockhausen wrote: > Hi, > > attached you will find a new testcase that checks for differences > between Wine and Windows when handling reference counters for nested > storage objects. > > Best regards. > > Markus > Hi, Markus. Tests passes on XP, fails on current Wine. You should mark failing tests with todo_wine. Like that: > c1 = IStorage_AddRef(stg); > todo_wine ok(c1 == 2, "creating internal storage added > references to ancestor\n"); > c1 = IStorage_AddRef(stg); > IStorage_Release(stg2); > c2 = IStorage_AddRef(stg) - 1; > todo_wine ok(c1 == c2, "releasing internal storage > removed references to ancestor\n"); otherwise it will fail on Wine. Also give a more appropriate patch name and don't forget to add a prefix something like this: ole32/tests: Test for nested storages reference counting. P.S. git diff patch is preferable here. Thanks for your work.

2 2

glean and Piglit -- OpenGL driver testing
by Saulius Krasuckas 18 Sep '09

18 Sep '09

Today I saw two similar projects related to OpenGL: [1]: > glean is a suite of tools for evaluating the quality of an OpenGL > implementation and diagnosing any problems that are discovered. glean > also has the ability to compare two OpenGL implementations and highlight > the differences between them. It seems be having win32 port also. [2]: > Piglit is a collection of automated tests for OpenGL implementations. > > The goal of Piglit is to help improve the quality of open source OpenGL > drivers by providing developers with a simple means to perform > regression tests. > > Current status is that the framework is working (though rough at the > edges). It contains the Glean tests, some tests adapted from Mesa as > well as some specific regression tests for certain bugs. HTML summaries > can be generated (see below), including the ability to compare different > test runs. Could these be of any use for our graphic guys -- Stefan and co.? Then there is PerceptualDiff utility I found some time ago [3]. Guessed, could it also usefull for finding visual regressions of Wine? Probably not, as it seems to be used for testing video codecs (but I may be wrong): > PerceptualDiff is an image comparison utility that makes use of a > computational model of the human visual system to compare two images. > > So why would I use a program to tell me if two images are similar if I > can tell the difference myself by eyeballing it? > > Well the utility of this program really shines in the context of QA of > rendering algorithms. > > During regression testing of a renderer, hundreds of images are > generated from an older version of the renderer and are compared with a > newer version of the renderer. This program drastically reduces the > number of false positives (failures that are not actually failures) > caused by differences in random number generation, OS or machine > architecture differences. Also, you do not want a human looking at > hundreds of images when you can get the computer to do it for you > nightly on a cron job. [1] http://glean.sourceforge.net/whatis.html [2] http://people.freedesktop.org/~nh/piglit/ [3] http://pdiff.sourceforge.net/

4 5

Re: oledb32/tests: Add CanConvert tests.
by Paul Vriens 18 Sep '09

18 Sep '09

On 09/17/2009 03:35 PM, Huw Davies wrote: > --- > dlls/oledb32/tests/Makefile.in | 2 +- > dlls/oledb32/tests/convert.c | 76 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 77 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, This introduces issues on (older) W2K systems and below. Do we need to add some kind of skip variable or just quit (with a win_skip) if the first one fails? We could also check the conversion 0000 -> 0087 as that seems to be common on all as a failure. If this conversion fails, bail out? Thoughts? -- Cheers, Paul.

1 0

Regression
by chris ahrendt 18 Sep '09

18 Sep '09

b5b58e423d32666581f69046c74bb19902c35c2b is first bad commit commit b5b58e423d32666581f69046c74bb19902c35c2b Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Sep 17 12:35:24 2009 +0200 d3d8: Add a separate function for cube texture initialization. :040000 040000 8cd1752ed711799ebfb77127de399d527add5415 963c6467c8b4367b8a7bd1c1e4eece07937c13d6 M dlls [cahrendt(a)stinky wine-git]$ Chris

2 1

apply context draw buffer
by chris ahrendt 17 Sep '09

17 Sep '09

Something broke between yesterday's git tree and todays... went to run some applications and everything is slow as molasas... seems to be getting in a infinite loop in the apply context draw buffer

1 0