September 2009 - Wine-devel

Re: ddraw: complete recognition of pixelformat 19: X8L8V8U8
by Stefan Dösinger 14 Sep '09

14 Sep '09

Am Monday 14 September 2009 17:28:13 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > the argument for including this code is based on symmetry: Every place in > the Wine source tree (incl. ddraw, d3d9, wined3d) that handles L6V5U5 also > handles X8L8V8U8 -- except for these two places. So I closed the gap. > > This fixes > err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 19 > Please see bug #16559 for further discussion. > > Being based on the symmetry argument means this patch is completely > independent on possible missing conversions between D3DFMT and WINED3DFMT > codes somewhere in Wine. I would not eliminate that possibility. The above > error message that used to mention Pixelformats 62/63/64 nowadays mentions > 19/64/69/70. > > Regards, > Jörg Höhle The patch seems ok to me

1 0

Re: ntdll: Do not accept device control requests with invalid and/or incompatible handles
by Alexandre Julliard 14 Sep '09

14 Sep '09

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > +static void test_device_control(void) > +{ > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + > + /* Try using a bugus handle for I/O control */ > + HANDLE handle = (HANDLE)0xdeadbeef; > + status = pNtDeviceIoControlFile(handle, NULL, NULL, NULL, &io, IOCTL_SERIAL_SET_BAUD_RATE, NULL, 0, NULL, 0); > + ok(status == STATUS_INVALID_HANDLE, "Expected %08X, got %08X\n", STATUS_INVALID_HANDLE, status); > + > + /* Try using an valid (but wrong) handle for I/O control */ > + handle = GetStdHandle(STD_INPUT_HANDLE); > + status = pNtDeviceIoControlFile(handle, NULL, NULL, NULL, &io, IOCTL_SERIAL_SET_BAUD_RATE, NULL, 0, NULL, 0); > + ok(status == STATUS_INVALID_HANDLE, "Expected %08X, got %08X\n", STATUS_INVALID_HANDLE, status); GetStdHandle returns a console handle which is not a valid ntdll handle, so you are not testing what you think. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com 14 Sep '09

14 Sep '09

Hi, Stefan Dösinger wrote: >>All that happened [with notepad] is that the printer ejected a blank page. >Printing from notepad works fine for me on both Linux and OSX, fwiw Saving to file instead of printing, notepad generated a .ps file. Reading this into Apple's preview shows the text. Converting to pdf, then viewing also shows the text. Printing this prints a blank page! So either Apple does not like the PS generated by Wine, or only the printer, or that's a problem with fonts or whatever else. I'm using a PPC driver for an old Lexmark Z33 printer that prints documents from TextEdit and Safari perfectly. I still need to test a wine application other than notepad. BTW, the page footer says "Page &p": &p is not substituted by notepad. Is this a known bug in notepad or Wine's printer driver? Regards, Jörg Höhle.

1 0

Re: [3/5] comctl32/dpa: Implement DPA_SaveStream() with tests
by Vitaliy Margolen 14 Sep '09

14 Sep '09

Nikolay Sivov wrote: > Changelog: > - Implement DPA_SaveStream() with tests > > + streamData.dwSize = curr_pos.QuadPart - initial_pos.QuadPart; > + streamData.dwData2 = 1; > + streamData.dwItems = streamInfo.iPos;// + 1; c++ comment. > +#if 0 > + /* crashes on XP */ > + hRes = pDPA_SaveStream(NULL, CB_Save, pStm, NULL); > + expect(E_INVALIDARG, hRes); > + > + hRes = pDPA_SaveStream(dpa, CB_Save, NULL, NULL); > + expect(E_INVALIDARG, hRes); > +#endif Don't use #if 0 / #endif in tests. Use if (0){} instead. This will guarantee that code will still compile. Vitaliy.

2 1

Re: include: Add missing definitions in af_irda.h. (try 2)
by Alexandre Julliard 13 Sep '09

13 Sep '09

Thomas Trummer <th.trummer(a)gmail.com> writes: > @@ -97,4 +100,159 @@ typedef struct _SOCKADDR_IRDA > #define LmCharSetISO_8859_9 0x09 > #define LmCharSetUNICODE 0xff > > +#define SIO_LAZY_DISCOVERY _IOR('t', 127, ULONG) > + > +#define WINDOWS_AF_IRDA 26 > +#define WINDOWS_PF_IRDA WINDOWS_AF_IRDA > + > +#define WCE_AF_IRDA 22 > +#define WCE_PF_IRDA WCE_AF_IRDA > + > +#ifndef AF_IRDA > +#define AF_IRDA WINDOWS_AF_IRDA > +#endif > + > +#ifndef PF_IRDA > +#define PF_IRDA AF_IRDA > +#endif > + > +#define IRDA_PROTO_SOCK_STREAM 1 You need a WS prefix on all definitions that can conflict with Unix. -- Alexandre Julliard julliard(a)winehq.org

4 4

Sept 11 with tools and tests removed
by chris ahrendt 13 Sep '09

13 Sep '09

Here is the run for Friday Sept. 11 with the tools and the tests directory results removed. [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 Chris

6 11

Re: wined3d: Add Intel GMA 4500MHD
by Stefan Dösinger 13 Sep '09

13 Sep '09

Am Sunday 13 September 2009 08:15:19 schrieb Jaime Rave: > More information about Intel cards: > http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip >sets + || strstr(gl_renderer, "Intel®")) I don't know if it is safe check for the ®. I think its not part of the standard ASCII character set, so there might be codepage issues. I don't think its necessary to check for it anyway, I think "Intel" is good enough. (In which case we might change the "Intel(R)" and "Intel Inc." checks as well) + if (strstr(gl_renderer, "GM45")) + { + /* GMA 4500MHD. These can take up to 2048MB */ + *vidmem = 512; + return CARD_INTEL_GM45; + } + You are adding trailing whitespace in the last line(I think Alexandre's commit scripts fiter that out though)

1 0

Re: wined3d: Add Intel GMA 4500MHD
by Roderick Colenbrander 13 Sep '09

13 Sep '09

Just one minor thing make sure the right email address is configured in your git repository, so that the correct email address is set in the patch Roderick On Sun, Sep 13, 2009 at 8:15 AM, Jaime Rave <jaimerave(a)ubuntu-co.com> wrote: > More information about Intel > cards: http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip… > > > >

1 0

Re: [ntdll] Add test for NtQueryDirectoryFile [try 2]
by James McKenzie 13 Sep '09

13 Sep '09

Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > Changes since first try: > 1) fixed issues Paul found (wasn't setting hidden attribute, wasn't > cleaning up on failure) > 2) actually test reported file attributes > Dan: It looks like your original patch was approved by AJ in commit 398a8ea1fec599cfd6442e3b8bba620431cf53b7 You might want to run a diff against the current git. James McKenzie

2 1

Re: DDraw: Add a few missing WINAPIs
by Henri Verbeet 12 Sep '09

12 Sep '09

2009/9/12 Stefan Dösinger <stefan(a)codeweavers.com>: > I wonder how this worked in the past, and why the compiler didn't complain. It's pretty simple really, these functions don't need WINAPI because they're ddraw internal functions "cleverly" disguised as vtable methods. IIRC it's actually harmful to add WINAPI to these on OS X due to some obscure compiler bug.

2 1