January 2010 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard 17 Aug '10

17 Aug '10

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

TRACE () documentation
by James McKenzie 04 Jul '10

04 Jul '10

All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. James McKenzie

4 8

re: Remove NoAppDBEntry keyword?
by Dan Kegel 24 Apr '10

24 Apr '10

Jerome Leclanche wrote: > Austin English <austinenglish at gmail.com> wrote: >> Anyone opposed to removing that keyword? > > +1 on removing it. > It would be nice to have a bugzilla filter to replace it, too. > > Are we keeping "tasklist" and "tasklet" keywords as well? theres > barely a dozen very old bugs for both of them. I think it'd be fine to remove noappdbentry, tasklist, and tasklet. If there are no objections by next weekend, let's go ahead and do it. - Dan

4 4

Re: [2/5] WineD3D: Add an internal event query finish function
by Henri Verbeet 23 Feb '10

23 Feb '10

On 26 January 2010 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) { Please don't create function prototypes (or other code) by copy/paste. Also, why does this take a IWineD3DQuery pointer in the first place? You only really access wined3d_event_query fields. > + /* A glFinish does not reliably wait for draws in other contexts. The caller has > + * to find its own way to cope with the thread switch > + */ ... > + /* Since this is an internal call the caller should know that event Query support is faked */ > + FIXME("(%p): Event query not supported, calling glFinish\n", This); > + wglFinish(); > + return WINED3D_OK; > + } This is inconsistent. Also, note that event queries are pretty generic things, you could use them for something else than draws as well. > + if (!gl_info->supported[APPLE_FENCE] && !gl_info->supported[NV_FENCE] && gl_info->supported[ARB_SYNC]) This doesn't make sense. Of course if you just used wined3d_event_query instead of IWineD3DQuery you wouldn't even need this at all, you could just let context_alloc_event_query() fail. Just for reference, glFinish() behaviour is a bit more subtle than you make it sound. It flushes GL commands for the current context to the GPU, and then waits for the GPU to finish execution up to that point. It won't flush command buffers for other contexts, but anything that's already been submitted to the GPU before the glFinish() will have been executed when the glFinish() returns. I didn't look at the other patches much, but I think you want to look them over a bit before resending as well.

2 8

Winehq donation and DATA COMPRESSION
by Gerold Jens Wucherpfennig 06 Feb '10

06 Feb '10

Hi, I've donated some bucks to winehq by PayPal and want to spend more... Can I decide for which things will be spend? When donating money, how much of it will go to PayPal? Is there a better way than using PayPal (by the donate link of the winehq front-page)? BTW I've done some cabinet.dll stuff some years ago. Can anybody give me a hint to some easy-to-understand data compression documentation? I want to complete the cabinet.dll archive creation compression, if I get the required knowledge. It's so difficult... :-( Thanks and Bye, Gerold

6 5

Wine FIXME Report 2009 Aug - Dec
by Michael Stefaniuc 03 Feb '10

03 Feb '10

Hello! Introduction ============ Back at the last WineConf after the wineoops presentation I have been asked if the wineoops could collect FIXME/ERR messages too and do some statistics on those. Well, it doesn't and I didn't want to introduce scope creep thus this new "project" winefixme was created (while reusing a lot of code). As the complexity of this problem is a lot easier than the one tackled by wineoops it goes into "production" first. After this initial report covering the month August to December of 2009 I will do a monthly report at the beginning of every month covering the previous month; the report for January 2010 is to be expected in the first week of February 2010. Wine FIXME Report 2009 Aug to Dec ================================= The data for this report comprise the emails from the 2009 Aug to Dec archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 35369 (emails: 32631, bugzilla attachments: 2738) Files with FIXME/ERR/WARN: 2256 Type | Total | Unique ------+--------+-------- fixme | 170639 | 36113 err | 67789 | 2958 warn | 29367 | 9283 The Most Popular Messages ------------------------- This are the most prevalent ERR and FIXME messages aka the number of files where they show up. FIXME: Files | Lines | Channel:Text ------+-------+------------- 220 | 246 | system:SetProcessDPIAware stub! 213 | 285 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 209 | 559 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 209 | 877 | shell:DllCanUnloadNow stub 133 | 501 | urlmon:URLMoniker_BindToObject use running object table 110 | 118 | resource:GetGuiResources (0xffffffff,0): stub 94 | 386 | shdocvw:BindStatusCallback_OnProgress status code 11 81 | 1002 | wininet:InternetLockRequestFile STUB 79 | 125 | msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" 76 | 269 | advapi:DeregisterEventSource (0xcafe4242) stub ERR: Files | Lines | Channel:Text ------+-------+------------- 77 | 99 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 75 | 98 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 58 | 3052 | ole:CoCreateInstance apartment not initialised 57 | 139 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 52 | 87 | ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. 52 | 84 | ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. 46 | 92 | ole:CoUninitialize Mismatched CoUninitialize 45 | 89 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 45 | 186 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 44 | 88 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered The Top Ten Single Charts ------------------------- This are the messages with the most occurrences in a single file. FIXME: Lines | Files | Channel:Text ------+-------+------------- 5270 | 1 | d3d_surface:surface_download_data Read back converted textures unsupported, format=WINED3DFMT_B5G6R5_UNORM 3436 | 1 | d3d7:IDirect3DDeviceImpl_3_SetLightState D3DLIGHTSTATE_MATERIAL called with NULL material !!! 2456 | 1 | d3d_surface:surface_load_ds_location (0x1a7c50) Not supported with fixed up depth stencil 2346 | 4 | mlang:fnIMultiLanguage2_ConvertStringToUnicodeEx 1852 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000109 1468 | 1 | d3d_draw:drawStridedInstanced >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glDrawElements @ drawprim.c / 547 1451 | 1 | ddraw:IDirectDrawImpl_WaitForVerticalBlank (0xa2204e0)->(1,0x0): Stub 1430 | 1 | d3d:IWineD3DSwapChainImpl_Present Unhandled present options 0x32fc94/0x32fca4 1404 | 6 | rpc:NdrStubCall2 new correlation description not implemented 1279 | 1 | rpc:RpcImpersonateClient ((nil)): stub ERR: Lines | Files | Channel:Text ------+-------+------------- 3561 | 3 | win:DefWindowProcW called for other process window 0x10020 3110 | 6 | d3d:resource_init Out of adapter memory 3110 | 2 | ddraw:IDirectDrawImpl_CreateNewSurface IWineD3DDevice::CreateSurface failed. hr = 8876017c 3098 | 2 | ddraw:IDirectDrawImpl_CreateSurface IDirectDrawImpl_CreateNewSurface failed with 8876017c 2436 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1b50000 dib.bitmap_data=0x1b50000 1217 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1a60000 dib.bitmap_data=0x1a60000 751 | 2 | ole:CoGetClassObject no class object {33246f92-d56f-4e34-837a-9a49bfc91df3} could be created for context 0x4 750 | 2 | ole:create_server class {33246f92-d56f-4e34-837a-9a49bfc91df3} not registered 700 | 1 | d3d_surface:IWineD3DBaseSurfaceImpl_CreateDIBSection CreateDIBSection failed! 584 | 58 | ole:CoCreateInstance apartment not initialised The Most Chatty Channels ------------------------ Includes the ERR and FIXME messages for a channel sorted by the number of lines. Channel | Lines -----------+------ d3d | 34496 d3d_surface| 19381 ole | 19172 shdocvw | 16462 ddraw | 15058 shell | 13980 msi | 9177 dinput | 8476 win | 6566 wininet | 5625 Further Info: ------------- The sqlite3 database and the SQL commands to output the above info can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/200908-200912/ Questions and feedback are welcome! bye michael

9 13

Re: msi: Fix crash with access to component
by Hans Leidekker 01 Feb '10

01 Feb '10

On Saturday 30 January 2010 12:55:21 André Hentschel wrote: > --- > dlls/msi/files.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 7e74dca..afeb451 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -363,6 +363,8 @@ static UINT ITERATE_DuplicateFiles(MSIRECORD *row, LPVOID param) > { > TRACE("Skipping copy due to disabled component %s\n", > debugstr_w(component)); > + if (!comp) > + return ERROR_INSTALL_FAILURE; > > /* the action taken was the same as the current install state */ > comp->Action = comp->Installed; Where do you see that crash? Are you sure ERROR_INSTALL_FAILURE is appropriate? -Hans

3 2

New valgrind results - with fixes for two kinds of false positives
by Dan Kegel 31 Jan '10

31 Jan '10

Julian kindly pointed out that --vex-iropt-precise-memory-exns=yes is needed to avoid false positives in tricky signal handlers like the one involved in GetBitmapBits(). Adding that didn't slow things down much if any, and got rid of lots of valgrind-specific GetBitmapBits() crashes. Also, I applied what seems like an obvious fix for the subheap_notify_free_all false positives (see http://bugs.winehq.org/show_bug.cgi?id=21553 ), and it got rid of them. I've updated http://wiki.winehq.org/Wine_and_Valgrind correspondingly (and made it a bunch clearer, too). Current results at http://kegel.com/wine/valgrind/logs/2010-01-31-09.46/ Current stats: http://kegel.com/wine/valgrind/logs/2010-01-31-09.46.errs.txt 1 Invalid free/ delete / delete[] 2 Source and destination overlap in memcpy 2 Syscall param writev 3 Use of uninitialised value of size 4 6 Invalid write of size 4 7 Invalid read of size 2 12 Invalid write of size 1 22 Invalid read of size 4 48 Conditional jump or move depends on uninitialised value 78 Invalid read of size 1 283 XXX bytes in XXX blocks are definitely lost total: 464 *All* of the "Invalid read of size 1" errors are in the heap tests, so I'll suppress them for the next run. So we're at 386 warnings currently, a bit better than last time I reported figures, http://www.winehq.org/pipermail/wine-devel/2010-January/080989.html

1 0

Re: [d3d10core/tests] Fix a test failure when no adapters are present
by Paul Vriens 31 Jan '10

31 Jan '10

On 01/28/2010 05:14 PM, Henri Verbeet wrote: > Paul Vriens wrote: >> Hi, >> >> On VMware with the "Standard VGA" adapter and on VirtualBox there are no >> adapters returned when enumerating. >> >> I didn't use broken() as 'no adapters' seems somehow a valid return >> (added Henri to the cc: to prove me wrong). There is a skip() anyway if >> the creation failed. >> >> There will be a patch for dxgi as well along these same lines but I'm >> waiting for responses on this one. >> > This issue has come up before, and although it's a valid return value it > still seems suspicious that VMware / VirtualBox would claim the system > has no graphics adapters. If someone could figure out the reason for > that it would be appreciated. I also seem to remember this being unique > to Windows 7. That said, in principle the patch is ok with me. > Well, it's Windows 7 and Windows 2008. The various VMware graphics drivers all act a bit differently. VMware drivers are getting better and in theory it's possible to enable "Accelerate 3D Graphics" on several platforms but that leads to crashes (the whole guest that is) for one or more of the ddraw tests. So the drivers are not there yet I guess. Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)? -- Cheers, Paul.

2 4

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)
by Geoffrey Hausheer 30 Jan '10

30 Jan '10

On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote: > Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer: > > Is there anything I can do to move this patch forward? I've fixed all > the > > issues that have been raised so far. I have no dea what it is waiting > on, > > and if there is anything I can do to get it committed or if it is just a > > question of being patient. As I said previously I'd happily write a test > > for it, but I couldn't find any examples of how to test a modal dialog > box > > in Wine, so I just don't know what the right way to do that is. > > According to http://source.winehq.org/patches/ the patch is pending. You > may > have more luck if you send some test cases for the unit tests first. > > Which, as I tried to explain in my mail, I have no idea how to do because the function is basically (from user-space) atomic and implements a Modal dialog box, and I haven't seen any Wine tests that deal with anything remotely like that. So I am at a loss as to how to write tests for this function. If that is what is needed to get it committed, then I need guidance as to how to go about it.

2 1