January 2010 - Wine-devel - list.winehq.org

trace() and testing asynchronous callbacks and concurrency
by Joerg-Cyril.Hoehle＠t-systems.com 27 Jan '10

27 Jan '10

Hi, I'm seeking advice and ideas about 2 issues: A) I've added trace() output to a callback function. On a dual-core XP box, output comes out like follows: mmidiid.ci:56.: Ccall:bac7k! 9m: sTg=e3c9s 1t2 fef58 a0 iled: Message 3c9 from command midiStreamOut which is a mixture of characters from: midi.c:56: Callback! msg=3c9... and midi.c:79:Test fa[iled...] What can I do if trace() may produce such valuable output that I don't want to miss it from a test log, i.e. I don't want to remove the trace() entirely? BTW, this is interesting on its own because it proves that at least the MM_MOM_DONE (3c9) callback from midiStreamOut may be sent from another thread than the application's. B) How to sanely test the effects of callbacks yet be compatible with ok() and broken()? The reason is that some callbacks are not invoked on w2k. They are on XP. If you look at my test_notification() pattern in winmm/tests/mci.c, you'll notice that while it's barely useable with ok(), it does not work together with broken(). What I need to express is rc = midiXYZ() ok(callback=MM_MOM_3c9 || broken(callback=none) /* w2k and presumably w9x */) Yet this is incomplete: Not only must the type be tested (MM_MOM_xyz), but also the parameters and other slots of the MSG (e.g. msg.hwnd) or callback function (e.g. midihdr). That's why I created the function test_notification(x,y,z) back then for MCI, which does all that. A possibility may be get_notification() /* retrieve data from callback function or message */ ok(cb_type == MM_MOM_3c9 || broken(cb_type==0)) if (cb_type==MM_MOM_3c9) { if (cb_type==CALLBACK_WINDOW || THREAD) { ok(cb_hwnd == hwnd); } ok(cb_parm1 == mhdr && cb_parm2 == 0); ...} This is getting too verbose fast. Any better suggestion? Thanks for your help, Jörg Höhle

1 0

GSoC 2010 is on
by Kai Blin 27 Jan '10

27 Jan '10

Hi folks, Google announced this year's GSoC incarnation. It would be nice if everybody could have a look at http://wiki.winehq.org/SummerOfCode and check if the project they want to mentor is on there. Also, feel free to propose new projects, assuming a student with low prior knowledge about Wine can complete them in 2 months of time. (They have 3 months, but past experience tells us this almost always takes longer than planned). Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Student Interested in Google Summer of Code 2010
by Arjun Comar 27 Jan '10

27 Jan '10

Hey all, I'm new here and interested in the Wine project for GSoC this year and figured I'd start by introducing myself and hopefully getting to know who's who on this list. I'm a Sophomore CS major at Rose-Hulman Institute of Technology, a science and engineering school in Indiana. I've been writing code since I taught myself how in 7th grade, and I've been using Linux since around that same time. In high school, I volunteered large chunks of my time to various open source projects: Ubuntu, Compiz, etc.. Now that I'm in college, I regret not having quite as much time as I'd like to devote to the Linux community as a whole, so I'm hoping to spend this summer giving something back. A quick explanation of what experience I have (relevant stuff only): Linux, C, OpenGL I've been scanning the wiki for GSoC from last year and noticed that most of the projects didn't have any sort of a status associated with them. I checked in the irc channel, and was told that most of the projects were still open. Of those that don't have a status listed, I'm kinda interested in the d3d9_xx DLLs problem. While I'm not too familiar with DirectX, I figure if I start now I'll have plenty of time to get up to speed. Is this still a problem that needs work? If so, is the mentor listed on the page still accurate? I attempted to contact the listed mentor but wasn't successful. I'd also be interested in working on almost anything else, that project just stuck out to me as something important that hadn't gotten done in a long time. If you have any suggestions for useful projects, or how to go about getting caught up to speed on what I need to know (Windows API, DirectX, and/or the Wine codebase itself), I would appreciate that. It's slow going trying to find all the information on my own, but I'm sure other people have had the same problem before and have found good resources to solve it. I'm very interested in working with all of you for the next few months and hopefully through the summer and beyond. If anyone would like more information, feel free to ask. I've never done this before, so I'm not too sure what kind of information you guys are looking for in a GSoC candidate. Any critique/commentary is appreciated. TL;DR: I'm a student interested in GSoC, help me out! --- Arjun Comar, Rose-Hulman '12 Computer Science

1 0

Re: [PATCH 2/5] d3d9: Add depth clamp tests.
by Stefan Dösinger 26 Jan '10

26 Jan '10

Am 26.01.2010 um 18:31 schrieb Henri Verbeet: > +/* This test tests depth clamping / clipping behaviour: > + * - When D3DRS_CLIPPING is disabled depth values are *clamped* to the > + * minimum/maximum z value.+ hr = IDirect3DDevice9_SetRenderState(device, D3DRS_ZFUNC, D3DCMP_LESSEQUAL); > + ok(SUCCEEDED(hr), "SetRenderState failed, hr %#x.\n", hr); It would be interesting to see how D3DCMP_GREATER behaves with clipping off. Does the clamping occur before the depth test, or after the test but before writing the values into the depth buffer. (ie, is 3.0 > 1.0 or is 3.0 == 1.0) A floating point depth buffer might be interesting as well to see if the clamping is done explicitly, or if just happens due to the limited value range in the depth buffer. I'm fine with postponing this until we get serious about float depth buffers though. (fwiw, ARB_depth_buffer_float suggests that the app will be able to use depths outside 0;1, but doesn't expose this yet, and is left open for future extensions)

2 2

Wine coding style
by Uwe Bonnes 26 Jan '10

26 Jan '10

Hello, are there any examples for Editor settings (e.g. emacs c-mode) resulting in acceptable indentation? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

4 3

Re: [PATCH] [Include]: push/pop pack fixes on 64 bit platforms
by Alexandre Julliard 26 Jan '10

26 Jan '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > (try #2) > > A+ > --- > > include/commctrl.h | 16 ++++++++++++++++ > include/fci.h | 4 ++++ > include/fdi.h | 8 ++++++++ > include/mmsystem.h | 4 ++++ > include/richedit.h | 4 ++++ > include/shlwapi.h | 6 +++++- > include/wingdi.h | 6 ++++++ > include/ws2spi.h | 4 ++++ > 8 files changed, 51 insertions(+), 1 deletions(-) Many of these don't match the PSDK. Also please split the patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [kernel32] Add testcase for bug 21292(corrected)
by Paul Vriens 26 Jan '10

26 Jan '10

On 01/25/2010 06:30 PM, Uwe Bonnes wrote: > This time deleting an eventual created file and with hopefully better > indentation Indentation is still not what it's supposed to be. You are not sticking to the surrounding style, but worse your own patch uses different styles as well. -- Cheers, Paul.

1 0

Re: [PATCH 3/3] xmllite/tests: Add test for XML declaration parsing
by Alexandre Julliard 25 Jan '10

25 Jan '10

Nikolay Sivov <bunglehead(a)gmail.com> writes: > This applies over previous 2 patches series. > > Add test for XML declaration parsing It doesn't work: ../../../tools/runtest -q -P wine -M xmllite.dll -T ../../.. -p xmllite_test.exe.so reader.c && touch reader.ok reader.c:546: Test failed: Expected (0,0), got (0,1751353550) make[2]: *** [reader.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winemp3: incorrect stream handling
by Austin English 25 Jan '10

25 Jan '10

On Sun, Jan 24, 2010 at 6:13 PM, Stefano Guidoni <s.guidoni(a)tin.it> wrote: > One of the examples in the API doc of MPG123 states: "we are not in > feeder mode, so MPG123_OK, MPG123_ERR and MPG123_NEW_FORMAT are the > only possibilities"; however in winemp3 the function MPEG3_StreamOpen > uses mpg123_open_feed(), so those are not the only possibilities in > this case. > > This patch restores background music in Irisu Syndrome > (freeware game, http://appdb.winehq.org/objectManager.php?sClass=version&iId=15598 > , in Crusader Kings and possibly other applications too (like > virtualdub, bug 21091). Please don't send patches as compressed files. -- -Austin

1 0

Re: [4/4] winhttp: Store the context passed to WinHttpSendRequest.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Hans Leidekker <hans(a)codeweavers.com> writes: > See http://bugs.winehq.org/show_bug.cgi?id=21442 > --- > dlls/winhttp/request.c | 1 + > dlls/winhttp/tests/winhttp.c | 16 +++++++++++++--- > 2 files changed, 14 insertions(+), 3 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M winhttp.dll -T ../../.. -p winhttp_test.exe.so winhttp.c && touch winhttp.ok winhttp.c:297: Test failed: WinHttpQueryOption failed: 122 winhttp.c:298: Test failed: expected 0xdeadbef0, got 0 make[2]: *** [winhttp.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0