October 2010 - Wine-devel - list.winehq.org

USB Device Support
by James Mckenzie 19 Feb '11

19 Feb '11

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov 19 Jan '11

19 Jan '11

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang 08 Jan '11

08 Jan '11

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard 11 Dec '10

11 Dec '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

Wine runs IE7!
by Hans Leidekker 26 Nov '10

26 Nov '10

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

First contact
by Andréas LIVET 03 Nov '10

03 Nov '10

Hi all wine developers, I read this mailing list for about one year I guess but I think I never send a message. Because until this Monday, I was a spectator, now I wanna become an "actor", I want to learn how to hack wine :). I don't have a lot of time, 1 hour/week, maybe more, but I just want to fix some bugs, if I find some, and maybe more in the future. I'll take my time. For info, I'm a video game developers for 2 years, so I'm a C++ programmer, I know nothing about C (except what I know from the C++) and even if I'm using exclusively linux (ubuntu) for 3/4 years at home, I'm not comfortable with the POSIX development environment... Not that I'm a fan of Visual C++/Visual Assist but I always use those tools (at school and then at work) and wanted to learn something else. I decided to start with a game (Paraworld, but it could be anything) which can't load a level : when I hit the start game button, I got the loading screen, the music etc. but nothing append. The mouse is still reacting, the music still playing but nothing is loading. There is nothing in the trace too, so I tried with the "WINEDEBUG=+relay", error!! I ended quickly with a log > 300Mo before seeing the main menu! I've seen that there is a patch which allows user to control when debug trace will be display, but I don't know how to find it. I found this page : http://www.mail-archive.com/wine-devel(a)winehq.org/msg05542.html But I can't find the archive (the patch file), is there a place where we could download patches? Maybe my question is very simple, but I'm a beginner so be indulgent, please :). Other question, is there a way with winedbg to "pause" program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. This is possible with VCC, maybe it's not with winedbg? Anyway, thank you for your time, and I want to congratulate all the wine developers for their amazing work, win is getting better and better everyday thanks to you, Andréas --Not sent from an iPhone.

3 7

Re: [PATCH 4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO.
by testbot＠testbot.winehq.org 31 Oct '10

31 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20). sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20).

1 0

up for a quick challenge? "Test Drive Unlimited 2" open beta this weekend only...
by Dan Kegel 31 Oct '10

31 Oct '10

and installs ok with dotnet20... but it's stuck on "Checking files, please wait". http://appdb.winehq.org/objectManager.php?sClass=version&iId=21811 http://en.wikipedia.org/wiki/Test_Drive_Unlimited_2 (Wikipedia says it will require .net 3.5, ugh.) While it's sitting, it outputs stuff like fixme:thread:NtQueryInformationThread info class 16 not supported yet fixme:ole:Context_CC_ContextCallback (0x4956060/0x4956064)->(0x79f277a5, 0x2a7e4e8, {d7174f82-36b8-4aa8-800a-e963ab2dfab9}, 2, (nil)) fixme:thread:NtQueryInformationThread info class 16 not supported yet I guess the next step is to look at the packets on the wire on windows and see if it's getting stuck trying to phone home...

1 0

Re: comctl32/treeview: Make item data layout partially compatible with native one
by testbot＠testbot.winehq.org 31 Oct '10

31 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6609 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === No test summary line found === W2KPROSP4 (32 bit treeview) === No test summary line found

1 0

Purist keyword?
by Austin English 31 Oct '10

31 Oct '10

I see quite a few people filing bugs that are only exposed when bundled native dlls are removed. I think it would be good to be able to group these bugs, perhaps with a 'purist' keyword. Anyone opposed?

5 6