October 2010 - Wine-devel - list.winehq.org

RFC: quartz: Don't block indefinitely when pausing after end of stream
by Vladimir Panteleev 31 Oct '10

31 Oct '10

The attached patch attempts to fix http://bugs.winehq.org/show_bug.cgi?id=24869 , but due to my limited knowledge of DirectShow I'm not certain about its correctness. Can anyone point out if there's anything wrong with it?

1 0

Re: Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken.
by Vitaliy Margolen 31 Oct '10

31 Oct '10

On 10/30/2010 06:12 AM, Sami Aario wrote: > Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken. > > From: Sami Aario <saempy(a)hima.(none)> Your e-mail isn't set correctly in git configuration. > dlls/ntdll/nt.c | 63 ++++++++++++++++++++++++++++++++++++++++ > include/wine/server_protocol.h | 18 +++++++++++- > server/protocol.def | 6 ++++ > server/request.h | 5 +++ > server/token.c | 36 +++++++++++++++++++++++ > server/trace.c | 10 ++++++ Please don't include changes to automatically generated files (server_protocol.h, request.h, trace.c). > + SERVER_START_REQ( set_token_sid ) > + { > + SID *sid = ((TOKEN_OWNER *)TokenInformation)->Owner; > + WORD size; > + > + if (sid) size = RtlLengthRequiredSid(sid->SubAuthorityCount); > + else size = 0; > + > + TRACE("size=%d\n", size); > + > + req->handle = wine_server_obj_handle( TokenHandle ); > + req->which_sid = TokenInformationClass; > + wine_server_add_data( req, sid, size ); > + ret = wine_server_call( req ); > + } > + SERVER_END_REQ; Please get everything outside of SERVER_START_REQ()/SERVER_END_REQ except actual wine_server function calls and handling of returned result(s). Some functions can do their own server calls and you will have a deadlock. > + case TokenOwner: > + free( token->user ); > + token->user = NULL; > + > + if (sid_len) > + token->user = memdup( sid, sid_len ); > + break; This is wrong, you can't clear token user - it always have to be set, or you risking an assert in get_token_sid. Which means you have to validate the data user passes in. Vitaliy.

1 0

re: Purist keyword?
by Dan Kegel 30 Oct '10

30 Oct '10

The keyword might be useful for a pragmatist looking for bugs to fix, who didn't want to fix bugs masked by a bundled native DLL. I don't know how many such people there are, though. Best to wait until somebody says they need the keyword before we add it... until then, we can just use the word 'purist' in the body of the bug as we've started doing.

1 0

re: WINE Performance and Evernote 4.0 Windows Client
by Dan Kegel 30 Oct '10

30 Oct '10

Hi Martin, > http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks for letting us know. Looking at that thread, your message, and the appdb entry http://appdb.winehq.org/objectManager.php?sClass=version&iId=21775 it looks like people are reporting four or so problems: - autoupdate doesn't work - pdf preview hangs or is slow - switching notebooks is slow - clicking on menu is slow It would probably help to have Wine bug reports at http://bugs.winehq.org for each individual problem, with clear instructions for non-Evernote users on how to reproduce them. (I'd file a couple myself, but I don't have time to experiment at the moment.) - Dan

1 0

ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel
by David Adam 30 Oct '10

30 Oct '10

Any problem with this patch? A+ David

1 0

WINE Performance and Evernote 4.0 Windows Client
by Martin Packer 30 Oct '10

30 Oct '10

Evernote are in the process of releasing 4.0 of their Windows client. This is completely rewritten to avoid the use of things that would stop it running under WINE. (This WASN'T their target - it was more about device drivers that had been problematic.) It runs reasonably well on the latest WINE. However it runs slowly (in a way it doesn't under "real" Windows) and also the autoupdater doesn't seem to work. Is anyone here willing to work with them and us to help it run faster? (I haven't got commitment from Evernote to make changes but I have got their attention now.) :-) Hopefully you can see this thread on the Evernote bulletin board: http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks, Martin Martin Packer, Mainframe Performance Consultant, zChampion Worldwide Banking Center of Excellence, IBM +44-7802-245-584 email: martin_packer(a)uk.ibm.com Twitter / Facebook IDs: MartinPacker Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

1 0

Linux kernel and game performance?
by Dan Kegel 29 Oct '10

29 Oct '10

Hey folks, I've run into two web sites that claim that the Linux kernel causes performance problems in particular games (see below). Anybody know of others? And has anybody found concrete improvements in performance of a particular app (other than an audio workstation app) from using a realtime kernel? Thanks! - Dan First: http://wiki.archlinux.org/index.php/World_of_Warcraft#Kernel_Timing_Bug says in a section dated September 2008: "If you are having problems with choppy video every 15 seconds or so, it is related to the kernel scheduler... to fix, add CONFIG_SCHED_DEBUG=y to your kernel config, then set kernel.sched_features=21 kernel.sched_batch_wakeup_granularity_ns=25000000 kernel.sched_min_granularity_ns=4000000 in /etc/sysctl.cfg." Yikes. Any truth to that rumor? Second: http://hisouten.koumakan.jp/wiki/Linux_support#Resolved_bugs says "The game runs too slowly Symptoms: Instead of running at about 60-62fps, like the game is supposed to, it'll run closer to 53fps. This is not ideal. The bug: This is a Linux timing issue. The game runs a secondary timing thread with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms and sends events to the main thread to tell it that a new frame is needed. On Linux the necessary timing accuracy is not available, so it wavers between 16ms and 20ms. The fix: I hacked around this by setting the timer period to 14ms. This leads to a steady 62-63fps. Which is close enough for use, really. For a constant 60fps turn on vsync in your video drivers."

4 5

Re: Windows Installer change in behaviour Wine 1.3.5.
by James Mckenzie 29 Oct '10

29 Oct '10

Damian Dixon <damian.dixon(a)gmail.com> wrote: {Please send replies only to the Wine Devel mailing list.} > >I have installed my application under Wine 1.3.5 however with this version >of Wine the registry is not updated by the installer. Name of application, Linux distribution please. Also please file a bug report, if one does not exist. > >The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as >it has worked before with older versions of Wine. > Looks like a regression to me. However, 1.3.6 is about to be released (maybe today.) Would have been great to catch this. James McKenzie

1 0

Re: [3/3] gdi32: Make AddFontToList return a pointer to first loaded face.
by Alexandre Julliard 29 Oct '10

29 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 35 ++++++++++++++++++++--------------- > 1 files changed, 20 insertions(+), 15 deletions(-) You are lucky, it turns out that I screwed up and committed your original patch by mistake ;-) But I still don't see why you are returning that pointer, could you please send the code that makes use of this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Crash bug in Wine 1.3.5 in advapi32/service.c
by Damian Dixon 29 Oct '10

29 Oct '10

Hi, In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the lpservicestatus is not checked to see if the value is NULL. This causes a crash in an application that has worked before under wine. My naive change is: if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData, sizeof(SERVICE_STATUS)) ; Regards Damian

2 1