October 2010 - Wine-devel - list.winehq.org

Re: [2/3] msxml3/httprequest: Implement POST support with supplied body data
by Alexandre Julliard 11 Oct '10

11 Oct '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Implement POST support with supplied body data It crashes here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok wine: Unhandled page fault on read access to 0x00610054 at address 0x556c7d55 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00610054 in 32-bit code (0x556c7d55). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:556c7d55 ESP:0032fad0 EBP:0032fb28 EFLAGS:00010202( R- -- I - - - ) EAX:00130f98 EBX:5570b4ec ECX:0061004c EDX:000401e8 ESI:68f31924 EDI:0032fbd4 Stack dump: 0x0032fad0: 00130f98 001259d8 00000000 68f31924 0x0032fae0: 0032fb0c 0012b0a4 0032fb08 687e878b 0x0032faf0: 68894798 00000000 7bc49ceb 000401e8 0x0032fb00: 001329b8 00000000 0032fb68 00130f98 0x0032fb10: 001329b8 55704230 0032fbd8 5570b4ec 0x0032fb20: 68f31924 001329b8 0032fb88 556de570 Backtrace: =>0 0x556c7d55 bind_to_storage+0x145(url="http://crossover.codeweavers.com/xmltest.xml", pbc=0x1259d8, riid=0x68f31924, ppv=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon (0x0032fb88) 1 0x556de570 URLMoniker_BindToStorage+0x7f(iface=0x1329b8, pbc=0x1259d8, pmkToLeft=(nil), riid=0x68f31924, ppvObject=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/umon.c:226] in urlmon (0x0032fbf8) 2 0x68f0ac2f httprequest_send+0x29e(iface=0x132560, body={n1={n2={vt=0, wReserved1=0, wReserved2=0x549f, wReserved3=0x7bc3, n3={cVal=-92, uiVal=0x25a4, ulVal=0x1325a4, intVal=0x1325a4, uintVal=0x1325a4, bVal=-92, iVal=0x25a4, lVal=0x1325a4, fltVal=0.000000, dblVal=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, boolVal=0x25a4, scode=0x1325a4, date=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, bstrVal="GET", cyVal={={Lo=0x1325a4, Hi=0x7b88577c}, int64=0x7b88577c001325a4}, punkVal=0x1325a4, pdispVal=0x1325a4, parray=0x1325a4, llVal=0x7b88577c001325a4, ullVal=0x7b88577c001325a4, pcVal="G", puiVal="GET", pulVal=0x1325a4, pintVal=0x1325a4, puintVal=0x1325a4, pbVal="G", piVal=0x1325a4, plVal=0x1325a4, pfltVal=0x1325a4, pdblVal=0x1325a4, pboolVal=0x1325a4, pscode=0x1325a4, pdate=0x1325a4, pbstrVal=0x1325a4, pvarVal=0x1325a4, byref=0x1325a4, pcyVal=0x1325a4, pdecVal=0x1325a4, ppunkVal=0x1325a4, ppdispVal=0x1325a4, pparray=0x1325a4, pllVal=0x1325a4, pullVal=0x1325a4, brecVal={pvRecord=0x1325a4, pRecInfo=0x7b88577c}}}, decVal={wReserved=0, u={={scale=0, sign=0}, signscale=0}, Hi32=0x7bc3549f, u1={={Lo32=0x1325a4, Mid32=0x7b88577c}, Lo64=0x7b88577c001325a4}}}}) [/home/julliard/wine/wine/dlls/msxml3/httprequest.c:472] in msxml3 (0x0032fd38) 3 0x6868d935 func_domdoc+0x1104() [/home/julliard/wine/wine/dlls/msxml3/tests/domdoc.c:3370] in msxml3_test (0x0032fd88) 4 0x6869e92e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:556] in msxml3_test (0x0032fe48) 5 0x6869eb27 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:624] in msxml3_test (0x0032fe90) 6 0x6869f6ac __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msxml3_test (0x0032fea8) 7 0x7b856cfc call_process_entry+0xb() in kernel32 (0x0032fee8) 8 0x7b8591fb start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 9 0x7bc72d30 call_thread_func+0xb() in ntdll (0x0032ffc8) 10 0x7bc72f00 call_thread_entry_point+0x6f(entry=0x7b8591a0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 11 0x7bc4db1a start_process+0x29(kernel_start=0x7b8591a0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x556c7d55 bind_to_storage+0x145 [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon: call *0x8(%ecx) 1623 IBinding_Release(BINDING(binding)); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Fix D3DXPlaneNormalize on 64 bits.
by Henri Verbeet 11 Oct '10

11 Oct '10

On 8 October 2010 16:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > This patch changes D3DXPlaneNormalize to behave as native on 64 bits, > returning infinity in the fourth plane component when the norm is 0. > If this is not appropriate, I can resend without the implementation > changes, just fixing the tests. > I can't say this is necessarily wrong, but I do think it looks suspicious.

3 2

Re: [5/6] msi/tests: Set the MSIFASTINSTALL property.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6077 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [1/6] msi/tests: Determine Wow64 mode just once.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6073 Your paranoid android. === W2K8SE (32 bit install) === Timeout === W7PROX64 (64 bit install) === install.c:10489: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet 11 Oct '10

11 Oct '10

On 7 October 2010 19:49, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Draw a full screen quad */ > +static void draw_quad_with_shader9(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geometry) > +{ > + HRESULT hr; > + D3DXMATRIX projection_matrix; > + > + D3DXMatrixOrthoLH(&projection_matrix, 2.0f, 2.0f, 0.0f, 1.0f); > + IDirect3DDevice9_SetTransform(device, D3DTS_PROJECTION, &projection_matrix); > + > + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, D3DCOLOR_XRGB(0, 0, 0), 1.0f, 0); > + ok(hr == D3D_OK, "IDirect3DDevice9_Clear returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_BeginScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_BeginScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_SetStreamSource(device, 0, quad_geometry, 0, sizeof(struct vertex)); > + ok(hr == D3D_OK, "IDirect3DDevice9_SetStreamSource returned: %08x\n", hr); > + hr = IDirect3DDevice9_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 2); > + ok(hr == D3D_OK, "IDirect3DDevice9_DrawPrimitive returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_EndScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_EndScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); > + ok(hr == D3D_OK, "IDirect3DDevice9_Present returned: %08x\n", hr); > +} > + Backbuffer contents are undefined after present.

1 0

Re: ddraw/test: Add more combinaison tests for SetCooperativeLevels
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6071 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: cabinet/tests: Reformated output in case of test failure (try 3)
by Alexandre Julliard 11 Oct '10

11 Oct '10

Marko Nikolic <grkoma(a)gmail.com> writes: > @@ -109,9 +109,9 @@ static void test_FDICreate(void) > ok(hfdi != NULL, "Expected non-NULL context\n"); > ok(GetLastError() == 0xdeadbeef, > "Expected 0xdeadbeef, got %d\n", GetLastError()); > - ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %d\n", erf.erfOper); > - ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %d\n", erf.erfType); > - ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %d\n", erf.fError); > + ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %x\n", erf.erfOper); > + ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %x\n", erf.erfType); > + ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %x\n", erf.fError); Most of these are error codes too, they should be in decimal. I don't see why you want to change this at all. If you think having the expected value printed in hex is confusing just get rid of it, it's useless anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try3]
by Alexandre Julliard 11 Oct '10

11 Oct '10

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -11,6 +25,8 @@ echo. > echo . > echo.word > echo .word > +echo word > +echo word You need some escaping mechanism for these trailing spaces too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: toolhelp: Document InterruptRegister16
by Alexandre Julliard 11 Oct '10

11 Oct '10

Thomas Bleher <ThomasBleher(a)gmx.de> writes: > @@ -593,6 +593,29 @@ BOOL16 WINAPI StackTraceNext16(STACKTRACEENTRY *ste) > > /*********************************************************************** > * InterruptRegister (TOOLHELP.75) > + * > + * Registers a callback to intercept certain special events from any process. > + * > + * The special events are (TODO: There may be other events not listed here; > + * these are the ones documented in the patent mentioned below): These are standard x86 traps, they don't need special constants or documentation. Besides, if there's really a patent about this we can't implement it anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > } > > /* Add master channel, uncounted channels and an extra for capture */ > - mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > + /* Do not add the extra channel needed for capture on half-duplex capture cards > + like snd_usb_audio mics */ > + if (micelem && !mastelem && !captelem) > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem; > + else > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem + 1; This statement wasn't exactly clear before, but now it's really impossible to follow. Please rewrite this in a way that makes sense to a casual reader. -- Alexandre Julliard julliard(a)winehq.org

4 3