October 2010 - Wine-devel - list.winehq.org

Re: wine_call_on_stack Sparc Edition
by André Hentschel 07 Oct '10

07 Oct '10

Oops, wrong address, sry for the noise -- Best Regards, André Hentschel

1 0

Re: psapi/tests: get rid of an ugly test macro
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=108

1 0

Re: [PATCH] d3d9/tests: Fix test failure for IDirect3D9::CreateDevice in test_set_stream_source
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === W2K8SE (32 bit device) === device.c:2474: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2612: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (32 bit device) === device.c:2474: Test failed: Expected foreground window 0002019A, got 00010092. device.c:2612: Test failed: Expected foreground window 0003019A, got 00010092.

1 0

Re: usp10: when checking font for shaping the font needs at least 1 of the features but does not need all.
by Dmitry Timoshkov 07 Oct '10

07 Oct '10

Aric Stewart <aric(a)codeweavers.com> wrote: > - while (ShapingData[psa->eScript].requiredFeatures[i]) > + while (ShapingData[psa->eScript].requiredFeatures[i] && !found) > { > feature = load_GSUB_feature(hdc, psa, psc, ShapingData[psa->eScript].requiredFeatures[i]); > - if (!feature) > - return USP_E_SCRIPT_NOT_IN_FONT; > + if (feature) > + found = TRUE; Why not return S_OK right away here, and return USP_E_SCRIPT_NOT_IN_FONT right after the while loop? That would eliminate a need for an intermediate variable and simplify the code. -- Dmitry.

1 0

Test failures on Windows XP Japanese due to fonts selection differences
by Austin Lund 07 Oct '10

07 Oct '10

There are a number of test failures due to hardcoded sizes in test which fail for particular platforms, e.g. http://test.winehq.org/data/6e89a61446088dbe029913896dfae467bb8d37a1/xp_wtb… It seems the reason for this is that it is impossible to select the system font with height 16 on this platform. (No idea why, any ideas?) Should these tests be written so that a particular font selection is forced across platforms (e.g. ANSI, 16 point, System), or should the hardcoded values instead be computed for each particular instance?

1 0

New version of exe-thumbnailer (0.7)
by Scott Ritchie 07 Oct '10

07 Oct '10

Includes much prettier icons, support for Vista icons (with icoutils 0.29.1) and more. Screenshots and a description are at: http://wiki.winehq.org/exe-thumbnailer -Scott Ritchie

4 6

Re: [PATCH 06/10] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5914 Your paranoid android. === W2K8SE (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL === W7PROX64 (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL

1 0

Translation patches for wine-1.2.1
by Michael Stefaniuc 06 Oct '10

06 Oct '10

Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't produce conflicts. Though the removal of the unneeded "Remove the ignored common resource attributes" patches makes "wrc --verify-translation" produce DIFF lines for resources that were added at a later time as those don't have the ignored common resource attributes. bye michael

2 2

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.
by Alexandre Julliard 06 Oct '10

06 Oct '10

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 20 +++++++++++++++++--- > 1 files changed, 17 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmllocation.c && touch htmllocation.ok wine: Unhandled page fault on read access to 0x00000110 at address 0x555d325a (thread 001f), starting debugger... Unhandled exception: page fault on read access to 0x00000110 in 32-bit code (0x555d325a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555d325a ESP:0032dfd0 EBP:0032e038 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00ed2bf4 EBX:5561bc84 ECX:002078c0 EDX:555d31c0 ESI:0126f400 EDI:00000000 Stack dump: 0x0032dfd0: 00ed2b98 0032e3a8 0032e008 6ad698bc 0x0032dfe0: 002078b0 00000001 00000001 0032e078 0x0032dff0: 6adbe4f5 002078b0 0032e018 00000000 0x0032e000: 002078b0 6b127f9c 0032e028 6ad697d8 0x0032e010: 002078b0 0032e074 00000001 00000000 0x0032e020: 002078a8 0032e074 0032e068 012ad758 Backtrace: =>0 0x555d325a handle_load+0x9a(iface=0x126f5c0, event=0x12ad758) [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml (0x0032e158) 1 0x6a02f1db in xul (+0x3ef1da) (0x0032e1d8) 2 0x6aca1e00 in xul (+0x1061dff) (0x0032e208) 3 0x6aca1fe1 in xul (+0x1061fe0) (0x0032e258) 4 0x6a047958 in xul (+0x407957) (0x0032e2a8) 5 0x6a04819c in xul (+0x40819b) (0x0032e378) 6 0x69dc9c12 in xul (+0x189c11) (0x0032e408) 7 0x6a53d3a0 in xul (+0x8fd39f) (0x0032e698) 8 0x6a53ced6 in xul (+0x8fced5) (0x0032e718) 9 0x6a5574c8 in xul (+0x9174c7) (0x0032e768) 10 0x6a556567 in xul (+0x916566) (0x0032e798) 11 0x6a556371 in xul (+0x916370) (0x0032e7e8) 12 0x6a555fa2 in xul (+0x915fa1) (0x0032e858) 13 0x69c66091 in xul (+0x26090) (0x0032e898) 14 0x555cbc1b on_stop_nsrequest+0x8a(This=0xed4da0, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8d8) 15 0x555cbc1b on_stop_nsrequest+0x8a(This=0x10, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8e8) 16 0x555cca5f nsChannelBSC_stop_binding+0x1e(bsc=0x126fe08, result=0x555d31c0) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1184] in mshtml (0x0032e928) 17 0x555cb126 BindStatusCallback_OnStopBinding+0x35(iface=0x126fe08, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:360] in mshtml (0x0032e968) 18 0x68f3f838 BindStatusCallback_OnStopBinding+0x87(iface=0x129b090, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindctx.c:178] in urlmon (0x0032e988) 19 0x68f40c5d stop_binding+0x3c(binding=0x129b118, hres=0xffffffff80004004, str=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:221] in urlmon (0x0032e9d8) 20 0x68f41dde InternetProtocolSink_ReportResult+0x8d(iface=0x129b11c, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1149] in urlmon (0x0032ea28) 21 0x68f47abd BPInternetProtocolSink_ReportResult+0xec(iface=0x129b578, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:1184] in urlmon (0x0032ea48) 22 0x68f50b5d report_result+0x3c() in urlmon (0x0032ea58) 23 0x68f50c1d protocol_abort+0x2c(protocol=0x2078c0, reason=0xffffffff80004004) [/home/julliard/wine/wine/dlls/urlmon/protocol.c:439] in urlmon (0x0032ea98) 24 0x68f4cbd4 HttpProtocol_Abort+0x73(iface=0x129b764, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/http.c:445] in urlmon (0x0032eae8) 25 0x68f452b0 ProtocolHandler_Abort+0x5f(iface=0x129b580, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:662] in urlmon (0x0032eb38) 26 0x68f459db BindProtocol_Abort+0x7a(iface=0x129b568, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:429] in urlmon (0x0032eb68) 27 0x68f4140b Binding_Abort+0x5a(iface=0x129b118) [/home/julliard/wine/wine/dlls/urlmon/binding.c:892] in urlmon (0x0032eb88) 28 0x555ca834 set_window_bscallback+0x23(window=0xed2b98, callback=(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1349] in mshtml (0x0032ebd8) 29 0x555c54a1 HTMLWindow2_Release+0x70(iface=0xed2ba8) [/home/julliard/wine/wine/dlls/mshtml/htmlwindow.c:228] in mshtml (0x0032ec18) 30 0x55580881 CustomDoc_Release+0x80(iface=0x129db0) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2021] in mshtml (0x0032ec38) 31 0x5557ea04 HTMLDocument_Release+0x13(iface=0x129ca8) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:376] in mshtml (0x0032fd08) 32 0x686a82f5 perform_test+0xd34(test=0x686c24c3) [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:348] in mshtml_test (0x0032fd38) 33 0x686a838e func_htmllocation+0x3d() [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:360] in mshtml_test (0x0032fd88) 34 0x686b535e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe48) 35 0x686b5557 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:624] in mshtml_test (0x0032fe90) 36 0x686b60dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fea8) 37 0x7b856c4c call_process_entry+0xb() in kernel32 (0x0032fee8) 38 0x7b85914b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 39 0x7bc72b80 call_thread_func+0xb() in ntdll (0x0032ffc8) 40 0x7bc72d50 call_thread_entry_point+0x6f(entry=0x7b8590f0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 41 0x7bc4da6a start_process+0x29(kernel_start=0x7b8590f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x555d325a handle_load+0x9a [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml: movl 0x110(%edi),%eax 226 if(doc_obj->nscontainer->editor_controller) { -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cryptui: Fix a crash with certification path (resend)
by Alexandre Julliard 06 Oct '10

06 Oct '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) > */ > tvis.u.item.iImage = 2; > } > - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. > - dwErrorStatus == 0) > + else if (i > 1 && > + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) What is this change for? -- Alexandre Julliard julliard(a)winehq.org

3 3