November 2010 - Wine-devel - list.winehq.org

Re: msvcrt: Implement _asctime_s and _wasctime_s.
by Alexandre Julliard 04 Nov '10

04 Nov '10

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > +MSVCRT_long CDECL MSVCRT_asctime_s(char *output, MSVCRT_size_t max, const struct MSVCRT_tm *mstm) > +{ > + char *buffer; > + MSVCRT_size_t bufflen; > + > + if (output && max > 0) > + output[0] = '\0'; > + if (!output) > + { > + *MSVCRT__errno() = MSVCRT_EINVAL; > + return MSVCRT_EINVAL; > + } You probably want to use the new parameter checking macros. Also the first check is redundant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] slc: Implement SLGetWindowsInformationDWORD
by Alexandre Julliard 04 Nov '10

04 Nov '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > +HRESULT WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > +{ > + FIXME("(%s, %p): semi-stub\n", debugstr_w(lpszValueName), pdwValue); > + > + if (!lpszValueName || !pdwValue) > + return E_INVALIDARG; > + > + if (!*lpszValueName) > + return SL_E_RIGHT_NOT_GRANTED; > + > + /* We have always a genuine Wine */ > + *pdwValue = 1; > + return S_OK; There's no reason that this dword would represent the genuine flag, it can be just about anything. Returning value not found would probably be preferable, or else do a real attempt at determining what value would be expected for the specified name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 5)
by Alexandre Julliard 04 Nov '10

04 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat calls. You should stop trying to pass a case_sensitive flag to find_file_in_dir and have it take care of everything internally, if and only if a case insensitive search seems to be required. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: msvcrt: Implement _get_tzname.
by Eryk Wieliczko 04 Nov '10

04 Nov '10

http://msdn.microsoft.com/en-us/library/4ssfs1ya.aspx _get_tzname should simply copy the contents of _tzname. In my opinion it should be ok. According to this document it's the default value. In my Polish XP it's also "PST" and "PDT", which is of course irracional ( Poland is in Europe ). So I would assume static char tzname_std[64] = ""; static char tzname_dst[64] = ""; more of a hack. 2010/11/3 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > This is not an implementation, this is a quick and dirty hack. > > -- > Dmitry. >

2 1

RFC: Fixing comctl32 toolbar tests for different system font heights
by Austin Lund 04 Nov '10

04 Nov '10

I'm trying to fix these test failures: http://test.winehq.org/data/d4f64121e83671ac10ed6ead04f1c19eb5586cb0/xp_wtb… These failures occur because the system font metrics are different to what is assumed for the hard-coded numbers. Attached is my go at fixing these (in a three part patch set). Is this approach even close to being the right way to do this?

1 0

Re: [PATCH 3/5] d3d9/tests: Check for multiple expected messages in test_wndproc().
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6786 Your paranoid android. === WVISTAADM (32 bit device) === device.c:2650: Test failed: Expected foreground window 000301CA, got 000201C8.

1 0

Re: [PATCH 2/5] d3d8/tests: Check for multiple expected messages in test_wndproc().
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6785 Your paranoid android. === WVISTAADM (32 bit device) === device.c:1670: Test failed: Expected foreground window 000201D4, got 000101D2. === W2K8SE (32 bit device) === device.c:1670: Test failed: Expected foreground window 00010126, got 0001011A.

1 0

Re: [PATCH] kernel32: Add a stub for SetProcessDEPPolicy
by Marcus Meissner 04 Nov '10

04 Nov '10

On Wed, Nov 03, 2010 at 11:54:33PM +0100, Detlef Riekenberg wrote: > --- > dlls/kernel32/kernel32.spec | 1 + > dlls/kernel32/process.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 8381ae8..f32371e 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -1053,6 +1053,7 @@ > @ stdcall SetNamedPipeHandleState(long ptr ptr ptr) > @ stdcall SetPriorityClass(long long) > @ stdcall SetProcessAffinityMask(long long) > +@ stdcall SetProcessDEPPolicy(long) > @ stdcall SetProcessPriorityBoost(long long) > @ stdcall SetProcessShutdownParameters(long long) > @ stdcall SetProcessWorkingSetSize(long long long) > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index fdd19db..86747d9 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3394,3 +3394,11 @@ DEP_SYSTEM_POLICY_TYPE WINAPI GetSystemDEPPolicy(void) > FIXME("stub\n"); > return OptIn; > } > +/********************************************************************** > + * SetProcessDEPPolicy (KERNEL32.@) > + */ > +BOOL WINAPI SetProcessDEPPolicy(DWORD newDEP) > +{ > + FIXME("(%d): stub\n", newDEP); > + return TRUE; > +} Perhaps return FALSE; and SetLastError(..NOTIMPLEMENTED...) as we did not actually do it. (always better not to lie with security related functions.) Ciao, MArcus

1 0

Re: msvcrt/tests: _itow_s tests (try 3)
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6779 Your paranoid android. === WVISTAADM (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W2K8SE (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PRO (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PROX64 (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PROX64 (64 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler

1 0

Re: [2/2] msvcrt/tests: qsort_s implementation and tests (try 3)
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6778 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0