December 2010 - Wine-devel - list.winehq.org

Re: [PATCH 5/6] urlmon: Add new on_error function to protocol vtbl.
by Jacek Caban 22 Dec '10

22 Dec '10

Hi David On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/protocol.c | 6 +++++- > dlls/urlmon/urlmon_main.h | 1 + > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/dlls/urlmon/protocol.c b/dlls/urlmon/protocol.c > index 669343b..bb17453 100644 > --- a/dlls/urlmon/protocol.c > +++ b/dlls/urlmon/protocol.c > @@ -107,7 +107,11 @@ static void request_complete(Protocol *protocol, INTERNET_ASYNC_RESULT *ar) > TRACE("(%p)->(%p)\n", protocol, ar); > > if(!ar->dwResult) { > - WARN("request failed: %d\n", ar->dwError); > + if(protocol->vtbl->on_error) > + protocol->vtbl->on_error(protocol, ar->dwError); > + else > + WARN("request failed: %d\n", ar->dwError); We want it in all protocol handlers. Please add stubs (with FIXME) to all of them and remove NULL-check here. Also you will leave the object in an invalid state if we're in a middle of downloading at this point. You can limit this patch to the first request_complete notification (using FLAG_FIRST_CONTINUE_COMPLETE flag) or make sure we're doing things right. Cheers, Jacek

1 0

RE: shdocvw/tests: need to save .url before committing extra props for
by Greg Geldorp 22 Dec '10

22 Dec '10

Discard this one, should have run the modified tests on Wine too... Greg.

1 0

Re: [PATCH 1/3] msvcrt/tests: Add _fcvt_s tests.
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7749 Your paranoid android. === W2KPROSP4 (32 bit printf) === printf: unhandled exception c0000005 at 77FCD79A === WXPPROSP3 (32 bit printf) === printf: unhandled exception c0000005 at 7C911689 === W2K3R2SESP2 (32 bit printf) === printf: unhandled exception c0000005 at 7C82CAC2

1 0

Re: sane.ds: sync resource headers
by Michael Stefaniuc 21 Dec '10

21 Dec '10

On 12/21/2010 08:00 PM, André Hentschel wrote: > --- > dlls/sane.ds/sane_Ko.rc | 2 +- > dlls/sane.ds/sane_Ro.rc | 2 ++ > 2 files changed, 3 insertions(+), 1 deletions(-) > diff --git a/dlls/sane.ds/sane_Ro.rc b/dlls/sane.ds/sane_Ro.rc > index 5b162fd..20893a6 100644 > --- a/dlls/sane.ds/sane_Ro.rc > +++ b/dlls/sane.ds/sane_Ro.rc > @@ -1,4 +1,6 @@ > /* > + * Romanian resources for Twain > + * > * Copyright 2006 CodeWeavers, Aric Stewart > * Copyright 2008 Michael Stefaniuc > * That wasn't an omission on my part but I explicitly leave that out as that info is redundant. And people tend to forget to update that when they copy the file. bye michael

2 2

Possible problem with Natty 64-bit compile
by Susan Cragin 21 Dec '10

21 Dec '10

I have downloaded the git, compiled and installed wine as 64-bit on the current 64-bit version of Natty. This all works fine, no errors I can see, but then it doesn't run. My executables can be found, including: /usr/local/bin/wine64 and wine64-preloader But I can't run anything. A "wine" command tells me wine isn't installed, which I guess it isn't, and "wine64" gives me a segmentation fault. Do I need a symlink? ubuntu$ wine notepad The program 'wine' can be found in the following packages: * wine-bin-unstable * wine1.2 * wine1.0 Try: sudo apt-get install <selected package> ubuntu:~$ wine64 notepad Segmentation fault ubuntu:~$

2 1

Re: kernel32/tests: Quote command line arguments that might contain spaces
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7737 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:320: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtFF83.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2644 != 2046 debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:313: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD465.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2768 != 2046 Timeout === W7PROX64 (32 bit process) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test.exe

1 0

Re: kernel32/tests: Remove check of environment variables against registry
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7738 Your paranoid android. === W7PROX64 (64 bit environ) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test64.exe

1 0

RFC: New winetricks options --optin, --optout
by Dan Kegel 21 Dec '10

21 Dec '10

I'm interested in which winetricks verbs people are using, mostly so I can nuke the ones that nobody cares about, but also so I can pay more attention to making sure popular ones work. So I added an --optin option to winetricks; if you give that option, winetricks will report which verbs you use. You can turn this off again with --optout. This is only in svn, not yet in the released version, and it's only a commandline thing; GUI users are currently unaffected. See http://code.google.com/p/winezeug/source/detail?r=2137 I kind of expect not many people to find that option and turn it on, so it seemed safe to add. If the community agrees, at some point I'll change the GUI to ask users on first run whether they want to help winetricks development by reporting usage information. Comments? - Dan

3 2

Re: user32/cursoricon: Fix an uninitialized pointer.
by Adam Martinson 20 Dec '10

20 Dec '10

On 12/20/2010 01:40 PM, Adam Martinson wrote: > --- > dlls/user32/cursoricon.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) > > This is wrong, please ignore it.

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7721 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0