December 2010 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] shell32: Add IInputObject stub to ExplorerBrowser. (try 2)
by Alexandre Julliard 23 Dec '10

23 Dec '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + hr = IInputObject_TranslateAcceleratorIO(pio, &msg_a); > + todo_wine ok(hr == found ? S_OK : S_FALSE, "Got 0x%08x (%04x)\n", hr, i); That doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Death to win9x?
by Joerg-Cyril.Hoehle＠t-systems.com 23 Dec '10

23 Dec '10

Dan Kegel wrote: >I'm all for removing stuff that nobody needs anymore. Who said nobody needs Win9x anymore? > I imagine there >are still a few popular older apps that will force us to keep some old >win9x behaviors around, though, so we probably won't be able >to remove the 'emulate win98' choice from winecfg any time soon. Probably half of the apps I bought during the last years work with Win9X. Just the other day I saw a mciSendCommand16 in a log. Well, 16bit != win9x. Is it "Death to 16bit" you meant? What's the motivation behind removing stuff *now* suddenly? Is it the perceived effort needed to fix the tests to all green colour on testbot's win9x machines? Why was this topic not discussed recently at Wineconf? It would be a very bad idea to remove win9x from testbot. We need these old systems to understand what behaviour old apps expect. And I'm very thankful to Greg for his testbot service. Without it, we would know next to nothing about win9x. The fact that a random old app works in native XP (in compatibility mode) teaches us nothing for Wine. Unless we start to run winetest in compatibility mode! I've already mentioned in the past the idea to run testbot sometimes with all broken() disabled, to assess failures on newer systems. broken() may shadow errors in the tests and lull Wine developers into wrong beliefs. Paul Vriens wrote: >The little bits and pieces we have in our code should stay as we >probably need that to cope with old apps that expect a different behavior. Actually, I've even been thinking about implementing the opposite behaviour: Old APIs are mostly used by old apps, while newer apps moved to newer ones (e.g. DirectSound, then mmdev). Therefore it would make a lot of sense to have old APIs (e.g. WINMM/MCI/VfW) mimic the behaviour observable when these apps were developed: win9x! (win3.x?) We don't even know whether MS' compatibility mode does precisely that. Regards, Jörg Höhle

7 10

Phoronix benchmarked opengl games on wine...
by Dan Kegel 23 Dec '10

23 Dec '10

http://www.phoronix.com/scan.php?page=article&item=wine_win7_2010 "With this testing we ran eight games/benchmarks natively under Ubuntu 10.10, the Windows binaries under the stable Wine 1.2.1, the Windows binaries under the Wine 1.3.9 development snapshot, and then finally under Microsoft Windows 7 Professional. The test profiles used had included OpenArena, Urban Terror, Warsow, Nexuiz, Lightsmark, Unigine Sanctuary, Unigine Tropics, and Unigine Heaven. The OpenGL renderer was used with all of them... >From this first round of 2010 Wine vs. Ubuntu vs. Windows 7 testing it is tough to draw any conclusions. About the only conclusion to draw would be that you cannot draw any definitive conclusions about the Wine performance compared to the native performance on either Linux or Windows. ... Stay tuned for our expanded Wine testing and to see how the Linux performance compares with some more popular Windows-only Direct3D-rendered games."

1 0

Re: shell32/tests: Fix a typo
by Marvin 23 Dec '10

23 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7800 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

New winetricks 20101222: new verbs icodecs, msnasn1, opensymbol, wmi, xmllite; removed obsolete verbs audioio, dcom98, eadm, urlmon
by Dan Kegel 22 Dec '10

22 Dec '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Lots of bugfixes. wsh57 now works with vb scripts. The code has undergone some spring cleaning, so watch out for regressions. (We've fixed a few already.) In particular, the audioio, dcom98, eadm, and urlmon verbs are gone, let me know if you really need those! There's a new --optin commandline option that will tells winetricks to phone home after each run with info about which verbs really get used. Please consider using this, it will help future winetricks development. (You only have to give that option once, it sticks. You can turn it off with the --optout option, or by removing ~/.cache/winetricks.) Longer Changelog: Detlef Riekenberg: wmi: new verb Andrew Nguyen: steam: install corefonts first gfw: Avoid extracting the entire Win2k SP4 redist for msasn1.dll Austin English: Always use quiet and overwrite options for unzip. (issue 196) Lots of win64 fixes audioio: removed cmake: support silent install d3dx9_xx: only extract the desired dll (faster) dotnet11: work around wine bug 25120 eadm: remove, it's useless and its sha1sum changes way too often ie6: get rid of ie6 online installer, rename ie6_full to ie6 (which works around the inseng bug), support quiet installs mono28: bump to mono 2.8.1 mono28: remove mono registry keys, they are set by default in Wine since 1.2 msxml3: fix install opensymbol: added font set_psm: should set PixelShaderMode, not RenderTargetLockMode. (Issue 197) unset_winver: wine changed version setting, so make this a synonym for winver xp vcrun2003: use the correct programfiles directory. Fixes win64 install. w_call: if the subshell fails, exit immediately, otherwise w_die() is useless winver: update how setting a windows version works. w_warn: should return 0 in case of no-gui xact: fix for WINEPREFIXes with spaces/special characters Dan Kegel: Many small changes to start obeying new coding convention. Fix a few bugs found when running on windows Fix places where paths weren't quoted (bug 179). Thanks to Roberto Neri. Add --option, --optout options to control experimental opt-in usage tracking. crypt32: it was really broken, but works now. dcom98: it's obsolete, and causes problems, so removed. dotnet30: have to set XP mode now for install to work dotnet35: improved recipe per Louis, good enough to let some apps start icodecs: brought back, thanks to Alan Alberghini for the new URL. msasn1: new verb. urlmon: remove for now wsh57: improve so wscript hello.vbs works xmllite: new verb. (Hangs at end unless you give -q)

2 2

The Windows version of the "octave --version" command exposes an uncommon X network transparency issue for wine
by Alan W. Irwin 22 Dec '10

22 Dec '10

I have been downloading lots of free software packages for Windows that are dependencies of PLplot so that I can add additional components of PLplot for my tests of PLplot under wine. Normally, I do all such testing on an X-terminal, and wine normally works without X transparency issues for everything I have tested up to now on wine. These tests include Windows GUI installers for lots of different free software packages and PLplot device drivers that generate interactive plots for the Windows platform. I have not done any such tests for games. This just-encountered network-transparency trouble occurred for the Windows version of octave, and the reason I am bringing it up here is to find out if this is a known issue or a new bug that I should report on your bug tracker. Here are the details. I am running a 32-bit version of wine-1.3.9 that I have built and installed on Debian testing 64-bit hardware. The GUI installer for octave obtained from "http://prdownloads.sourceforge.net/octave/Octave_Windows%20-%20MinGW/Octave…" worked fine under wine (on the X-terminal). I chose everything to be default other than the install prefix location. I am also using the latest version of Windows bash from MSYS and start running it as follows wineconsole --backend=curses MinGW/msys/1.0/bin/bash.exe Under that bash if I set the PATH to include the bin directory where octave.exe resides and run octave --version directly (i.e., not from an X-terminal) I get a good result which consists of the usual GNU octave version message. If I do the same thing from my X-terminal (where all X applications like the xterm where the wineconsole command is executed are running on a remote machine over the office LAN and a local X server on the X-terminal box transparently handles the X display, keyboard, and mouse), then I get the following errors (subject to rewrapping) bash.exe-3.1$ octave --version X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 1 (X_CreateWindow) Serial number of failed request: 208 Current serial number in output stream: 210 Since a rather large number of wineconsole or wine commands I have been running recently (including the octave installer GUI itself) work without issues for an X-terminal, my working hypothesis is the Windows version of octave (which can know absolutely nothing about X) generates a special version of a normal display request to wine that wine for some reason cannot handle in a network-transparent way when translating that display request to X. Are there known network transparency issues still remaining for some small subset of the display requests translated into X by wine or is this a new X network transparency bug for wine that I should report? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 3

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by jacek＠codeweavers.com 22 Dec '10

22 Dec '10

On 12/22/10 2:17 PM, David Hedberg wrote: > Hi Jacek, > On Wed, Dec 22, 2010 at 13:07, Jacek Caban<jacek(a)codeweavers.com> wrote: >>> + if(security_problem) { >>> + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, >> You shouldn't need the cast here. > I get warnings if I leave the casts out though, and I can't see any obvious problem with the declarations. Any ideas? I've read your patch wrongly, sorry. Please avoid using IUnknown_QueryService. It's an ugly named helper function and it causes confusions like mine. Explicitly QIing for IServiceProvider and calling QueryService on it is the way to go. Cheers, Jacek

1 0

Re: [PATCH 2/2] shell32: Add IInputObject stub to IExplorerBrowser.
by Alexandre Julliard 22 Dec '10

22 Dec '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + WPARAM supported_key_accels[] = { /* Win7 */ > + VK_RETURN, VK_PRIOR, VK_NEXT, VK_END, VK_HOME, VK_LEFT, VK_UP, VK_RIGHT, > + VK_DOWN, VK_F10, 0 }; > + MSG msg_a = { > + hwnd, > + supported_key_accels[1], This doesn't make sense, you should be passing a keyboard message here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by Jacek Caban 22 Dec '10

22 Dec '10

Hi David, On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/http.c | 99 +++++++++++++++++++++++++++++++++++++++++++++-- > dlls/urlmon/tests/url.c | 25 ++++++++++++ > 2 files changed, 120 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c > index cfa2fc6..1ed5e15 100644 > --- a/dlls/urlmon/http.c > +++ b/dlls/urlmon/http.c > @@ -80,6 +80,92 @@ static LPWSTR query_http_info(HttpProtocol *This, DWORD option) > return ret; > } > > +static HRESULT handle_http_error(HttpProtocol *This, DWORD error) > +{ > + IWindowForBindingUI *wfb_ui; > + IHttpSecurity *http_security; > + BOOL security_problem; > + HRESULT hres; > + > + switch(error) { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + security_problem = TRUE; > + break; > + default: > + security_problem = FALSE; > + } > + > + if(security_problem) { > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, You shouldn't need the cast here. > +&IID_IHttpSecurity,&IID_IHttpSecurity, (void **)&http_security); > + if(SUCCEEDED(hres)) { > + hres = IHttpSecurity_OnSecurityProblem(http_security, error); > + IHttpSecurity_Release(http_security); > + > + if(hres == S_OK || hres == E_ABORT) > + return E_ABORT; > + if(hres == RPC_E_RETRY) > + return RPC_E_RETRY; > + if(hres != S_FALSE) > + return INET_E_SECURITY_PROBLEM; > + } > + } > + > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, > +&IID_IWindowForBindingUI,&IID_IWindowForBindingUI, (void **)&wfb_ui); Same here. > + if(SUCCEEDED(hres)) { > + HWND hwnd; > + const IID *iid_reason; > + > + if(security_problem) > + iid_reason =&IID_IHttpSecurity; > + else if(error == ERROR_INTERNET_INCORRECT_PASSWORD) > + iid_reason =&IID_IAuthenticate; > + else > + iid_reason =&IID_IWindowForBindingUI; > + > + hres = IWindowForBindingUI_GetWindow(wfb_ui, iid_reason,&hwnd); > + if(SUCCEEDED(hres)&& hwnd) > + { > + DWORD res; > + > + res = InternetErrorDlg(hwnd, This->base.request, error, > + FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS | FLAGS_ERROR_UI_FLAGS_GENERATE_DATA, > + NULL); > + > + if(res == ERROR_INTERNET_FORCE_RETRY || res == ERROR_SUCCESS) > + hres = RPC_E_RETRY; > + else > + hres = E_FAIL; > + } > + IWindowForBindingUI_Release(wfb_ui); > + } > + > + if(hres == RPC_E_RETRY) > + return hres; > + > + switch(error) > + { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + return INET_E_INVALID_CERTIFICATE; > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + return INET_E_REDIRECT_FAILED; > + default: > + return INET_E_DOWNLOAD_FAILURE; > + } > +} > + > static ULONG send_http_request(HttpProtocol *This) > { > INTERNET_BUFFERSW send_buffer = {sizeof(INTERNET_BUFFERSW)}; > @@ -282,13 +368,18 @@ static HRESULT HttpProtocol_open_request(Protocol *prot, IUri *uri, DWORD reques > if(!res) > WARN("InternetSetOption(INTERNET_OPTION_HTTP_DECODING) failed: %08x\n", GetLastError()); > > - error = send_http_request(This); > + do { > + error = send_http_request(This); > > - if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > - return S_OK; > + if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > + return S_OK; > + > + hres = handle_http_error(This, error); > + > + } while(hres == RPC_E_RETRY); > > WARN("HttpSendRequest failed: %d\n", error); > - return INET_E_DOWNLOAD_FAILURE; > + return hres; > } > > static HRESULT HttpProtocol_end_request(Protocol *protocol) > diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c > index 875294b..c2cf152 100644 > --- a/dlls/urlmon/tests/url.c > +++ b/dlls/urlmon/tests/url.c > @@ -91,10 +91,12 @@ DEFINE_EXPECT(QueryInterface_IInternetBindInfo); > DEFINE_EXPECT(QueryInterface_IAuthenticate); > DEFINE_EXPECT(QueryInterface_IInternetProtocol); > DEFINE_EXPECT(QueryInterface_IWindowForBindingUI); > +DEFINE_EXPECT(QueryInterface_IHttpSecurity); > DEFINE_EXPECT(QueryService_IAuthenticate); > DEFINE_EXPECT(QueryService_IInternetProtocol); > DEFINE_EXPECT(QueryService_IInternetBindInfo); > DEFINE_EXPECT(QueryService_IWindowForBindingUI); > +DEFINE_EXPECT(QueryService_IHttpSecurity); > DEFINE_EXPECT(BeginningTransaction); > DEFINE_EXPECT(OnResponse); > DEFINE_EXPECT(QueryInterface_IHttpNegotiate2); > @@ -627,6 +629,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > IServiceProvider *service_provider; > IHttpNegotiate *http_negotiate; > IHttpNegotiate2 *http_negotiate2; > + IHttpSecurity *http_security; > LPWSTR ua = (LPWSTR)0xdeadbeef, accept_mimes[256]; > LPWSTR additional_headers = (LPWSTR)0xdeadbeef; > BYTE sec_id[100]; > @@ -708,6 +711,18 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > ok(hres == E_FAIL, "GetRootSecurityId failed: %08x, expected E_FAIL\n", hres); > ok(size == no_callback ? 512 : 13, "size=%d\n", size); > > + if(!no_callback) { > + SET_EXPECT(QueryService_IHttpSecurity); > + SET_EXPECT(QueryInterface_IHttpSecurity); > + } > + hres = IServiceProvider_QueryService(service_provider,&IID_IHttpSecurity, > +&IID_IHttpSecurity, (void**)&http_security); > + ok(hres == E_NOINTERFACE, "QueryService failed: 0x%08x\n", hres); > + if(!no_callback) { > + CHECK_CALLED(QueryService_IHttpSecurity); > + CHECK_CALLED(QueryInterface_IHttpSecurity); > + } > + > IServiceProvider_Release(service_provider); > > IInternetProtocolSink_AddRef(pOIProtSink); > @@ -1212,6 +1227,11 @@ static HRESULT WINAPI ServiceProvider_QueryService(IServiceProvider *iface, > return E_NOTIMPL; > } > > + if(IsEqualGUID(&IID_IHttpSecurity, guidService)) { > + CHECK_EXPECT(QueryService_IHttpSecurity); > + return E_NOTIMPL; > + } > + > ok(0, "unexpected service %s\n", debugstr_guid(guidService)); > return E_NOINTERFACE; > } > @@ -1292,6 +1312,11 @@ static HRESULT WINAPI statusclb_QueryInterface(IBindStatusCallbackEx *iface, REF > CHECK_EXPECT2(QueryInterface_IWindowForBindingUI); > return E_NOINTERFACE; > } > + else if(IsEqualGUID(&IID_IHttpSecurity, riid)) > + { > + CHECK_EXPECT2(QueryInterface_IHttpSecurity); > + return E_NOINTERFACE; > + } > else > { > ok(0, "unexpected interface %s\n", debugstr_guid(riid)); Please add some real tests. At least a connection to an invalid certificate should be easy to achieve. Cheers, Jacek

2 1

Shell.Application
by Alexander Morozov 22 Dec '10

22 Dec '10

Some Windows programs use Shell.Application object (sample: http://bugs.winehq.org/show_bug.cgi?id=8987) This object has IShellDispatch, IShellDispatch2, IShellDispatch3, ... interfaces (http://www.com.it-berater.org/COM/windows_shell/interfaces/IShellDispatch.h…) If IShellDispatch is sufficient for some application and I am going to add its declaration should I add IShellDispatch2, 3, ..., 5 in addition?

1 0