March 2010 - Wine-devel - list.winehq.org

Re: [PATCH 01/11] ws2_32: use ntstatus in overlapped functions (try 3)
by Alexandre Julliard 22 Mar '10

22 Mar '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > Make get_sock_events return error codes in unix format. Also some > style fixes. Sorry for the fuss over this :) The server should not be returning errno values directly. It should return NT status codes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/8] [Include]: added a wine/dwarf.h to share dwarf2 debug information data where needed
by Alexandre Julliard 22 Mar '10

22 Mar '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > A+ > --- > > dlls/dbghelp/dwarf.c | 2 > dlls/dbghelp/dwarf.h | 420 ---------------------------------------- > dlls/ntdll/signal_x86_64.c | 207 -------------------- > include/wine/dwarf.h | 465 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 467 insertions(+), 627 deletions(-) > delete mode 100644 dlls/dbghelp/dwarf.h > create mode 100644 include/wine/dwarf.h I don't think we need a Wine global header for this. It's OK to keep it in dbghelp and copy only the few necessary defines in ntdll. That's even more true for the unwind info. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: makefiles: Use the standard C_SRCS variable as the list of test files
by Ilya Basin 22 Mar '10

22 Mar '10

Looks like after this commit: http://source.winehq.org/git/wine.git/?a=commit;h=6164ce2d820546ae5b26eb504… the command ./tools/winapi/msvcmaker --no-wine silently fails: only 'winetest.dsp' created

1 0

Re: shell32: Add IPersistFile::GetCurFile implementation for IShellLink
by Paul Vriens 21 Mar '10

21 Mar '10

On 03/18/2010 10:55 PM, Nikolay Sivov wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=19627 from 1.2 list. > Hi Nikolay, This introduces some test failures on Win9x (not WinMe) and NT4 in the shlexec tests. Could you agree with the attached patch? -- Cheers, Paul.

2 1

Re: winegcc: Link with msvcrt on windows because of __wargv
by James McKenzie 21 Mar '10

21 Mar '10

Alexandre Goujon wrote: > --- > tools/winegcc/winegcc.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index c2e7876..a929214 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -555,6 +555,10 @@ static const char *mingw_unicode_hack( struct options *opts ) > { > char *main_stub = get_temp_file( opts->output_name, ".c" ); > > + /* we need to link with msvcrt because of __wargv */ > + if (!opts->use_msvcrt) > + opts->use_msvcrt = 1; > + > create_file( main_stub, 0644, > "#include <stdlib.h>\n" > "extern int wmain(int,wchar_t**);\n" > Please use [try 2] for any second send. Keeps things in order and lets others know that you have responded to errors. Also, put comments in the same message as the patch they apply to at the top of the message. Thank you. James McKenzie

2 2

Wanted: Summer of Code Mentors
by Maarten Lankhorst 20 Mar '10

20 Mar '10

Hi all, Any contributing wine members wishing to mentor for summer of code, or help out with ranking proposals, please sign up as mentor for wine at http://socghop.appspot.com/gsoc Of course if you want to apply as student, you can't be a mentor. More feedback on the proposals is appreciated as well. :) Cheers, Maarten

2 1

Re: FIXME: shader trailing '\n's.
by Henri Verbeet 20 Mar '10

20 Mar '10

On 20 March 2010 15:27, Francois Gouget <fgouget(a)free.fr> wrote: > On Sat, 20 Mar 2010, Francois Gouget wrote: > >> --- >> dlls/wined3d/shader.c | 132 ++++++++++++++++++++++++------------------------ >> 1 files changed, 66 insertions(+), 66 deletions(-) > > Argh! > > Ignore this one. I need to check it out and did not mean to send it > (hence the FIXME). > I didn't check all of them, but the majority of those are intentional. There are probably nicer ways to trace the D3D shader assembly though.

1 0

Re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays
by Alexandre Julliard 20 Mar '10

20 Mar '10

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Both FADF_HAVEVARTYPE and FADF_RECORD both store information at > negative 4 in the safearray, and ODBC(native MDAC) can attempt to copy > an array with both of these flags set. A test case would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]
by Piotr Caban 20 Mar '10

20 Mar '10

Hi, You forgot to attach changes to configure.ac. Regards, Piotr

2 1

winetricks bug?
by Igor Zakharoff 20 Mar '10

20 Mar '10

Hi. I am using WINE 1.1.40 on Arch Linux. When I run winetricks (version 20100317) and try to install anything from the list I get the error ------------------------------------------------------ winepath -u C:\Program Files "" returned empty string ------------------------------------------------------ $ ls -l /home/igor/.wine/drive_c/ итого 16 drwxr-xr-x 4 igor users 4096 Мар 19 23:06 Program Files drwxr-xr-x 4 igor users 4096 Мар 19 23:06 users drwxr-xr-x 10 igor users 4096 Мар 19 23:06 windows drwxr-xr-x 2 igor users 4096 Мар 19 23:06 winetrickstmp I've tried removing ~/.wine directory but it doesn't help.

2 1