March 2010 - Wine-devel - list.winehq.org

Re: cmd: Add skeleton ping command (try 2)
by Alexandre Julliard 18 Mar '10

18 Mar '10

Trey Hunner <treyhunner(a)gmail.com> writes: > +int main(int argc, char** argv) > +{ > + int n = 0; > + int optc; > + > + while ((optc = getopt( argc, argv, "n:w:" )) != -1) > + { > + switch(optc) > + { > + case 'n': > + n = atoi( optarg ); > + break; > + case '?': > + usage(); > + exit(1); > + } > + } You should at least print a FIXME for other options that it's supposed to support, instead of silently succeeding and doing nothing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile
by Paul Vriens 18 Mar '10

18 Mar '10

On 03/17/2010 04:21 PM, Ilya Basin wrote: > @@ -1013,7 +1011,7 @@ static void test_filename(void) > "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); > } > - else todo_wine > + else > { > ok(rc==test->rc, "%s failed: rc=%d err=%d\n", shell_call, > rc, GetLastError()); Hi Ilya, If this is no longer a todo_wine you should change the filename_tests struct: /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x1, 33}, to /* Test file masked due to space */ {NULL, "%s\\masked file.shlexec", 0x0, 33}, You can even consider removing the "if ((test->todo & 0x1)==0)" as now there are no more of those tests. On the one hand it's nice to have these todo constructs, removing them however is a greater incentive to get the implementation right ;) -- Cheers, Paul.

3 2

Re: 1/3 wined3d: disable hw accelerated 8-bit blits in BltOverride
by Henri Verbeet 18 Mar '10

18 Mar '10

On 17 March 2010 14:48, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This first patch disables hardware accelerated 8-bit blitting. This > code will completely use the shader backend later on and won't require > hacks like 'paletteOverride'. > I'm not sure breaking things is the right approach?

3 3

Measuring game FPS in wine/windows?
by Austin English 18 Mar '10

18 Mar '10

Howdy, I've been testing some games lately on Windows/Wine, and wanted to see the difference in framerates. On windows, I've been using Fraps, which works decently well, but not under wine (and it doesn't work for Assassin's creed). I found D3DGears online, which supposedly works for Assassin's creed on Windows (haven't checked), but doesn't work under wine. Does anyone know of a standalone application that works under wine? Thanks! -Austin

3 2

Re: [1/3] winex11: Add implementation of Triangle Inequality Nearest Neighbour algorithm.
by Roderick Colenbrander 18 Mar '10

18 Mar '10

Hi Vitaly, In case of Age of Empires the performance is certainly affected by the DIB code. As you have seen, right now we perform all rendering (except when XRender is around but that's typically for >8-bit) at the depth of the Xserver and perform conversions back and forth. Alexandre mentioned some time that we should avoid doing these conversions altogether (they caused issues at <8-bit but I don't remember him saying what the issues were) and that instead we should provide X11 with 8-bit data if we are dealing with 8-bit data. I guess that's how he wants this to continue but I have no idea how easy it is to change all this. Roderick On Thu, Mar 18, 2010 at 9:57 AM, Vitaly Budovski <> wrote: > This will allow faster palette lookups for 8 bit palettes. > > This may come up in a reply, so I'll address it now. Float must be used > since an int doesn't provide enough range for the numbers we are dealing > with. > > > >

1 0

Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens 18 Mar '10

18 Mar '10

On 03/17/2010 02:22 PM, Jacek Caban wrote: > --- a/programs/cmd/tests/test_builtins.cmd.exp > +++ b/programs/cmd/tests/test_builtins.cmd.exp > @@ -16,6 +16,7 @@ bar > ~dp0 should be directory containing batch file > @pwd@\ > @pwd@\ > +(a)pwd@@or_broken(a)ECHO is off. Won't this fail on non English locales? In this case it will only fail on non English NT4 boxes, but still. -- Cheers, Paul.

2 1

Winsock event patches - review and test please
by Mike Kaplinskiy 18 Mar '10

18 Mar '10

Hello all, I've been working on fixing some of the winsock event handling issues in wine, so I'm looking for someone to give these patches a review and test them on some apps that use that kind of stuff, i.e. apps that call WSAEventSelect or WSAAsyncSelect. I'm not quite certain on the portability of all the code, so if anyone on a non-linux-2.6 can give the tests a run that would be great. The tests pass on windows ignoring failure after line 3259 (the tests below are wine-specific). Thanks, Mike.

1 0

Re: [1/2] urlmon: Add stub IUriBuilder interface (try2)
by Nikolay Sivov 18 Mar '10

18 Mar '10

On 3/18/2010 04:16, Nikolay Sivov wrote: > I know comdlg32 doesn't seem to be very close to urlmon, but stub I added shows a problems in included headers order. > SetPort method from IUriBuilder collides with SetPort define from winspool.h and a build error comes up saying I'm using > unprefixed call (without A or W). > Hm, next conflict is in programs/clock. Chain is windows.h -> ole2.h -> objbase.h -> urlmon.h In windows.h there's include winspool.h before ole2.h, and this causes conflict. Not sure how to fix it now, any comments are welcome. > Second patch should apply cleanly. >

1 0

Re: Small spelling fixes.
by Vincent Povirk 17 Mar '10

17 Mar '10

Thanks for sending a patch for this. It seems it was not committed, probably because your mailer added line-breaks, making it difficult to apply. Could you resend as an attachment, or without the line breaks if you can configure your mailer to do that? Or, if you prefer, I can send this with fixed formatting on your behalf. 2010/3/12 Julian Rüger <jr98(a)gmx.net>: > --- > dlls/windowscodecs/pngformat.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c > b/dlls/windowscodecs/pngformat.c > index 22b37b0..5af680e 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -1320,13 +1320,13 @@ HRESULT PngEncoder_CreateInstance(IUnknown > *pUnkOuter, REFIID iid, void** ppv) > > HRESULT PngDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to load PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to load PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > HRESULT PngEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, > void** ppv) > { > - ERR("Trying to save PNG picture, but PNG supported not compiled > in.\n"); > + ERR("Trying to save PNG picture, but PNG support is not compiled > in.\n"); > return E_FAIL; > } > > -- > 1.5.6.3 > > > > > >

1 0

Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in
by jgilik＠ucla.edu 17 Mar '10

17 Mar '10

Alright--I'll update and resubmit when I get home from work. The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead. Should I be worried about that submission guideline? ------Original Message------ From: Dan Kegel Sender: daniel.r.kegel(a)gmail.com To: wine-devel(a)winehq.org Cc: John Gilik Subject: Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in Sent: Mar 16, 2010 5:51 PM Each patch in a series must compile and pass all tests, so if you need shlwapi for patch 1, then you have to include it in patch 1 (and then you just have one patch, not a series).

2 1