March 2010 - Wine-devel - list.winehq.org

Re: winemp3.acm: support mp3 decoding on Mac OS/X systems
by Alexandre Julliard 17 Mar '10

17 Mar '10

Aric Stewart <aric(a)codeweavers.com> writes: > uses CoreAudio's AudioConverter, AudioFile and AudioFileStream. > uses prefered systems for either (Snow) Leopard or Tiger deciding at > runtime. I don't think we have to care about Tiger compatibility here, especially since it involves so much extra code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add VRGB/VBGR render modes for subpixel aliasing as new FontOrientation to enable capabilities that are already in xrender.c:UploadGlyph and subsequently freetype.c:WineEngGetGlyphOutline
by Alexandre Julliard 17 Mar '10

17 Mar '10

Clemens Fruhwirth <clemens(a)endorphin.org> writes: > @@ -3090,8 +3090,10 @@ typedef struct tagCBTACTIVATESTRUCT > #define FE_FONTSMOOTHINGCLEARTYPE 0x0002 > #define FE_FONTSMOOTHINGDOCKING 0x8000 > > -#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > -#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONBGR 0x0000 > +#define FE_FONTSMOOTHINGORIENTATIONRGB 0x0001 > +#define FE_FONTSMOOTHINGORIENTATIONVBGR 0x0002 > +#define FE_FONTSMOOTHINGORIENTATIONVRGB 0x0003 These don't seem to exist in the PSDK. Where do they come from? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: 2/3 wined3d: add a helper function for drawing a textured quad
by Henri Verbeet 17 Mar '10

17 Mar '10

On 17 March 2010 14:53, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch introduces a helper function for drawing a textured quad. A > future patch will also make use of it for the quad drawing part of > 'offscreen surface -> render target' in BltOverride (actually that > part will become two functions later on: one for color keying to be > called from Blt/BltFast and one without any color keying) > The idea of making this a separate function is probably ok, but that function has more GL state dependencies than just locking and context activation, and also invalidates some GL states. Ultimately drawing a quad is something that should be internal to a blitter implementation. A shader based blitter for example wouldn't have to invalidate lots of fixed function state because it simply replaces those parts of the GL pipeline. A FBO blit based implementation doesn't have to draw a quad at all. Perhaps this is an acceptable step in that direction, but it's probably a good idea to think about what the blitter interface should look like first. Also, const correctness.

1 0

Re: cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.
by Paul Vriens 17 Mar '10

17 Mar '10

On 03/17/2010 02:10 PM, Jacek Caban wrote: > --- > programs/cmd/tests/batch.c | 39 ++++++++++++++++++++++++----- > programs/cmd/tests/test_builtins.cmd.exp | 2 +- > 2 files changed, 33 insertions(+), 8 deletions(-) > > Hi Jacek, Wasn't this test removed (for NT4 btw)? -- Cheers, Paul.

2 1

Re: [PATCH] cmd: removed %CD% test.
by Austin English 17 Mar '10

17 Mar '10

On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud <yann(a)droneaud.fr> wrote: > %CD% seems not supported on Windows NT 4. > > The patch which introduce this test was based on MSDN documentation > and only tested on Windows XP Instead of removing it, perhaps the cmd test framework needs to understand the broken() macro... -- -Austin

3 2

Re: [PATCH 09/13] shdocvw: Added more navigation tests.
by Paul Vriens 17 Mar '10

17 Mar '10

On 03/13/2010 04:44 PM, Jacek Caban wrote: > --- > dlls/shdocvw/tests/webbrowser.c | 293 > +++++++++++++++++++++++++++++---------- > 1 files changed, 218 insertions(+), 75 deletions(-) > Hi Jacek, This one has introduced several test failures on a variety of platforms (or IE versions): http://test.winehq.org/data/tests/shdocvw:webbrowser.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH] d3dx9_36: Add stub for D3DXCreateTextureFromFileInMemoryE
by Henri Verbeet 17 Mar '10

17 Mar '10

On 17 March 2010 12:21, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + FIXME("(%p, %p, %d, %d, %d, %d, %x, %x, %x, %d, %d, %x, %p, %p, %p): stub\n", device, srcdata, srcdatasize, width, > + height, miplevels, usage, format, pool, filter, mipfilter, colorkey, srcinfo, palette, texture); Those integers are all unsigned.

1 0

Re: [PATCH 2/3] d3dx9_36: Add missing GetSamplerIndex method to ID3DXConstantTable
by Henri Verbeet 17 Mar '10

17 Mar '10

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->lpVtbl->GetConstantDesc(p,a) > +#define ID3DXConstantTable_GetSamplerIndex(p,a) (p)->GetConstantDesc(p,a) Looks wrong.

1 0

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXConstantTableImpl_GetDesc + tests (try 2)
by Henri Verbeet 17 Mar '10

17 Mar '10

On 17 March 2010 12:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +error: > + > + if (object) > + HeapFree(GetProcessHeap(), 0, object->ctab); > + HeapFree(GetProcessHeap(), 0, object); "object" should never be NULL, all jumps to "error" are after the NULL check.

1 0

Re: usbd.sys: add usbd.sys (try 4)
by Alexandre Julliard 17 Mar '10

17 Mar '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * usbd.sys: add usbd.sys > > Try 4 is the shortest possible patch. > > Copyright assigned to both me and Alexandre Morozov, since his patch > is the basis of this one. The proper way to assign credit is not by adding copyright lines in the source, but by making sure every commit is credited to the right author. If a patch was not written by you it needs a From: line specifying the real author, and preferably it needs to be submitted by the original author himself. -- Alexandre Julliard julliard(a)winehq.org

2 1