March 2010 - Wine-devel - list.winehq.org

Re: [TRY 4] [PATCH] user32: horizontal and vertical scrolling of selection in edit control
by Dmitry Timoshkov 29 Mar '10

29 Mar '10

Henry Kroll III <henry(a)comptune.com> wrote: > + if (es->region_posx < 0)EDIT_EM_LineScroll(es,-10,0); > + else if (es->region_posx > 0)EDIT_EM_LineScroll(es,10,0); > + if (es->region_posy < 0)EDIT_EM_LineScroll(es,0,-1); > + else if (es->region_posy > 0)EDIT_EM_LineScroll(es,0,1); Where do -/+10,-/+1 come from? A test case wouldn't hurt. Also please add some spacing and try to follow the indentation style of existing code. -- Dmitry.

1 0

Re: [PATCH 5/8] msvcr90: Added _get/set_invalid_parameter_handler implementation (try4)
by Paul Vriens 29 Mar '10

29 Mar '10

On 03/24/2010 10:39 PM, Piotr Caban wrote: > + p_invalid_parameter = (void *)GetProcAddress( hMsvcrt,"_invalid_parameter"); > + if(p_invalid_parameter) > + *p_invalid_parameter = test_invalid_parameter_handler; Hi Piotr, That last assignment makes the tests crash on Vista+. Could you have a look? -- Cheers, Paul.

1 0

Re: on most hated "OS" in the history of computing
by James Mckenzie 29 Mar '10

29 Mar '10

Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > >Hello, > >This article is about Windows 3.x history and "architecture": >http://www.openwatcom.org/index.php/Exploring_Windows_3.x > >It was nice sunday reading :) for me. > Interesting that ANYONE would consider any version of Windows 3.x as an operating system. Now, computing environment is a different answer. Programming for it was an adventure. You should see what happens when 'resources' empty out. As to the openwatcom question, I used to have programming books for Windows 3.1 that came with the full MS build environment... Those were the days....Setting up NICs on Windows 3.1.1 for an enterprise level test... James McKenzie

2 1

Re: [PATCH 3/3] gdiplus: Implement GdipSetPathGradientSurroundColorsWithCount and GdipGetPathGradientSurroundColorCount [Try 2]
by Vincent Povirk 29 Mar '10

29 Mar '10

You should also update GdipCloneBrush so that it makes a copy of this new array. On Sun, Mar 28, 2010 at 11:22 PM, Justin Chevrier <jchevrier(a)gmail.com> wrote: > Now taking a copy of the color array. Thanks Nikolay > --- > dlls/gdiplus/brush.c | 27 +++++++++++++++++++-------- > dlls/gdiplus/gdiplus_private.h | 2 ++ > dlls/gdiplus/tests/brush.c | 6 +++--- > 3 files changed, 24 insertions(+), 11 deletions(-) > > diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c > index 8994b87..7f5c8f7 100644 > --- a/dlls/gdiplus/brush.c > +++ b/dlls/gdiplus/brush.c > @@ -578,9 +578,10 @@ GpStatus WINGDIPAPI GdipCreatePathGradient(GDIPCONST GpPointF* points, > GdipFree(*grad); > return OutOfMemory; > } > - (*grad)->blendfac[0] = 1.0; > - (*grad)->blendpos = NULL; > - (*grad)->blendcount = 1; > + (*grad)->blendfac[0] = 1.0; > + (*grad)->blendpos = NULL; > + (*grad)->blendcount = 1; > + (*grad)->surroundcolors = NULL; > > (*grad)->pathdata.Count = count; > (*grad)->pathdata.Points = GdipAlloc(count * sizeof(PointF)); > @@ -946,6 +947,7 @@ GpStatus WINGDIPAPI GdipDeleteBrush(GpBrush *brush) > GdipFree(((GpPathGradient*) brush)->pathdata.Types); > GdipFree(((GpPathGradient*) brush)->blendfac); > GdipFree(((GpPathGradient*) brush)->blendpos); > + GdipFree(((GpPathGradient*) brush)->surroundcolors); > break; > case BrushTypeSolidColor: > if (((GpSolidFill*)brush)->bmp) > @@ -1174,7 +1176,9 @@ GpStatus WINGDIPAPI GdipGetPathGradientSurroundColorCount(GpPathGradient *brush, > if (!brush || !count) > return InvalidParameter; > > - return NotImplemented; > + *count = brush->surroundcolorcount; > + > + return Ok; > } > > GpStatus WINGDIPAPI GdipGetPathGradientWrapMode(GpPathGradient *brush, > @@ -1544,7 +1548,7 @@ GpStatus WINGDIPAPI GdipSetPathGradientSigmaBlend(GpPathGradient *grad, > GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > *grad, GDIPCONST ARGB *argb, INT *count) > { > - static int calls; > + ARGB *new_colors; > > TRACE("(%p,%p,%p)\n", grad, argb, count); > > @@ -1552,10 +1556,17 @@ GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > (*count > grad->pathdata.Count)) > return InvalidParameter; > > - if(!(calls++)) > - FIXME("not implemented\n"); > + new_colors = GdipAlloc(*count * sizeof(ARGB)); > + if (!new_colors) return OutOfMemory; > > - return NotImplemented; > + memcpy(new_colors, argb, *count * sizeof(ARGB)); > + > + GdipFree(grad->surroundcolors); > + > + grad->surroundcolorcount = *count; > + grad->surroundcolors = new_colors; > + > + return Ok; > } > > GpStatus WINGDIPAPI GdipSetPathGradientWrapMode(GpPathGradient *grad, > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index ca1cba6..eddde11 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -151,6 +151,8 @@ struct GpPathGradient{ > GpBrush brush; > PathData pathdata; > ARGB centercolor; > + INT surroundcolorcount; > + ARGB* surroundcolors; > GpWrapMode wrap; > BOOL gamma; > GpPointF center; > diff --git a/dlls/gdiplus/tests/brush.c b/dlls/gdiplus/tests/brush.c > index 0effcf4..820cb4e 100644 > --- a/dlls/gdiplus/tests/brush.c > +++ b/dlls/gdiplus/tests/brush.c > @@ -683,7 +683,7 @@ static void test_gradientsurroundcolorcount(void) > } > > status = GdipSetPathGradientSurroundColorsWithCount(grad, color, &count); > - todo_wine expect(Ok, status); > + expect(Ok, status); > expect(2, count); > > status = GdipGetPathGradientSurroundColorCount(NULL, &count); > @@ -694,8 +694,8 @@ static void test_gradientsurroundcolorcount(void) > > count = 0; > status = GdipGetPathGradientSurroundColorCount(grad, &count); > - todo_wine expect(Ok, status); > - todo_wine expect(2, count); > + expect(Ok, status); > + expect(2, count); > > GdipFree(color); > GdipDeleteBrush((GpBrush*)grad); > -- > 1.6.5.rc1 > > > >

1 0

Wine and OpenSearch
by GOUJON Alexandre 28 Mar '10

28 Mar '10

Hi, When your app doesn't work on wine, you need to open a wine source file and try to understand what does it do and what goes wrong. Even if they're named explicitly, you may have to look at its code. And so you're asking where can this function be defined ? You can use the command line with find but I prefer using "grep" feature available at http://source.winehq.org/git/wine.git/?a=shortlog because you can then open in your web browser the file exactly where you want. And you may read something like "solved by commit xxx" on bugzilla without a link. In this case, I also open the same URL as above and click on any commitdiff link. I cut the end of the new URL and paste what I read previously. So, I wondered : "Hey ! Why don't you use your search plugins to do that !" (I'm on Firefox but all web browsers have this feature too) Here is why I wrote these two xml. Two lines have to be included on the server side. And the good news is it's even compatible with IE. Should I send these at wine-patches ? Any comment ?

2 2

Wine FIXME Report February 2010
by Michael Stefaniuc 27 Mar '10

27 Mar '10

Update ====== The February report has following changes to the previous report: - More understandable table titles and descriptions (thanks Francois!). - All tables have the same column layout (thanks Francois!). - Introduced new "Mean" column for the mean lines per logs ratio. Wine FIXME Report February 2010 =============================== The data for this report comprise the emails from February 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 6058 (emails: 5505, bugzilla attachments: 553) Files (logs) with FIXME/ERR/WARN: 496 Type | Total | Unique ------+---------+------- fixme | 108062 | 27062 warn | 53510 | 2347 err | 4516 | 1230 Most Frequent Messages By Logs ------------------------------ Messages that are present in most Wine output logs collected. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 68 | 222 | 3.26 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 56 | 62 | 1.11 | system:SetProcessDPIAware stub! 49 | 71 | 1.45 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 36 | 58 | 1.61 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer 32 | 163 | 5.09 | d3d9:Direct3DShaderValidatorCreate9 stub 29 | 78 | 2.69 | urlmon:URLMoniker_BindToObject use running object table 27 | 62 | 2.30 | shdocvw:BindStatusCallback_OnProgress status code 11 25 | 68 | 2.72 | crypt:CRYPT_CriticalExtensionsSupported unsupported critical extension "2.5.29.32" 24 | 96 | 4.00 | advapi:DeregisterEventSource (0xcafe4242) stub 23 | 48 | 2.09 | shdocvw:PropertyNotifySink_OnChanged unimplemented dispid 1005 ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 20 | 29 | 1.45 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 19 | 26 | 1.37 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 18 | 61 | 3.39 | ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded 14 | 32 | 2.29 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 14 | 59 | 4.21 | ole:CoUninitialize Mismatched CoUninitialize 13 | 32 | 2.46 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 13 | 30 | 2.31 | rpc:I_RpcGetBuffer no binding 11 | 12 | 1.09 | ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. Most Frequent Messages By Mean Lines Per Logs --------------------------------------------- This are the messages which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 5 | 987 | 197.40 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filters not supported in software blit 12 | 269 | 22.42 | d3d:debug_d3dformat Unrecognized 909200449 (as fourcc: AL16) WINED3DFORMAT! 12 | 269 | 22.42 | d3d:debug_d3dformat Unrecognized 909201952 (as fourcc: R16) WINED3DFORMAT! 12 | 269 | 22.42 | d3d:getFormatDescEntry Can't find format unrecognized(909200449) in the format lookup table 12 | 269 | 22.42 | d3d:getFormatDescEntry Can't find format unrecognized(909201952) in the format lookup table 7 | 137 | 19.57 | msi:ACTION_CustomAction Rollback only action... rollbacks not supported yet 5 | 97 | 19.40 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -701 5 | 94 | 18.80 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -703 5 | 94 | 18.80 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -704 6 | 92 | 15.33 | advapi:LsaClose (0xcafe) stub ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 5 | 335 | 67.00 | toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 7 | 65 | 9.29 | ole:CoCreateInstance apartment not initialised 8 | 62 | 7.75 | richedit:ReadStyleSheet skipping optional destination 14 | 59 | 4.21 | ole:CoUninitialize Mismatched CoUninitialize 18 | 61 | 3.39 | ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded 13 | 32 | 2.46 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 11 | 25 | 2.27 | ole:CoGetContextToken apartment not initialised 14 | 32 | 2.29 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded Functions With Most Messages By Mean Lines Per Logs --------------------------------------------------- This are the functions which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 9 | 7269 | 807.67 | d3d_draw:drawStridedFast 40 | 7033 | 175.82 | mcimidi:MIDI_mciPlay 6 | 988 | 164.67 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt 5 | 637 | 127.40 | d3d_surface:surface_convert_format 33 | 1752 | 53.09 | ole:OleQueryLinkFromData 6 | 208 | 34.67 | mshtml:HTMLBodyElement_put_scroll 32 | 1107 | 34.59 | winsock:WSAIoctl 289 | 8490 | 29.38 | dinput:_dump_diactionformatA 13 | 385 | 29.62 | xrender:X11DRV_AlphaBlend 5 | 139 | 27.80 | d3d_surface:surface_upload_data ERR: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 7 | 558 | 79.71 | msxml:xmlnode_get_baseName 5 | 335 | 67.00 | toolbar:TOOLBAR_GetImageListForDrawing 9 | 555 | 61.67 | d3d:state_colorwrite 7 | 81 | 11.57 | d3d:getColorBits 7 | 65 | 9.29 | ole:CoCreateInstance 8 | 62 | 7.75 | richedit:ReadStyleSheet 6 | 33 | 5.50 | ole:marshal_object 33 | 149 | 4.52 | ole:CoInitializeEx 14 | 59 | 4.21 | ole:CoUninitialize 26 | 113 | 4.35 | ole:create_server Messages With The Highest Repetition Count ------------------------------------------ The messages with the highest repetition count in a single log file. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 6628 | 6628.0 | d3d_draw:drawStridedFast >>>>>>>>>>>>>>>>> GL_OUT_OF_MEMORY (0x505) from glDrawElements @ drawprim.c / 47 1 | 5906 | 5906.0 | d3d_texture:apply_wrap Unrecognized or unsupported WINED3DTEXTUREADDRESS 0. 3 | 4044 | 1348.0 | d3d:IWineD3DSwapChainImpl_Present Render-to-fbo with WINED3DSWAPEFFECT_FLIP 1 | 2977 | 2977.0 | d3d:debug_d3dusagequery Unrecognized usage query flag(s) 0x1 1 | 2128 | 2128.0 | d3d:context_set_draw_buffer >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glDrawBuffer() @ context.c / 2130 3 | 1740 | 580.0 | d3d:state_clipping Clipping disabled, but ARB_depth_clamp isn't supported. 1 | 1334 | 1334.0 | d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgram ObjectARB @ glsl_shader.c / 4562 1 | 1075 | 1075.0 | d3d7:IDirect3DDeviceImpl_7_GetClipStatus (0x16fc330)->(0x4fbe60): Stub! 1 | 1075 | 1075.0 | d3d7:IDirect3DDeviceImpl_7_SetClipStatus (0x16fc330)->(0x4fbe60): Stub! 1 | 1048 | 1048.0 | winsock:WSAIoctl SIO_GET_EXTENSION_FUNCTION_POINTER {25a207b9-ddf3-4660-8ee9-76e58c74063e}: stub ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 480 | 480.0 | dsound:DSOUND_MixOne Fatal error. Under/Overflow? primary_done=82908, mixpos=40832/176400 (40832/176400), primary_mixpos=40832, writepos=46124, mixlen=128 4 | 297 | 74.2 | d3d:state_colorwrite (WINED3DRS_COLORWRITEENABLE1/2/3,0,0,0) not yet implemented. Missing of cap D3DPMISCCAPS_INDEPENDENTWRITEMASKS wasn't honored? 3 | 275 | 91.7 | msxml:xmlnode_get_baseName Unhandled type 8 5 | 145 | 29.0 | toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 3 | 111 | 37.0 | xrender:get_xrender_format_from_color_shifts No XRender format found! 1 | 56 | 56.0 | ole:CoInitializeEx Attempt to change threading model of this apartment from 1 | 51 | 51.0 | ole:CoGetClassObject class {88d969c0-f192-11d4-a65f-0040963251e5} not registered 1 | 51 | 51.0 | ole:CoGetClassObject no class object {88d969c0-f192-11d4-a65f-0040963251e5} could be created for context 0x5 2 | 51 | 25.5 | ole:create_server class {88d969c0-f192-11d4-a65f-0040963251e5} not registered 1 | 44 | 44.0 | threadpool:iocp_poller NtRemoveIoCompletion failed: 0xc0000008 Further Info: ============= The sqlite3 database and the perl script to output the above report can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/201002/ bye michael

1 0

[patch] DNS_SD bridge, v2
by C.W. Betts 27 Mar '10

27 Mar '10

The following is an updated patch that actually builds and links. The patch does patch configure and config.h.in, both of which were generated with an older version of autoconf and autoheader.

3 4

Re: [PATCH 3/3] gdiplus: Implement GdipSetPathGradientSurroundColorsWithCount and GdipGetPathGradientSurroundColorCount
by Nikolay Sivov 27 Mar '10

27 Mar '10

On 3/28/2010 00:55, Justin Chevrier wrote: > GpStatus WINGDIPAPI GdipGetPathGradientWrapMode(GpPathGradient *brush, > @@ -1544,18 +1546,16 @@ GpStatus WINGDIPAPI GdipSetPathGradientSigmaBlend(GpPathGradient *grad, > GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > *grad, GDIPCONST ARGB *argb, INT *count) > { > - static int calls; > - > TRACE("(%p,%p,%p)\n", grad, argb, count); > > if(!grad || !argb || !count || (*count<= 0) || > (*count> grad->pathdata.Count)) > return InvalidParameter; > > - if(!(calls++)) > - FIXME("not implemented\n"); > + grad->surroundcolorcount = *count; > + grad->surroundcolors = argb; > > - return NotImplemented; > + return Ok; > } > You should make a copy of colors array here. Wrapper method will free array after a call.

1 0

Google Summer of Code ideas
by Charles Davis 27 Mar '10

27 Mar '10

Hi, I intend to participate in the Google Summer of Code this year, and I have several ideas for Wine that I'd like to bounce off you guys to see what you think. Note that all my proposals are Mac OS-based (I run Mac OS X), so many of you will never see the results of what I'm working on. Here they are: 1. Quartz Driver. This is something a lot of Wine-on-Mac users (myself included) have been wanting for while now. Of course, the entire driver itself is a big project, so I would limit the scope to implementing a small piece of it--say, windowing (which shouldn't be too hard thanks to my new "Deobjectivizer" tool)--and then finishing what I started after SoC ends. 2. QuickTime backend for DirectShow. This is is similar to the GStreamer backend, but it won't require people to install GStreamer on Mac just to get this support. To get 64-bit support, we have to use the Cocoa version of QuickTime, but again, thanks to Deobjectivizer, we can avoid writing it in Objective-C. 3. Implementing SCSI support on Mac OS X. I had patches to do this, but I deleted them because I thought they were inadequate. I want to do this to get copy protection working for some games on Mac OS X. Comments welcome. Chip

4 4

wisotool: a script to automate multi-cd installs
by Dan Kegel 27 Mar '10

27 Mar '10

I was looking at the bookshelf full of old games I've collected over the years, and was annoyed that there wasn't any sort of unattended regression test for their installers... 'course, that's hard, since you'd have to somehow insert the cd-roms automatically. But you can kind of fake it by mounting .iso files, at least for some games, so I tried doing it for Diablo II. And it seems to work! I wrapped it up in an extensible script, with a menu and some functions stolen from winetricks. It's at http://code.google.com/p/winezeug/source/browse/trunk/wisotool (though you have to check out that directory from svn to run it, as it currently depends on two other files there). The idea is you run the script like this to load a cd-rom into its cache of .iso files: sh wisotool load If the cd-rom has a key associated with it, specify it like this: sh wisotool load=XXX-YYY-ZZZ-WWW The .iso files are cached in ~/.wisotoolcache in filenames named after their sha1sums (so best run on a fast machine :-) Then (assuming somebody has added a verb for the app to the script), you can then run the script to install from the .iso files. For instance, sh wisotool diablo2 or sh wisotool morrowind It only supports those two games at the moment, it doesn't run on windows yet (though it should eventually), and the diablo2 verb starts the game (I couldn't figure out how to stop it). It's kind of like playonlinux in that it has separate scripts (well, functions) for each game it supports, but utterly unlike playonlinux because it doesn't try to patch or futz with wine in any way (beyond running winetricks if needed), and the installs are totally unattended (unlike playonlinux, where you have to click things and insert discs). I have no idea how many games this will work for, but heck, may as well try it. I expect to use this in automated testing sometime, and welcome additional verbs if people feel like writing them. - Dan

1 1