March 2010 - Wine-devel - list.winehq.org

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests
by Greg Geldorp 25 Mar '10

25 Mar '10

Hi Mike, > From: Mike Kaplinskiy > > I recently discovered > that winetestbot doesn't run on win98 by default - will keep that in > mind in the future. Is there any reason for that? Not really, apart from a certain amount of hate on my side towards Win9x. I've added W98SE (which you might have guessed runs Windows 98 Second Edition) to the default set. Ge.

1 0

Re: [1/3] WineD3D: check the GL flags in CheckDepthStencilCapability, not the static info
by Henri Verbeet 25 Mar '10

25 Mar '10

On 24 March 2010 23:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > These flags will be unset if the format is not supported by GL and is consistent with the other > depth stencil check functions. So what happens if the GL implementation doesn't support ARB_depth_texture, for example?

3 7

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost (retry)
by Paul Vriens 25 Mar '10

25 Mar '10

On 03/25/2010 09:15 AM, Sébastien Ramage wrote: > --- > dlls/user32/scroll.c | 5 +---- > dlls/user32/tests/scroll.c | 16 +++++++++++++++- > 2 files changed, 16 insertions(+), 5 deletions(-) > Hi You can see at http://source.winehq.org/patches/ that your patch '59740' had an apply failure. And fair enough: $ patch -p 1 -i /home/paul/0001-PATCH-user32-end-scrollbar-tracking-if-the-mouse-captu.txt (Stripping trailing CRs from patch.) patching file dlls/user32/scroll.c (Stripping trailing CRs from patch.) patching file dlls/user32/tests/scroll.c You have DOS line endings in your patch. A simple dos2unix fixes this. -- Cheers, Paul.

2 2

Re: [PATCH 2/8] msvcr90: Implement _encode_pointer and _decode_pointer (try4)
by Alexandre Julliard 25 Mar '10

25 Mar '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcr80/msvcr80.spec | 4 ++-- > dlls/msvcr90/msvcr90.c | 21 +++++++++++++++++++++ > dlls/msvcr90/msvcr90.spec | 4 ++-- > dlls/msvcr90/tests/msvcr90.c | 26 +++++++++++++++++++++++++- > 4 files changed, 50 insertions(+), 5 deletions(-) Still doesn't build on Mingw I'm afraid: make[1]: Entering directory `/home/julliard/wine/build/obj-pe64/dlls/msvcr80' ../../../obj-elf64/tools/winegcc/winegcc -b x86_64-pc-mingw32 -m64 -B../../../obj-elf64/tools/winebuild --sysroot=../.. -shared ../../../wine/dlls/msvcr80/msvcr80.spec msvcr80.o -o msvcr80.dll -lmsvcrt -lmsvcr90 -lkernel32 ../../libs/port/libwine_port.a /home/julliard/wine/mingw/mingw64/bin/../lib/gcc/x86_64-pc-mingw32/4.5.0/../../../../x86_64-pc-mingw32/lib/libmingw32.a(lib64_libmingw32_a-mingw_helpers.o): In function `_decode_pointer': /home/buildbot/mingwslave/linux-x86_64/build/mingw/obj/../mingw-w64-crt/crt/mingw_helpers.c:20: multiple definition of `__decode_pointer' ../../dlls/msvcr90/libmsvcr90.a(dwaes00111.o):(.text+0x0): first defined here /home/julliard/wine/mingw/mingw64/bin/../lib/gcc/x86_64-pc-mingw32/4.5.0/../../../../x86_64-pc-mingw32/lib/libmingw32.a(lib64_libmingw32_a-mingw_helpers.o): In function `_encode_pointer': /home/buildbot/mingwslave/linux-x86_64/build/mingw/obj/../mingw-w64-crt/crt/mingw_helpers.c:26: multiple definition of `__encode_pointer' ../../dlls/msvcr90/libmsvcr90.a(dwaes00118.o):(.text+0x0): first defined here collect2: ld returned 1 exit status x86_64-pc-mingw32-dllwrap: x86_64-pc-mingw32-gcc exited with status 1 winegcc: x86_64-pc-mingw32-dllwrap failed make[1]: *** [msvcr80.dll] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces
by Dmitry Timoshkov 25 Mar '10

25 Mar '10

Eric Pouech <eric.pouech(a)orange.fr> wrote: > > Eric Pouech <eric.pouech(a)orange.fr> wrote: > > > > > Gdb uses decimal notation by default for integers, so do we. > > > > GDB can use anything their developers think appropriate, my patch > > to use hex was intended to match Wine's relay traces and win32 > > header constants. This patch will make finding matches impossible > > again. > bt /x will do what you want. How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format? -- Dmitry.

4 12

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages
by Alexandre Julliard 24 Mar '10

24 Mar '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > --- > server/async.c | 8 ++++++++ > server/file.h | 1 + > server/sock.c | 26 +++++++++++--------------- > 3 files changed, 20 insertions(+), 15 deletions(-) This doesn't look right. You shouldn't ignore POLLIN/POLLOUT, they shouldn't have been selected in the first place. If you do get them you have to do something with them and unselect them. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests
by Paul Vriens 24 Mar '10

24 Mar '10

On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: > --- > dlls/ws2_32/tests/Makefile.in | 2 +- > dlls/ws2_32/tests/sock.c | 735 +++++++++++++++++++++++++++++++++++++---- > 2 files changed, 672 insertions(+), 65 deletions(-) > Hi Mike, I took the liberty of running your new tests on winetestbot. It shows failures on Win98: https://winetestbot.geldorp.nl/JobDetails.pl?Key=1164 (Win95 fails of course due to missing ws2_32.dll so these tests won't even run via winetest.exe). -- Cheers, Paul.

2 2

Re: [PATCH] d3dxof: Increase MAX_SUBOBJECTS and do the corresponding checks at the right place
by Henri Verbeet 24 Mar '10

24 Mar '10

I notice several of these limits have been increased in the past, sometimes multiple times. What exactly are these supposed to protect against?

2 1

Re: configure.ac: detect libusb-1.0
by Albert Lee 24 Mar '10

24 Mar '10

On Wed, 24 Mar 2010 16:15:59 +0200, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * configure.ac: detect libusb-1.0 > There are multiple libusb implementations (notably, Solaris libusb and FreeBSD libusb20) and it would be necessary to do an API test for those, rather than using pkgconfig. -Albert

3 3

d3dx9_36: Add stubbed interface for ID3DXEffect
by David Adam 24 Mar '10

24 Mar '10

Hello, the 2 lines + #include "d3dx9.h" + #include "d3dx9effect.h" in the d3dx9_36/effect.c file are useless, since in the d3dx9_private file, one calls d3dx9.h file which calls d3dx9effect.h A+ David

2 3