May 2010 - Wine-devel - list.winehq.org

Re: user32/tests: check return value of GetUpdateRect in test_validatergn (try 2)
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2258 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00730134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00750134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00770134 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040224 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A00134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A10134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040224 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: kernel32/tests: use ret in load_blackbox() (try 2)
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:302: Test failed: Timed out waiting for the child to crash debugger.c:316: Test failed: wrong exit code : 00000103 debugger.c:327: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtDCAB.tmp': read=0 debugger.c:332: Test failed: wrong debugger argument count: -28562032 debugger.c:333: Test failed: the child and debugged pids don't match: 368 != 2046 debugger.c:302: Test failed: Timed out waiting for the child to crash debugger.c:309: Test failed: wrong exit code : 00000103 debugger.c:327: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtB1BC.tmp': read=0 debugger.c:332: Test failed: wrong debugger argument count: -28562032 debugger.c:333: Test failed: the child and debugged pids don't match: 2404 != 2046 Timeout

1 0

Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > alarmThread = CreateThread(NULL, 0, alarmThreadMain, (void *) 20000, 0, &alarmThreadId); > + ok(alarmThread != INVALID_HANDLE_VALUE, "CreateThread\n"); CreateThread doesn't return INVALID_HANDLE_VALUE on failure. Clarifying the error message and printing last error (in decimal) would be better. -- Dmitry.

2 1

Re: user32/tests: check return value of GetUpdateRect in test_validatergn
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00090136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000D0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000E0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: Re: user32/tests: check return value of DdeClientTransaction in test_initialisation()
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:2042: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: user32/tests: check return value of GetUpdateRect in test_validatergn
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > ValidateRect( hwnd, &rc); > ret = GetUpdateRect( child, &rc2, 0); > + ok(!ret, "GetUpdateRect failed %08x\n", GetLastError()); > ok( rc2.left == 0 && rc2.top == 0 && rc2.right == 0 && rc2.bottom == 0, > "Update rectangle %d,%d-%d,%d is not empty!\n", rc2.left, rc2.top, > rc2.right, rc2.bottom); > @@ -3228,6 +3230,7 @@ static void test_validatergn(HWND hwnd) > rgn = CreateRectRgnIndirect( &rc); > ValidateRgn( hwnd, rgn); > ret = GetUpdateRect( child, &rc2, 0); > + ok(!ret, "GetUpdateRect failed %08x\n", GetLastError()); Please set last error to 0xdeadbeef prior checking it, and print last error value in decimal. -- Dmitry.

1 0

Re: kernel32/tests: use ret in load_blackbox()
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2243 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:301: Test failed: Timed out waiting for the child to crash debugger.c:315: Test failed: wrong exit code : 00000103 debugger.c:326: Test failed: Timed out waiting for the debugger debugger.c:148: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtADEB.tmp': read=0 debugger.c:331: Test failed: wrong debugger argument count: -28562032 debugger.c:332: Test failed: the child and debugged pids don't match: 2612 != 2046 debugger.c:301: Test failed: Timed out waiting for the child to crash debugger.c:308: Test failed: wrong exit code : 00000103 debugger.c:326: Test failed: Timed out waiting for the debugger debugger.c:148: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wt82DC.tmp': read=0 debugger.c:331: Test failed: wrong debugger argument count: -28562032 debugger.c:332: Test failed: the child and debugged pids don't match: 2412 != 2046 Timeout

1 0

Re: kernel32/tests: use ret in load_blackbox()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > ret=ReadFile(hFile, blackbox, size, &read, NULL); > + ok(ret, "ReadFile failed: %08x\n", GetLastError()); Printing last error without prior setting it to 0xdeadfeef won't really help. Also errors returned by GetLastError() are defined in decimal in winerror.h. -- Dmitry.

1 0

Re: gdi32/tests: use ret in test_CreateFontIndirect()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > @@ -3096,6 +3096,7 @@ static void test_CreateFontIndirect(void) > hfont = CreateFontIndirectA(&lf); > ok(hfont != 0, "CreateFontIndirectA failed\n"); > ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); > + ok(ret, "GetObject failed: %08x\n", GetLastError()); Printing last error without prior setting it to 0xdeadfeef won't really help. Also errors returned by GetLastError() are defined in decimal in winerror.h. -- Dmitry.

1 0

Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2()
by Andrew Nguyen 22 May '10

22 May '10

On Sat, May 22, 2010 at 2:06 AM, Austin English <austinenglish(a)gmail.com> wrote: > Also fix a typo. > > Passes WTB: > https://testbot.winehq.org/JobDetails.pl?Key=2242 > > -- > -Austin > > > > While you're at it, you might as well fix the "change" typo.

1 0