May 2010 - Wine-devel - list.winehq.org

Re: [3/9] ole32: Validate pointer parameters in MkParseDisplayName.
by Alexandre Julliard 20 May '10

20 May '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -814,12 +814,53 @@ static void test_MkParseDisplayName(void) > static const WCHAR wszDisplayNameProgId1[] = {'S','t','d','F','o','n','t',':',0}; > static const WCHAR wszDisplayNameProgId2[] = {'@','S','t','d','F','o','n','t',0}; > static const WCHAR wszDisplayNameProgIdFail[] = {'S','t','d','F','o','n','t',0}; > + static const WCHAR wszEmpty[] = {0}; > char szDisplayNameFile[256]; > WCHAR wszDisplayNameFile[256]; > + int i; > + > + const struct > + { > + LPBC pbc; > + LPCOLESTR szDisplayName; > + LPDWORD pchEaten; > + LPMONIKER *ppmk; > + } invalid_parameters[] = > + { > + {NULL, NULL, NULL, NULL}, > + {NULL, NULL, NULL, &pmk}, > + {NULL, NULL, &eaten, NULL}, > + {NULL, NULL, &eaten, &pmk}, > + {NULL, wszEmpty, NULL, NULL}, > + {NULL, wszEmpty, NULL, &pmk}, > + {NULL, wszEmpty, &eaten, NULL}, > + {NULL, wszEmpty, &eaten, &pmk}, > + {pbc, NULL, NULL, NULL}, > + {pbc, NULL, NULL, &pmk}, > + {pbc, NULL, &eaten, NULL}, > + {pbc, NULL, &eaten, &pmk}, > + {pbc, wszEmpty, NULL, NULL}, > + {pbc, wszEmpty, NULL, &pmk}, > + {pbc, wszEmpty, &eaten, NULL}, > + {pbc, wszEmpty, &eaten, &pmk}, > + }; This won't do what you want, there's nothing in pbc at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg audio tab contents
by Maarten Lankhorst 20 May '10

20 May '10

Hello Joerg, On 18-05-10 15:33, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > did you notice that in winecfg-1.1.44, the audio tab content > is broken: nothing is displayed below ALSA, and OSS lists 5 > things only. There used to be much more content. > This is likely a side effect from not calling DRVM_INIT before calling GETNUMDEVS, meaning the devices are closed. I sent in a bunch of patches so that things aren't initialized before they are used. Manually calling DRVM_INIT might help, but then you would have to make sure you're not using ANY of the winmm functions that also talk to the driver. a patch like this would probably fix it: - if (wodMessagePtr) + if (wodMessagePtr && wodMessagePtr(0, DRVM_INIT, 0, 0, 0)) num_wod = wodMessagePtr(0, WODM_GETNUMDEVS, 0, 0, 0); However, it is best to make sure that DRVM_INIT is only called once to avoid ill side effects. I wouldn't worry about it much, After 1.2 is shipped the audio tab will be all gone anyhow. :) Cheers, Maarten

2 1

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).
by Paul Vriens 20 May '10

20 May '10

On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: > The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW > returns NULL there is a crash. > --- > dlls/msi/msi.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 3170e6d..9c08d1b 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -551,7 +551,8 @@ static UINT MSI_ApplicablePatchW( MSIPACKAGE *package, LPCWSTR patch ) > > done: > msiobj_release(&patch_db->hdr ); > - msiobj_release(&si->hdr ); > + if (si) > + msiobj_release(&si->hdr ); > return r; > } > Hi Michael, This one is mentioned by Coverity (#970). Marcus marked this one as 'FALSE' with the remark: "hdr is at position 0, so this will be NULL and msiobj_release handles it." Thoughts? -- Cheers, Paul.

4 8

Re: [7/7] msi: Add more tests for feature overrides.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2196 Your paranoid android. === W2K8SE (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5350: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5369: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5394: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5413: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8203: Test failed: RegQueryValueExA failed 2 (0) install.c:8466: Test failed: file not installed install.c:8478: Test failed: file not installed install.c:8479: Test failed: file not installed install.c:8487: Test failed: file removed install.c:8488: Test failed: directory removed install.c:8494: Test failed: file not installed install.c:8495: Test failed: file not installed install.c:8503: Test failed: file removed install.c:8504: Test failed: directory removed install.c:8892: Test failed: file not created install.c:8893: Test failed: file not created install.c:8959: Test failed: file not created install.c:8960: Test failed: file not created install.c:8962: Test failed: file not created install.c:8968: Test failed: file removed install.c:8973: Test failed: directory removed install.c:9020: Test failed: key not removed install.c:9030: Test failed: key not removed install.c:9041: Test failed: key not removed install.c:9115: Test failed: got 6 expected 0 install.c:9121: Test failed: got 6 expected 0 install.c:9124: Test failed: got 6 expected 0 install.c:9126: Test failed: file removed install.c:9271: Test failed: key not created

1 0

Re: [6/7] msi: Test the reference count on the installer object retrieved from a session object.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2195 Your paranoid android. === W7PROX64 (64 bit automation) === automation.c:2468: Test failed: Expected imaname, got automation.c:2485: Test failed: Expected imaname, got

1 0

Re: [TRY 2] shdocvw: Added IOleLink stub implementation.
by Jacek Caban 20 May '10

20 May '10

On 5/20/10 9:33 AM, Ilya Shpigor wrote: +void WebBrowser_OleLink_Init(WebBrowser *This) +{ + This->lpOleLinkVtbl =&OleLinkVtbl; +} You don't need a separated function for that. Just use WebBrowser_OleObject_Init. Jacek

1 0

Re: winmm: Have MCI drivers handle notification for MCI_OPEN.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2193 Your paranoid android. === W98SE (32 bit mci) === mci.c:613: Test failed: Expect message 0001 from play to 250 wait notify mci.c:620: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close mci.c:784: Test failed: mci pause wait returned MMSYSERR 5 mci.c:798: Test failed: mci pause (space) wait returned MMSYSERR 5 mci.c:801: Test failed: mci pause wait returned MMSYSERR 5 mci.c:815: Test failed: Expect message 0004 from play (aborted by close)

2 1

Re: quartz: Avoid using the long type.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2159 Your paranoid android. === WNT4WSSP6 (32 bit referenceclock) === referenceclock.c:99: Test failed: Unable to create reference clock from system clock 80040154

2 1

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2163 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4393: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4398: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

D3DX9: how to implement D3DXDeclaratorFromFVF
by David Adam 20 May '10

20 May '10

Hello, I would like to implement the function D3DXDeclaratorFromFVF. My numerous attempts to do this were rejected (specially my copy/paste of the function vdecl_convert_fvf from d3d9/vertexdeclaration.c. Does anyone know a way to implement it? Thanks in advance David

1 0