June 2010 - Wine-devel - list.winehq.org

Re: hhctrl.ocx - null pointer bug
by Dmitry Timoshkov 19 Jun '10

19 Jun '10

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html > sent by Dmitry Timoshkov contains bug resulting in wine crash due to > possible null pointer dereference. Please, see bug report at > http://bugs.winehq.org/show_bug.cgi?id=23247 for more information. You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults in all cases instead. Is that a real or just "possible" crash? From your description and the bug report it sounds like a theoretical issue. -- Dmitry.

2 1

Re: hhctrl.ocx - null pointer bug
by Juan Lang 18 Jun '10

18 Jun '10

Hi Jaroslav, - if (!*caption) caption = info->pCHMInfo->defTitle; + if (!caption) caption = info->pCHMInfo->defTitle; I suspect a better fix would be: + if (!caption || !*caption) caption = info->pCHMInfo->defTitle; That is, either a NULL caption or an empty one results in info->pCHMInfo->defTitle getting used. --Juan

2 1

New wisotool 20100618: 19 new verbs (blur, spore, photoshop cs5, ...), and 75 old ones
by Dan Kegel 18 Jun '10

18 Jun '10

wisotool is a handy winetricks-like script for automatically installing games from .iso or .mds files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for your password so it can mount the .iso file). Wisotool currently supports about 95 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. I'm especially interested in recent or beta games; ideally wisotool would support good games or betas on or near their day of release. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100530: Austin English: New verbs proevolution2010_demo pscs5 pscs5_pickle pscs5_unpickle Dan Kegel: New verbs bioshock_demo blur rom Various bugfixes Eleazar Galano: New verbs avatar_demo braid braid_demo darknesswithin2_demo hegemonypom_demo hphbp_demo nfsps_demo popsot spore Travis Athougies: New verbs 7million msaoe_demo Vincent Pelletier: New verb beneath_a_steel_sky_gog Here's the current help message: Script to install games automatically. Usage: wisotool [options] package [package] ... Options: -q quieter -v verbose -V display Version Packages: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] 7million 7Million (Deep Silver, 2009) [download] [broken on wine] abes_exoddus_gog Abes Exoddus (GOG.com) abes_oddysee_gog Abes Oddysee (GOG.com) assassinscreed Assassins Creed (Ubisoft, 2008) avatar_demo James Camerons Avatar The Game Demo (Ubisoft, 2009) [download] baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) battle_chess_gog Battle Chess (GOG.com) beneath_a_steel_sky_gog Beneath a Steel Sky (GOG.com, free) beyond_good_and_evil_gog Beyond Good and Evil (GOG.com) bfbc2 Battlefield Bad Company 2 (EA, 2010) bioshock Bioshock (2K Games, 2007) bioshock_demo Bioshock Demo (2K Games, 2007) blur Blur (Activision, 2010) braid Braid (Number None, 2009) [download] braid_demo Braid Demo (Number None, 2009) [download] codmw2 Call of Duty Modern Warfare 2 (Activision, 2009) [broken] darknesswithin2_demo Darkness Within 2 Demo (Zoetrope Interactive, 2010) [download] descent_1_2_gog Descent and Descent 2 (GOG.com) descent_3_gog Descent 3 (GOG.com) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) dukenukem3d_gog Duke Nukem 3D (GOG.com) dukenukemmp_gog Duke Nukem Manhattan Project (GOG.com) earth_2150_trilogy_gog Earth 2150 trilogy (GOG.com) earth_2160_gog Earth 2160 (GOG.com) earthworm_jim_1_2_gog Earthworm Jim 1 & 2 (GOG.com) earthworm_jim_3d_gog Earthworm Jim 3D (GOG.com) empire_earth_gold_gog Empire Earth Gold (GOG.com) evil_genius_gog Evil Genius (GOG.com) fallout_2_gog Fallout 2 (GOG.com) fallout_gog Fallout (GOG.com) fallout_tactics_gog Fallout Tactics (GOG.com) far_cry_gog Far Cry (GOG.com) flatout_gog FlatOut (GOG.com) freespace_2_gog Freespace 2 (GOG.com) freespace_gog Freespace (GOG.com) ghost_master_gog Ghost Master (GOG.com) ground_control_2_gog Ground Control 2 (GOG.com) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) half_life_goty Half Life: Game of the Year Edition (Sierra, 2000) hegemonypom_demo Hegemony: Philip of Macedon Demo (Longbow Games, 2010) [download] help How to use this tool hon Heroes of Newerth (S2 Games, 2010) [download] hphbp_demo Harry Potter & The Half Blood Prince Demo (EA, 2009) [download] lswcs Lego Star Wars Complete Saga (Lucasarts, 2009) manhole The Manhole Masterpiece Edition (Cyan, 1994) masseffect2 Mass Effect 2 (BioWare, 2010) mdk2_gog MDK 2 (GOG.com) mdk_gog MDK (GOG.com) mnbw_demo Mount & Blade Warband Demo (Taleworlds, 2010) [download] morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) msaoe_demo Age of Empires Demo (Microsoft, 1997) [download] neighbours_from_hell_compilation_gog Neighbours From Hell 1 & 2 (GOG.com) nfsps_demo Need For Speed: Pro Street Demo (EA, 2007) operation_flashpoint_goty_gog Operation Flashpoint GOTY (GOG.com) orangebox Orange Box (Valve, 2007) painkiller_black_gog Painkiller Black (GOG.com) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] perimeter_gog Perimeter (GOG.com) plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] popsot Prince of Persia Sands of Time (Ubisoft, 2003) popsot_demo Prince of Persia Sands of Time Demo (Ubisoft, 2003) praetorians_gog Praetorians (GOG.com) procycling08_demo Pro Cycling Manager 2008 Demo (Cyanide, 2008) [download, broken in wine] procycling09_nda Pro Cycling Manager 2009 (Cyanide, 2009) proevolution2010_demo Pro Evolution Soccer 2010 Demo (Konami, 2009) [download] pscs5 Photoshop CS5 Demo (Adobe, 2010) pscs5_pickle save Photoshop CS5 Demo to tarball pscs5_unpickle restore Photoshop CS5 Demo from tarball psychonauts_gog Psychonauts (GOG.com) quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] redneck_rampage_gog Redneck Rampage (GOG.com) robinson_requiem_collection_gog Robinson Requiem & Deus (GOG.com) rom Runes of Magic (Frogster Interactive, 2009) [download] settlers_2_gold_gog The Settlers 2 Gold (GOG.com) shogo_gog Shogo Mobile Armor Division (GOG.com) sims3 The Sims 3 (EA, 2009) splitsecond Split Second (Black Rock Studios, 2010) [wine bug 22865] splitsecond_demo Split Second Demo (Black Rock Studios, 2010) [wine bug 22865] spore Spore (EA, 2008) starcraft Starcraft Battle Chest (Blizzard, 1998) starcraft2 Starcraft II beta (Blizzard, 2010) stfu Starwars: The Force Unleashed (Aspyr, 2009) sto Star Trek Online (Cryptic, 2010) tex_murphy_1_and_2_gog Tex Murphy 1 & 2 (GOG.com) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] unreal_2_se_gog Unreal 2: The awakening Special Edition (GOG.com) unreal_gold_gog Unreal Gold Edition (GOG.com) ut2004_gog Unreal Tournament 2004 (GOG.com) ut_goty_gog Unreal Tournament GOTY (GOG.com) wog World of Goo demo (2D Boy, 2008) [download] wowbc World of Warcraft: Battle Chest (Blizzard, 2008) Pseudopackages: load Load a disc into the iso cache load=KEY Load a disc with given key; only works from commandline at moment ------------------------------------------------------ If the game is not marked with {download} or {loaded} in the menu, you have to insert its disc and give the 'load' command before you can choose that game in the menu. If the game has multiple discs, you have to do this for each disc. ------------------------------------------------------ ------------------------------------------------------ If the game has an install key, you have to enter that when loading the first disc. (You have to do that from the commandline, e.g. sh wisotool load=XXXX-YYYY-ZZZZ.) ------------------------------------------------------

1 0

Happy Father's Day From CodeWeavers: Get CrossOver Mac for 60% Off (This Weekend Only)
by James Ramey 18 Jun '10

18 Jun '10

Thank you for your past patronage of CrossOver Mac. We appreciate your business, and I was hoping to tempt you with an enticing offer to continue supporting our software. For this weekend only, you can purchase CrossOver (any version) for 60% off the list price. All you need to do is enter SPECIAL DEAL CODE: FATHERSDAY in the Special Deal Box in the cart screen (has to be the cart screen) of the order process. You'll see the discount applied before you complete your transaction. It's a quick and easy way to save money on your purchase of CrossOver. · A couple of factoids you might want to consider in making this purchase: · CrossOver 9.1 is due out within the next 45 days. CrossOver 9.1 should be an especially good release of CrossOver, and the upgrade to this version is included in your purchase. · CrossOver Mac Professional includes a license for CrossOver Mac Games. CrossOver Mac Games is now playing many new titles including Star Trek On-line. If you have an interest in playing games, you may want to consider purchasing CrossOver Mac Professional using the SPECIAL DEAL CODE. · All volume and educational discounts are still valid with this promotion. If you have an educational entitlement, you'll get your educational discount in addition to the SPECIAL DEAL CODE. Likewise if you purchase more than one license, you'll also get volume discounts. Again, this SPECIAL DEAL CODE is easy to use and will save you money!! · The SPECIAL DEAL CODE expires on Monday, June 21. Don't wait to buy. If you're interested, make your purchase now as this special deal is limited to only past customers and only to this weekend. · If this SPECIAL DEAL CODE isn't your cup of tea, I understand. This is the only e-mail that you will receive from me about renewing your support. You'll receive a nag e-mail or two from our system reminding you to renew your maintenance. Once those have past, we will not contact you again (ever) unless you have signed up for one of our many mailing lists. Finally, everyone at CodeWeavers appreciates your business. We appreciate your patience as we work to make our software ever better. We understand that it's not always easy to use our software and that our software doesn't always provide the support you want or need. We want you to know this and that we are making efforts to make the software better. Again, thank you. We sincerely appreciate your support of our software and our efforts to make our software better. With my best regards, James B. Ramey Vice President, Sales CodeWeavers, Inc. jramey(a)codeweavers.com

1 0

The __WINE__ macro does not identify the Wine platform
by Alan W. Irwin 18 Jun '10

18 Jun '10

According to some old discussion (http://www.mail-archive.com/wine-devel(a)winehq.com/msg15669.html) on wine-devel it appears that __WINE__ was going to be the macro used to identify the Wine platform, However, that doesn't appear to work for Windows native MinGW on wine. To show this, I attach results from running wine gcc -E -dM foo.c >| /tmp/wine_gcc_dM.out where foo.c is an empty file, and gcc is the MinGW 4.5.0-1 version. The equivalent command under Linux gcc shows several macros, (e.g., __linux__) are defined to identify that platform, but I cannot find anything in the attached file that similarly identifies the Wine platform. Furthermore, I have compiled and run a simple test code under Wine that shows that __WINE__ is not available (see previous post on wine-users for details). An excellent general motivation for such an identifying macro for wine is given in the above older wine-devel discussion, and I understand the CMake developers have an immediate use for such a macro within the CMake code itself. Is the lack of a macro to identify the wine platform a bug I should report or am I missing something? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 11

Re: user32: Lock user32 in alloc_user_handle to fix races with get_user_handle_ptr
by Dan Kegel 18 Jun '10

18 Jun '10

On Fri, Jun 18, 2010 at 9:18 AM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > On Friday 18 June 2010 07:04:14 pm Dan Kegel wrote: >> Say, that sounds like a kind of test we should have in our test suite. >> >> What apps does this fix? > > Sysinternal's autoruns.exe which populates a number of list/tree views with a > large number of icons extracted them the exes. It seems to do so from > different threads and it doesn't stop if one thread crashes (I wonder - > intentionally?) > > Unfortunately it's a race condition that doesn't always happen. Adding just a > TRACE suppressed the error. Adding if (...) ERR(...) showed that only 1-2 out > of about 150 icon creations would crash. Thanks for the info.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests (try 2)
by Alexandre Julliard 18 Jun '10

18 Jun '10

Marko Nikolic <grkoma(a)gmail.com> writes: > Fixed test failures in 64-bit build. It would be better to choose a more appropriate invalid value for a BOOL variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Force a minimum character size of 1x1 to prevent divisions by zero if setting the font failed
by Alexandre Julliard 18 Jun '10

18 Jun '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > user32: Force a minimum character size of 1x1 to prevent divisions by zero if > setting the font failed > > Failing to set any font is unusual but can happen - for example: > DISPLAY= wine notepad It sounds like a gdi bug. It should be able to provide metrics even without a display. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by Alexandre Julliard 18 Jun '10

18 Jun '10

Aric Stewart <aric(a)codeweavers.com> writes: > commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Fri Jun 18 13:21:56 2010 +0900 > > comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons It would probably be better to not disable buttons that don't need it. What is this fixing? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by James Mckenzie 18 Jun '10

18 Jun '10

Aric Stewart <aric(a)codeweavers.com> wrote: > >Alexandre Julliard wrote: >> Aric Stewart <aric(a)codeweavers.com> writes: >> >>> commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 >>> Author: Aric Stewart <aric(a)codeweavers.com> >>> Date: Fri Jun 18 13:21:56 2010 +0900 >>> >>> comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons >> >> It would probably be better to not disable buttons that don't need >> it. What is this fixing? >> > >I can modify the patch to do that. > >This is triggering a bug on the mac that causes the window manager to >loose track of where to send messages causing the resulting dialog to be >unable to get mouse events. > Thank you for taking time to fix this. What is the bug report number so that I can go out and vote for it. I've experienced this lately while running some regression tests and I thought that it was just my system messing up (I've had to reboot it several times in the last week or so.) BTW, 10.6.4 has been released, 700MB download :( James McKenzie

1 0