June 2010 - Wine-devel - list.winehq.org

re: Advice about a new project, and similarity to Wine's start
by Dan Kegel 05 Jun '10

05 Jun '10

Alessandro Pignotti wrote: > how did Wine choose the feature set to support first? Pragmatically - by trying to get particular popular apps running. (Starting with solitaire :-) > Did people use the early releases of Wine, even if they were missing features? Yes, as soon as they ran their favorite app. So in your case, as soon as your flash player can handle youtube.com (or whatever free software afficianados can't live without), a few people will start using it. > Is the AppDB software available for use on other projects? Should be. > Any misc advice? The Wine project started moving faster when we switched to test-driven development. I highly recommend it. Do you have a test suite? And/or can you share existing test suites ( e.g. http://wiki.gnashdev.org/Testcases ) ? That said, visual stuff is hard to test automatically, so mostly our automated tests only test the API level. Visual tests are done manually and much less often (say, only when changing directly affected code). Automated performance benchmarks are a good idea, though we haven't done as much of that. Good luck! - Dan

2 1

Advice about a new project, and similarity to Wine's start
by Alessandro Pignotti 05 Jun '10

05 Jun '10

Hi everyone, first of all congratulations. The current maturity of Wine is really, really impressive. Thanks for your work. Let's introduce myself, I'm the author of the Lightspark project (http://lightspark.sf.net) a modern, open source, flash player implementation. The project is currently in a very good shape, featuring scripting support, a JIT compiler and OpenGL accelerated rendering. But, although the core VM is mostly complete, a huge part of the runtime library is still missing. I'm asking advice here because this is probably a condition similar to the one faced by early Wine developers. I'm currently pretty confused about the roadmap of my project. Although some interest gathered after the announcement of the 0.3.0 release and some bug reports appeared I've not yet managed to gather the needed community feedback. Moreover, beside supporting the most popular flash applications (e.g. YouTube, which is mostly supported), I've no idea about what to do later and how to prioritize features. So my question is: how did Wine choose the feature set to support first? Did people use the early releases of Wine, even if they were missing features? Is the AppDB software available for use on other projects? Any misc advice? Thanks a lot for your help. and sorry for the quite OT message, Alessandro Pignotti

2 1

Wine code comments
by John Voltz 05 Jun '10

05 Jun '10

Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are using the block comment marker /*. This is a royal pain when trying to comment out large sections of code where there are a bunch of /* foo */ comments. Why is this allowed? Is there are way around it without having to change them all to //? Regards, John Voltz

6 8

Re: shdoclc: Add the Polish translation (try 2)
by Paul Vriens 05 Jun '10

05 Jun '10

On 06/05/2010 01:38 PM, Łukasz Wojniłowicz wrote: > + MENUITEM "&Odœwie¿ > +", _IDM_REFRESH Hi Łukasz, Something went wrong here. -- Cheers, Paul.

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by Nikolay Sivov 05 Jun '10

05 Jun '10

On 6/3/2010 23:35, Andrew Eikum wrote: > > This fixes a bug with Internet Explorer 6's Favorites menu. > > This function used to be named IUnknown_EnumObjects, so my guess is > that the original implementor thought it'd be wise to verify the type > of the object before executing IShellFolder's methods on it. Since > it's now called IShellFolder_EnumObjects and explicitly takes an > LPSHELLFOLDER parameter, I see no reason to do the typecheck. And where is a test for that? > > --- > dlls/shlwapi/ordinal.c | 19 +------------------ > dlls/shlwapi/tests/Makefile.in | 2 +- > dlls/shlwapi/tests/ordinal.c | 32 ++++++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+), 19 deletions(-)

2 9

Re: shdoclc: Add the Polish translation
by Paul Vriens 05 Jun '10

05 Jun '10

On 06/04/2010 04:33 PM, Łukasz Wojniłowicz wrote: > + > +LANGUAGE LANG_POLISH, SUBLANG_NEUTRAL > + > +IDR_BROWSE_CONTEXT_MENU MENU Hi Łukasz, Sorry if I wasn't clearer before. You are having effectively two blocks with the same translations now. The reason the English resource file has two blocks is because it has effectively two translations (one for SUBLANG_DEFAULT and one for SUBLANG_NEUTRAL). There is no need to do that in most of the other resource files like Polish as there is only one Polish language (as far as resource files are concerned). Could you also add something to the Subject when resending? So for example "(Resend)" when sending the same patch again or "(Try x)" when you sent a new version of the patch. -- Cheers, Paul.

1 0

Wine on MIPS?
by André Hentschel 05 Jun '10

05 Jun '10

Hi, i just read that MIPS is planning to get on the mobil market. It will be available in 4G Smartphones with Android. Wine has a MIPS port which should also run those obsolete Win32 MIPS Apps, so i guess the winelib side is more interesting. So here my question: did anyone recently tried to compile Wine on MIPS and did it worked? If not, is anybody able to? -- Best Regards, André Hentschel

1 0

Re: [1/2]wineps.drv: make use of MAKEINTRESOURCEW
by Dmitry Timoshkov 04 Jun '10

04 Jun '10

André Hentschel <nerv(a)dawncrow.de> wrote: > +#define PAPER 99 > #define IDD_PAPERS 100 > #define IDD_ORIENT_PORTRAIT 101 > #define IDD_ORIENT_LANDSCAPE 102 You could try to find a less generic name for this. -- Dmitry.

1 0

Re: [2/2]wineps.drv: Import comctl32 instead of loading it
by Dmitry Timoshkov 04 Jun '10

04 Jun '10

André Hentschel <nerv(a)dawncrow.de> wrote: > -IMPORTS = user32 gdi32 winspool advapi32 kernel32 > +IMPORTS = user32 gdi32 winspool advapi32 kernel32 comctl32 It's being loaded for a reason. You can make it delay loaded though. -- Dmitry.

1 0

Re: [PATCH] msi/tests: Fix install tests for Win9x
by testbot＠testbot.winehq.org 04 Jun '10

04 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2470 Your paranoid android. === WNT4WSSP6 (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5411: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5430: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5455: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5474: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:3534: Test failed: Expected 314, got 1 install.c:8264: Test failed: RegQueryValueExA failed 2 (0)

1 0