June 2010 - Wine-devel - list.winehq.org

Re: Change a malloc() to a HeapAlloc()
by Peter Davies 09 Jun '10

09 Jun '10

> We use real names here. This patch probably will not be committed until it > is resubmitted. Ops! I've mis-configured my mail client > The patch is also wrong. Why? What difference does malloc() over HeapAlloc() make? (this is arguably a case for not sending the patch in the first place) There is nothing that bugs me more than not being told why I'm wrong. Peter

3 2

Re: [PATCH] [WinHelp]: implemented ExecFile macro (fix for #23054)
by Alexandre Julliard 09 Jun '10

09 Jun '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > +static void CALLBACK MACRO_ExecFile(LPCSTR pgm, LPCSTR args, LONG cmd_show, LPCSTR topic) > { > - WINE_FIXME("(\"%s\", \"%s\", %u, \"%s\")\n", str1, str2, u, str3); > + static HINSTANCE (WINAPI *shell_exec)(HWND, LPCSTR, LPCSTR, LPCSTR, LPCSTR, INT); > + HINSTANCE ret = 0; > + > + WINE_TRACE("(\"%s\", \"%s\", %u, \"%s\")\n", pgm, args, cmd_show, topic); > + if (!shell_exec) > + { > + HANDLE h; > + > + if ((!(h = GetModuleHandle("shell32.dll")) && !(h = LoadLibraryA("shell32.dll"))) || > + !(shell_exec = (void*)GetProcAddress(h, "ShellExecuteA"))) > + { > + WINE_ERR("Couldn't load shell32.ShellExecute\n"); > + } > + } Why not call ShellExecuteA directly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by Marco Meijer 09 Jun '10

09 Jun '10

Hi WineDevs, I made the patch to change the text on winehq and sent it to wine-patches but still no change. Do I have to do something else ? link to patch: http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html kind regards, Marco Meijer http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html Op 6-5-10 17:57, James Mckenzie schreef: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

2 1

Re: [1/3] msi: Create directories right before installing files.
by testbot＠testbot.winehq.org 09 Jun '10

09 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2538 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5408: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5427: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5452: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5471: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8261: Test failed: RegQueryValueExA failed 2 (0) install.c:9173: Test failed: got 6 expected 0 install.c:9179: Test failed: got 6 expected 0 install.c:9182: Test failed: got 6 expected 0 install.c:9184: Test failed: file removed install.c:9329: Test failed: key not created

1 0

wine in the news in spain
by Dan Kegel 09 Jun '10

09 Jun '10

Saw this just now: http://www.osor.eu/news/es-zaragozas-move-to-complete-open-source-desktop-g… "Zaragoza's move to complete open source desktop going to plan by Gijs Hillenius — published on Jun 08, 2010 The move by the city of Zaragoza to an open source desktop is making good progress. All of the city's civil servants now use open source tools including Thunderbird, VLC, Firefox and OpenOffice. And this year some seven hundred of the city's 2800 desktop PCs will have seen their proprietary operating system replaced by the Linux open source alternative. ... "It is not possible to move all applications to the open source platform. For example tools for Computer Aided Design and Optical Character Recognition, can't be replaced by open source alternatives. But proprietary and open source software can live together. And if we really can't find an open source option, we resort to Virtualbox and Wine to provide users their proprietary application." ... Their web site does mention a bit about wine, too: http://zaragozaciudad.net/azlinux/2009/septiembre.php (autotranslated): "24/09/2009 How we use WINE ... Microsoft Access: Access we have hundreds of applications that lack of time and means we can not migrate to an Open Source environment. WINE can emulate many of them even though the code should be reviewed, compiled and compacted again. A particular case is still unresolved are the Access applications that generate a mail merge with Word documents. OCR: for now we have not found an efficient alternative to the use of OCR software that "emulate" Windows OCR software with WINE Transactional environment: the client for our transactional environment is old and only works for Windows environments so that the use of WINE has been indispensable In contrast we must also say that some applications could not be emulated with WINE as Presto or Nokia PC Suite. So far WINE has not been useful to emulate CAD applications. In conclusion we can say that WINE is a useful tool in some cases and allows us to move forward in the migration to Open Source environment as alternatives to proprietary software are available and the height of these." Hmm, I wonder what "Presto" is, and which CAD suites they use. - Dan

2 1

Re: Change a malloc() to a HeapAlloc()
by James McKenzie 09 Jun '10

09 Jun '10

Ultra two wrote: > --- > We use real names here. This patch probably will not be committed until it is resubmitted. James McKenzie

2 1

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel
by Joel Holdsworth 08 Jun '10

08 Jun '10

On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > programs/winecfg/Bg.rc | 19 +++++---- > programs/winecfg/Cs.rc | 19 +++++---- > programs/winecfg/Da.rc | 19 +++++---- > programs/winecfg/De.rc | 19 +++++---- > programs/winecfg/En.rc | 19 +++++---- > programs/winecfg/Es.rc | 19 +++++---- > programs/winecfg/Fi.rc | 19 +++++---- > programs/winecfg/Fr.rc | 19 +++++---- > programs/winecfg/Hu.rc | 19 +++++---- > programs/winecfg/It.rc | 19 +++++---- > programs/winecfg/Ja.rc | 19 +++++---- > programs/winecfg/Ko.rc | 19 +++++---- > programs/winecfg/Lt.rc | 19 +++++---- > programs/winecfg/Nl.rc | 19 +++++---- > programs/winecfg/No.rc | 19 +++++---- > programs/winecfg/Pl.rc | 19 +++++---- > programs/winecfg/Pt.rc | 32 +++++++------- > programs/winecfg/Ro.rc | 19 +++++---- > programs/winecfg/Ru.rc | 19 +++++---- > programs/winecfg/Si.rc | 19 +++++---- > programs/winecfg/Sv.rc | 19 +++++---- > programs/winecfg/Tr.rc | 19 +++++---- > programs/winecfg/Zh.rc | 38 +++++++++-------- > programs/winecfg/about.c | 88 +++++++++++++++++++++++++++++++++++++++++ > programs/winecfg/idb_wine.bmp | Bin 14614 -> 0 bytes > programs/winecfg/resource.h | 7 +++- > programs/winecfg/winecfg.rc | 4 +- > 27 files changed, 342 insertions(+), 226 deletions(-) > delete mode 100644 programs/winecfg/idb_wine.bmp Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?

4 5

Two enhancement requests for winetricks
by Jan Hoogenraad 08 Jun '10

08 Jun '10

I cannot access the login to Google (Google won't let me for some technical reason) , into http://code.google.com/p/winezeug/issues/list so I use this mail list to report 2 enhancement requests 1) Can winetricks also include a REMOVE script for each of the tricks ? It seems that a user is now advised to remove some (for the user often illogical) files in the windows directories. This is error prone, and lags the nice installation interface. 2) Can winetricks also include a status check for each of the tricks ? This could be as simple as checking if the files provided by wine have the latest wine time stamp and/or version signature. Alternately, a list of installed (by the UI selected) tricks can be provided. Each debugging request for wine states that I should remove all winetricks. However I have no way to tell, and no way to safely remove them. For example, my ~/.wine/drive_c/windows/sys*/* contains the files below, for which I suspect a wine trick, based on the time stamp. However, they may also be installed by some piece of windows software that I have installed. Thus, simply removing them does not make sense to me. Could somebody file this request in the issue database for me ? ------------------- 1032 2010-04-25 12:00 system32/ngen.exe 10204 2010-04-25 12:00 system32/view.exe 210420 2010-04-25 12:00 system32/cmdlgtst.exe 924432 2008-10-06 23:30 system32/MFC40.DLL 499712 2008-10-06 23:30 system32/msvcp71.dll 348160 2008-10-06 23:30 system32/msvcr71.dll 326656 2008-10-06 23:30 system32/MSVCRT40.DLL 492304 2008-10-06 23:30 system32/OLEAUT32.DLL 258352 2008-10-06 23:30 system32/unicows.dll 21936 2008-10-06 23:30 system32/help.exe 995383 2008-10-06 23:30 system32/MFC42.DLL 70656 2008-10-06 23:30 system32/MSVCIRT.DLL 195124 2008-10-06 23:30 system32/wcmd.exe 322832 2008-10-06 23:30 system/mfc30.dll 921872 2008-10-06 23:30 system/mfc40.dll 696 2003-12-04 16:07 system32/jetodbc.rsp 60224 2003-12-03 09:56 system32/odbcji32.dll 621104 2003-12-02 15:00 system32/mswstr10.dll 158256 2003-12-02 14:59 system32/msjint40.dll 354864 2003-11-12 13:17 system32/msjetoledb40.dll 559656 2003-11-12 13:17 system32/msrepl40.dll 326184 2003-11-12 13:16 system32/msexcl40.dll 1514024 2003-11-12 13:16 system32/msjet40.dll 354856 2003-11-12 13:16 system32/mspbde40.dll 285224 2003-11-12 13:16 system32/odbcjt32.dll 248360 2003-11-12 13:16 system32/msjtes40.dll 354856 2003-11-12 13:16 system32/msxbde40.dll 264744 2003-11-12 13:16 system32/mstext40.dll 27464 2003-11-12 13:15 system32/odexl32.dll 27464 2003-11-12 13:15 system32/odtext32.dll 27464 2003-11-12 13:15 system32/oddbse32.dll 27464 2003-11-12 13:15 system32/odfox32.dll 27464 2003-11-12 13:15 system32/odpdx32.dll 838240 2003-06-02 10:15 system32/mswdat10.dll 518752 2003-06-02 10:15 system32/msexch40.dll 428640 2003-06-02 10:15 system32/msrd2x40.dll 387680 2003-06-02 10:14 system32/expsrv.dll 322144 2003-06-02 10:14 system32/msrd3x40.dll 219744 2003-06-02 10:14 system32/msltus40.dll 60000 2003-06-02 10:14 system32/msjter40.dll 37472 2003-06-02 10:14 system32/vbajet32.dll 322832 2000-02-29 02:39 system32/MFC30.DLL -- Jan Hoogenraad

1 0

Re: gameux.dll implementation stub
by James Mckenzie 08 Jun '10

08 Jun '10

Mariusz Pluciński <vshader(a)gmail.com> wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm currently in the stage when stubs are ready to >start real implementation. > To prevent some of us out here from thinking you sent your patches to the wrong place, could you preface the subject of your messages like this one with RFC: That will allow us to run the patches and look closely at them to give them a critical review. Also, you can still submit your patches, it looks like Alexandre committed the first two and might commit the remaining three you submitted. Lastly, it looks like Release Candidate three for Wine 1.2 will be out on Friday and this may be the last one before the final release. James McKenzie

1 0

Re: Implement ID3DXConstantTable::GetConstantDesc
by testbot＠testbot.winehq.org 08 Jun '10

08 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2526 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1