July 2010 - Wine-devel - list.winehq.org

Re: [2/7] shlwapi/tests: Add tests for StrStrA.
by Detlef Riekenberg 19 Jul '10

19 Jul '10

Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in your Patchset. -- By by ... Detlef ___________________________________________________________ Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

2 1

Re: WineD3D: Only perform sRGB write correction on formats that advertise it
by Henri Verbeet 19 Jul '10

19 Jul '10

On 19 July 2010 17:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (((IWineD3DDeviceImpl *)shader->baseShader.device)->strided_streams.position_transformed) > + if (device->strided_streams.position_transformed) You might as well replace both instances.

1 0

Re: ole32: Implement cross-process drag and drop.
by Huw Davies 19 Jul '10

19 Jul '10

On Mon, Jul 19, 2010 at 01:58:07PM +0100, Huw Davies wrote: > --- > dlls/ole32/ole2.c | 199 ++++++++++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 168 insertions(+), 31 deletions(-) Please use the updated version which has fixed a typo in a comment (spotted by Detlef).

1 0

Re: misc: remove references to wineprefixcreate
by Alexandre Julliard 19 Jul '10

19 Jul '10

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/dinput8/dinput8_main.c b/dlls/dinput8/dinput8_main.c > index 87dd07b..416e355 100644 > --- a/dlls/dinput8/dinput8_main.c > +++ b/dlls/dinput8/dinput8_main.c > @@ -66,7 +66,7 @@ HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE hinst, DWORD dwVer > > hr = CoCreateInstance( &CLSID_DirectInput8, punkOuter, CLSCTX_INPROC_SERVER, riid, ppDI); > if(FAILED(hr)) { > - ERR("CoCreateInstance failed with hr = %d; Try running wineprefixcreate to fix it.\n", hr); > + ERR("CoCreateInstance failed with hr = %d; Try running `wineboot -u` to fix it.\n", hr); It doesn't make sense to recommend wineboot instead, users should never have to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] gameux: Add IClassFactory implementation
by Henri Verbeet 19 Jul '10

19 Jul '10

2010/7/18 Mariusz Pluciński <vshader(a)gmail.com>: > +static HRESULT WINAPI gameuxcf_QueryInterface( > + IClassFactory *iface, > + REFIID riid, > + LPVOID *ppobj ) > +{ > + if (IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_IClassFactory)) > + { > + IClassFactory_AddRef( iface ); > + *ppobj = iface; > + return S_OK; > + } > + > + FIXME("interface %s not implemented\n", debugstr_guid(riid)); > + return E_NOINTERFACE; > +} QueryInterface() is usually supposed to set "*ppobj" to NULL if the interface is not implemented by the object, any reason for not doing that here?

1 0

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (resent)
by Alexandre Julliard 19 Jul '10

19 Jul '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > @@ -3323,6 +3323,26 @@ HANDLE WINAPI GetCurrentProcess(void) > } > > /*********************************************************************** > + * GetLogicalProcessorInformation (KERNEL32.@) > + */ > +BOOL WINAPI GetLogicalProcessorInformation(void *buffer, PDWORD pBufLen) That's not the correct prototype. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name.
by Alexandre Julliard 19 Jul '10

19 Jul '10

David Hedberg <david.hedberg(a)gmail.com> writes: > --- > dlls/shell32/shell32.spec | 2 +- > dlls/shell32/shell32_main.h | 5 ----- > dlls/shell32/shlmenu.c | 2 +- > dlls/shell32/tests/shlfileop.c | 14 +++++++------- > dlls/shell32/undocshell.h | 4 ---- > include/shlobj.h | 6 ++++++ > 6 files changed, 15 insertions(+), 18 deletions(-) It should still be imported by ordinal, and you shouldn't need to change the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] shlwapi/ordinal: Partially implement SHGetShellKey
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3514 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found

1 0

Re: user32: Add a test showing that SetForegroundWindow() on a visible child of invisible parent does activate the parent an
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3510 Your paranoid android. === W2KPROSP4 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000900A6 fg 000600AE in hook HCBT_SETFOCUS === WXPPROSP3 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000900F4 fg 000400F2 in hook HCBT_SETFOCUS === W2K3R2SESP2 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000200C8 fg 00040102 in hook HCBT_SETFOCUS === WVISTAADM (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0002018A fg 00070202 in hook HCBT_SETFOCUS === W2K8SE (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070184 fg 000C0152 in hook HCBT_SETFOCUS === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2687: Test failed: GetActiveWindow() = 00000000 win.c:2687: Test failed: GetFocus() = 00000000 win.c:2713: Test failed: GetActiveWindow() = 00000000 win.c:2713: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2772: Test failed: GetActiveWindow() = 00000000 win.c:2772: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002E01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002F01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000901B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A01B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00060128 in hook HCBT_SETFOCUS === W7PROX64 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0007017C fg 002302AA in hook HCBT_SETFOCUS === W7PROX64 (64 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007017C fg 00000000002302AA in hook HCBT_SETFOCUS

1 0

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

On 17 July 2010 21:14, Misha Koshelev <misha680(a)gmail.com> wrote: > @@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void) > IDirect3DVertexBuffer9_Release(vertex_buffer); > } > > + /* Index buffer */ > + number_of_faces = box->lpVtbl->GetNumFaces(box); > + todo_wine ok( number_of_faces == 12, "Got result %u, expected 12\n",number_of_faces); > + > box->lpVtbl->Release(box); > } > I think this could easily have been part of the original test as well. It's good to send small patches that make sense on their own, but I don't think there's much to be gained by splitting up a patch that adds a test for a single function.

1 0