July 2010 - Wine-devel - list.winehq.org

Re: explorer: implement X session management
by Dmitry Timoshkov 30 Jul '10

30 Jul '10

Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * explorer: implement X session management Explorer should not have X11 as a dependency. This should be implemented inside of winex11.drv. -- Dmitry.

4 3

Re: [2/4] tools: enable .lnk thumbnailing in Gnome
by Alexandre Julliard 30 Jul '10

30 Jul '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > diff --git a/tools/Makefile.in b/tools/Makefile.in > index a9ec324..a0c9c99 100644 > --- a/tools/Makefile.in > +++ b/tools/Makefile.in > @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS) > $(INSTALL_DATA) $(SRCDIR)/l_intl.nls $(DESTDIR)$(datadir)/wine/l_intl.nls > $(INSTALL_DATA) $(SRCDIR)/wine.desktop $(DESTDIR)$(datadir)/applications/wine.desktop > -$(UPDATE_DESKTOP_DATABASE) > + gconftool --set -t string /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/command "wine winemenubuilder -t %i %o" || true > + gconftool --set -t bool /desktop/gnome/thumbnailers/application(a)x-ms-shortcut/enable "true" || true There needs to be a better way of doing this. Probably filing a bug with freedesktop.org is in order. -- Alexandre Julliard julliard(a)winehq.org

6 8

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.
by testbot＠testbot.winehq.org 30 Jul '10

30 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4052 Your paranoid android. === WXPPROSP3 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W2K3R2SESP2 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === WVISTAADM (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W2K8SE (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PRO (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PROX64 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PROX64 (64 bit hlsl) === Timeout

1 0

Re: [1/2] richedit: Return correct values when EM_SETTEXTMODE fails.
by testbot＠testbot.winehq.org 30 Jul '10

30 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4043 Your paranoid android. === W7PRO (32 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8

1 0

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)
by Stefan Dösinger 29 Jul '10

29 Jul '10

Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > DirectX 1 interface allowed creation of explicit back buffers, so move the > restrictive checks to DirectX 2+ implementations. It is still missing testing/handling of AddAttachedSurface

3 3

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.
by David Adam 29 Jul '10

29 Jul '10

On a real Vista windows box, tests fail at line 372: test failed: sin: Got 2: unexpected values line 385:test failed: cos: Got 2: unexpected values A+ David

1 0

Re: [PATCH 3/8] explorerframe/nstc: Add host window and create a treeview.
by David Hedberg 29 Jul '10

29 Jul '10

On Thu, Jul 29, 2010 at 9:19 PM, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/explorerframe/explorerframe_main.h | 3 + > dlls/explorerframe/nstc.c | 211 ++++++++++++++++++++++++++++++- > dlls/explorerframe/tests/nstc.c | 49 +++++++- > 3 files changed, 260 insertions(+), 3 deletions(-) > Sorry for the duplicate(s), gmail was (seemingly randomly) rejecting some of my mail.

1 0

Re: shell32: Initialize memory to zero in IShellItemArray constructor.
by Nikolay Sivov 29 Jul '10

29 Jul '10

On 7/29/2010 22:21, David Hedberg wrote: > This is needed as we might, if passed an invalid riid, > hit ::Release before we get to initialize array or item_count. > --- > dlls/shell32/shellitem.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c > index 5b01262..a7b2f29 100644 > --- a/dlls/shell32/shellitem.c > +++ b/dlls/shell32/shellitem.c > @@ -765,7 +765,7 @@ static HRESULT WINAPI IShellItemArray_Constructor(IUnknown *pUnkOuter, REFIID ri > if(pUnkOuter) > return CLASS_E_NOAGGREGATION; > > - This = HeapAlloc(GetProcessHeap(), 0, sizeof(IShellItemArrayImpl)); > + This = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IShellItemArrayImpl)); > if(!This) > return E_OUTOFMEMORY; > I don't see a reason for this. If you want to zero two remaining fields do it explicitly. Also this helper doesn't need WINAPI it seems.

2 1

Re: krnl386.exe: Fix last error check for DOS compatibility hack.
by Alexandre Julliard 29 Jul '10

29 Jul '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1092,7 +1092,7 @@ static BOOL INT21_CreateFile( CONTEXT86 *context, > winMode, winAttributes, 0 ); > /* DOS allows to open files on a CDROM R/W */ > if( winHandle == INVALID_HANDLE_VALUE && > - GetLastError()== ERROR_WRITE_PROTECT) { > + GetLastError() == ERROR_ACCESS_DENIED) { You should keep the old error too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.
by Alexandre Julliard 29 Jul '10

29 Jul '10

Octavian Voicu <octavian.voicu(a)gmail.com> writes: > @@ -190,25 +190,31 @@ static void test_audioclient(IAudioClient *ac) > hr = IAudioClient_GetMixFormat(ac, NULL); > ok(hr == E_POINTER, "GetMixFormat returns %08x\n", hr); > > + pwfx = (void *)0xdeadbeef; > hr = IAudioClient_GetMixFormat(ac, &pwfx); > ok(hr == S_OK, "Valid GetMixFormat returns %08x\n", hr); > > - trace("Tag: %04x\n", pwfx->wFormatTag); > - trace("bits: %u\n", pwfx->wBitsPerSample); > - trace("chan: %u\n", pwfx->nChannels); > - trace("rate: %u\n", pwfx->nSamplesPerSec); > - trace("align: %u\n", pwfx->nBlockAlign); > - trace("extra: %u\n", pwfx->cbSize); > - ok(pwfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE, "wFormatTag is %x\n", pwfx->wFormatTag); > - if (pwfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > + trace("pwfx: %p\n", pwfx); > + if (pwfx == (void *)0xdeadbeef) pwfx = NULL; > + if (pwfx) That's ugly, you should check the function result, not a magic pointer value. -- Alexandre Julliard julliard(a)winehq.org

2 1