July 2010 - Wine-devel - list.winehq.org

Re: msi: prevent cryptical errors
by Alexandre Julliard 29 Jul '10

29 Jul '10

André Hentschel <nerv(a)dawncrow.de> writes: > when accidently using the wrong path then > err:msi:MSI_OpenPackageW can't find L"asf.msi" > is more readable than > err:msi:copy_package_to_temp failed to copy package L"asf.msi" to L"C:\\users\\dawncrow\\Temp\\msi71e7.tmp" (2) Then you should fix that function to display a better error, instead of adding an extra check to every open. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Add a test for GetClassInfo, make it pass under Wine.
by Paul Vriens 29 Jul '10

29 Jul '10

On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: > + SetLastError(0xdeadbeef); > + ret = GetClassInfoEx(0, "static", NULL); Why not the explicit A-function? I see there is already an existing call in the current tests, but still. > + ok(!ret, "GetClassInfoEx() should fail\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected ERROR_NOACCESS, got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = GetClassInfoExW(0, staticW, NULL); > + ok(!ret, "GetClassInfoExW() should fail\n"); > + ok(GetLastError() == ERROR_NOACCESS || > + GetLastError() == ERROR_CALL_NOT_IMPLEMENTED, /* win9x */ Wouldn't broken() be more appropriate? -- Cheers, Paul.

2 1

Re: user32: Add a test for GetClassInfo, make it pass under Wine.
by testbot＠testbot.winehq.org 29 Jul '10

29 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4013 Your paranoid android. === W98SE (32 bit class) === class.c:932: Test failed: expected ERROR_NOACCESS, got -559038737 === WNT4WSSP6 (32 bit class) === class.c:932: Test failed: expected ERROR_NOACCESS, got -559038737 class.c:937: Test failed: expected ERROR_NOACCESS, got -559038737

1 0

Re: [2/3] shlwapi/ordinal: Partially implement SHGetShellKey
by testbot＠testbot.winehq.org 29 Jul '10

29 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4012 Your paranoid android. === W98SE (32 bit ordinal) === ordinal.c:616: Test failed: GetShellSecurityDescriptor should fail, got 0096F808 === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1789: Test failed: got 27 ordinal.c:1839: Test failed: got 27 ordinal.c:1847: Test failed: got 27 ordinal.c:1855: Test failed: got 38, length 39 ordinal.c:1866: Test failed: got 41 === W7PROX64 (32 bit ordinal) === ordinal.c:1783: Test failed: got 9 ordinal.c:1789: Test failed: got 26 ordinal.c:1804: Test failed: got 6 ordinal.c:1817: Test failed: got 9 ordinal.c:1825: Test failed: got 9 ordinal.c:1839: Test failed: got 26 ordinal.c:1847: Test failed: got 26 ordinal.c:1877: Test failed: got 19 ordinal.c:1888: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 9 ordinal.c:1789: Test failed: got 26 ordinal.c:1804: Test failed: got 6 ordinal.c:1817: Test failed: got 9 ordinal.c:1825: Test failed: got 9 ordinal.c:1839: Test failed: got 26 ordinal.c:1847: Test failed: got 26 ordinal.c:1877: Test failed: got 19 ordinal.c:1888: Test failed: got 22

1 0

Re: [1/3] shlwapi/tests: Fix some test failures on Win2000
by testbot＠testbot.winehq.org 29 Jul '10

29 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4011 Your paranoid android. === W98SE (32 bit ordinal) === ordinal.c:614: Test failed: GetShellSecurityDescriptor should fail, got 0096F808 === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1787: Test failed: got 27 ordinal.c:1837: Test failed: got 27 ordinal.c:1845: Test failed: got 27 ordinal.c:1853: Test failed: got 38, length 39 ordinal.c:1864: Test failed: got 41 === W7PROX64 (32 bit ordinal) === ordinal.c:1781: Test failed: got 9 ordinal.c:1787: Test failed: got 26 ordinal.c:1802: Test failed: got 6 ordinal.c:1815: Test failed: got 9 ordinal.c:1823: Test failed: got 9 ordinal.c:1837: Test failed: got 26 ordinal.c:1845: Test failed: got 26 ordinal.c:1875: Test failed: got 19 ordinal.c:1886: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1781: Test failed: got 9 ordinal.c:1787: Test failed: got 26 ordinal.c:1802: Test failed: got 6 ordinal.c:1815: Test failed: got 9 ordinal.c:1823: Test failed: got 9 ordinal.c:1837: Test failed: got 26 ordinal.c:1845: Test failed: got 26 ordinal.c:1875: Test failed: got 19 ordinal.c:1886: Test failed: got 22

1 0

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.
by Octavian Voicu 29 Jul '10

29 Jul '10

On Thu, Jul 29, 2010 at 3:57 AM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > Test results from test.winehq.org show that GetMixFormat consistently > fails on some configurations (usually for both capture and render, > sometimes only for capture). I also found out why GetMixFormat fails on my system (Kubuntu 10.04). OpenAL returns Pulse Audio as the default device, but pulseaudio daemon is not running (I removed the pulseaudio package from my system). MMDevEnum marks the pulseaudio device as the default one (for both render and capture), but alcOpenDevice / alcCaptureOpenDevice fail so the device is marked with state DEVICE_STATE_NOTPRESENT and openal_setformat is never called (which is the function responsible for writing the DeviceFormat registry key, used by GetMixFormat). A proper fix for the failed GetMixFormat test would be to fall back MMDevice_def_play / MMDevice_def_rec to the 2nd, 3rd, etc device from the default device list, and eventually to the first good device that is found (if all devices from the default device list fail). Is this OK? Octavian

1 0

siggraph / opengl BOF tonight
by Dan Kegel 29 Jul '10

29 Jul '10

Siggraph happens to be a stone's throw from my house this year, and one of the presenters was my frosh roommate :-), so I'm heading over to the opengl BOF to listen in. ( http://www.khronos.org/news/events/detail/siggraph-la-2010/#topengl_bof ) Email me or google chat me if you want me to try to find out anything...

1 1

Re: [6/6] urlmon/tests: Added some more test URIs (resend)
by testbot＠testbot.winehq.org 29 Jul '10

29 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4009 Your paranoid android. === WXPPROSP3 (32 bit uri) === uri.c:2169: Test failed: Expected http://google.com:00035 but got L"http://google.com:35" on uri_tests[60].str_props[2]. uri.c:2400: Test failed: Error: Expected http://google.com:00035 but got L"http://google.com:35" on uri_test[60]. uri.c:2856: Test failed: Error: Expected a length of 23 but got 20 on uri_tests[60].str_props[2]. === WVISTAADM (32 bit uri) === uri.c:2169: Test failed: Expected http://google.com:00035 but got L"http://google.com:35" on uri_tests[60].str_props[2]. uri.c:2400: Test failed: Error: Expected http://google.com:00035 but got L"http://google.com:35" on uri_test[60]. uri.c:2856: Test failed: Error: Expected a length of 23 but got 20 on uri_tests[60].str_props[2]. === W2K8SE (32 bit uri) === uri.c:2169: Test failed: Expected http://google.com:00035 but got L"http://google.com:35" on uri_tests[60].str_props[2]. uri.c:2400: Test failed: Error: Expected http://google.com:00035 but got L"http://google.com:35" on uri_test[60]. uri.c:2856: Test failed: Error: Expected a length of 23 but got 20 on uri_tests[60].str_props[2].

2 1

Re: shdocvw: Add French translation
by Paul Vriens 28 Jul '10

28 Jul '10

On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: > We now have an error on the translation site as you've merged 'New' and 'Window'. I know you brought this up on wine-devel but until agreed upon we should stick to the English one IMHO. -- Cheers, Paul.

3 3

Re: imm32: Set size of OSVERSIONINFOA before calling GetVersionExA
by Andrew Nguyen 28 Jul '10

28 Jul '10

On Wed, Jul 28, 2010 at 12:46 PM, Matt 'Murph' Finnicum <mattfinn(a)gmail.com> wrote: > This was causing console spam when I played Starcraft 2 (since > dwPlatformId was used uninitialized and thus was invalid). > > > > Hi Matt, Your patch causes declarations and code in the ImmGetVirtualKey function to be mixed, something that's only permitted in C99. Most likely you'll want to either initialize the size field in the OSVERSIONINFOA struct declaration or move the statement to an appropriate place after the declarations. Andrew

1 0