August 2010 - Wine-devel - list.winehq.org

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov 19 Jan '11

19 Jan '11

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Wine runs IE7!
by Hans Leidekker 26 Nov '10

26 Nov '10

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com 21 Oct '10

21 Oct '10

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Ongoing Debian package maintenance.
by Ben Klein 14 Oct '10

14 Oct '10

Hello everyone, My health has not improved at all since my last call for help with the Debian package management. I really need someone to take over from me, or at least some help to devise a new set of (semi-)automated build scripts. Any volunteers? Kind regards, Ben

5 11

Right-To-Left (RTL) languages and Wine
by Paul Vriens 29 Sep '10

29 Sep '10

Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main window will shows as normal LTR window layout with the menu's left justified as well. So eventhough the locale is set to Arabic it doesn't turn 'everything' into RTL. If we don't change the resource files for the RTL languages, that same logic will give us LTR Wine applications or am I wrong here? -- Cheers, Paul.

4 16

Wine without X? Failing in dlls/winex11.drv
by Gerald Pfeifer 19 Sep '10

19 Sep '10

Trying to build Wine on a new tester which initially had too few packages installed I ran into the following. In file included from bitblt.c:33: x11drv.h:30:22: error: X11/Xlib.h: No such file or directory x11drv.h:31:27: error: X11/Xresource.h: No such file or directory x11drv.h:32:23: error: X11/Xutil.h: No such file or directory x11drv.h:33:23: error: X11/Xatom.h: No such file or directory x11drv.h:44:21: error: X11/Xmd.h: No such file or directory x11drv.h:45:24: error: X11/Xproto.h: No such file or directory Indeed include/config.h has HAVE_X11_XLIB_H undefined since, well, all these headers indeed are missing. On the other hand, configure did not halt. In fact, configure did not even warn about this situation unlike it does in other cases. How to fix this? Should dlls/winex11.drv just not be built in such a case? Should configure error out? (We do have --without-x, too, though.) Anything else? Currently we do pass configure and then run into a compile failure later on. Gerald

3 3

Re: user32: warnings (around uninitialized variables).
by Alexandre Julliard 19 Sep '10

19 Sep '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -388,6 +388,8 @@ static int DIB_GetBitmapInfo( const BITMAPINFOHEADER *header, LONG *width, > *compr = header->biCompression; > return 1; > } > + > + *width = *height = 0; > ERR("(%d): unknown/wrong size for header\n", header->biSize ); > return -1; > } 0 is not valid for a bitmap, these should never be used in the error case. -- Alexandre Julliard julliard(a)winehq.org

2 1

autoconf 2.62 failure due to AS_VAR_IF
by Gerald Pfeifer 19 Sep '10

19 Sep '10

Using autoconf 2.62 on my primary test system I am getting: configure:26081: error: possibly undefined macro: AS_VAR_IF Indeed use of AS_VAR_IF appears relatively new, and it seems this may be similar to AS_VAR_APPEND where we have the following in configure.ac: dnl autoconf versions before 2.63b don't have AS_VAR_APPEND m4_ifdef([AS_VAR_APPEND],,[as_fn_append () { eval $[1]=\$$[1]\$[2]; } AC_DEFUN([AS_VAR_APPEND],[as_fn_append $1 $2])])dnl I assume we need something similar here, too? I am really far from an autoconf hacker -- is this something one of you could look into? Gerald

1 1

Re: Remove code which has been #if 0-ed for 11 years from DOSCONF_Device and DOSCONF_Install. (RESEND)
by Alexandre Julliard 19 Sep '10

19 Sep '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > An alternate patch would be putting #if 0 around the first occurrence > of loadhigh, too, but this code has been marked dead for more than 11 > years, so I really think it can / should go? It doesn't make sense to parse and not do anything with it. If you want to remove dead code you can remove essentially the entire file. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Use GCC's -Wlogical-op if possible
by Austin English 19 Sep '10

19 Sep '10

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18