August 2010 - Wine-devel - list.winehq.org

Re: mshtml: Send more informative messages to OleInPlaceFrame
by Jacek Caban 02 Aug '10

02 Aug '10

On 08/02/10 13:30, Alexander Nicolaysen Sørnes wrote: > These are displayed in Internet Explorer. > > > Alexander N. Sørnes > +LPCWSTR get_statustext(INT id, BOOL has_arg, LPCWSTR arg_in) WHy do you need has_arg argument? Isn't NULL arg_in enough to recognize no argument? +{ + static LPWSTR strings[NUM_STATUS_STRINGS]; + int index = id - IDS_STATUS_DONE; + DWORD maxlen = 255; + DWORD len = maxlen; + LPWSTR* p = &strings[index]; + + if(!*p) + { + if(has_arg) + len *= 3; + + *p = heap_alloc(len * sizeof(WCHAR)); + len = LoadStringW(hInst, id, *p, len); + len++; + + if(!has_arg) + *p = heap_realloc(*p, len * sizeof(WCHAR)); + } + + if(has_arg) + { + LPWSTR p2 = strings[index] + maxlen; + LPCWSTR arg = arg_in; + + if(!arg) + { + const WCHAR empty = 0; + arg = ∅ + ERR("Missing arg for message (id=%d) '%s'\n", id, debugstr_w(strings[index])); + } + snprintfW(p2, (maxlen * 2) - 1, strings[index], arg); + + return p2; + } + + return *p; +} This caching mechanism is broken and not thread safe. + LPCWSTR text = get_statustext(IDS_STATUS_DONE, FALSE, NULL); + IOleInPlaceFrame_SetStatusText(doc_obj->frame, text); The helper function should take care of calling SetStatusText. if(doc->frame) - IOleInPlaceFrame_SetStatusText(doc->frame, NULL /* FIXME */); + { + LPCWSTR text = get_statustext(IDS_STATUS_DOWNLOADINGFROM, TRUE, task->url); + CoTaskMemFree(task->url); + IOleInPlaceFrame_SetStatusText(doc->frame, text); + } You leak task->url here if doc->frame is NULL. Jacek

1 0

Re: [PATCH 4/4] jscript: Use generic property for Error.number.
by testbot＠testbot.winehq.org 02 Aug '10

02 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4153 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Fixed test crash on some win9x installations.
by testbot＠testbot.winehq.org 02 Aug '10

02 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4152 Your paranoid android. === WNT4WSSP6 (32 bit jscript) === jscript.c:388: Test failed: CoCreateInstance failed: 80040154 jscript.c:468: Test failed: CoCreateInstance failed: 80040154

1 0

Re: [PATCH 2/4] jscript: Use generic properties for NaN and Infinity implementation.
by testbot＠testbot.winehq.org 02 Aug '10

02 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4151 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: gdi32: Do not crash on an invalid pointer passed to AddFontMemResourceEx.
by testbot＠testbot.winehq.org 02 Aug '10

02 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4149 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: user32: Add a test for GetClassInfo, make it pass under Wine. Take 2.
by testbot＠testbot.winehq.org 01 Aug '10

01 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4119 Your paranoid android. === WNT4WSSP6 (32 bit class) === class.c:939: Test failed: expected ERROR_NOACCESS, got -559038737

1 0

New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive
by Dan Kegel 01 Aug '10

01 Aug '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: New verbs eadm eufonts gfw (aka xlive) ie8 safari secur32 Turning off MouseWarpOverride should be 'disable' not 'disabled'. (Issue 138) flash, ogg: support silent installs Lots of updates and minor fixes Dan Kegel: New verb glut Mathieu Malaterre: update cmake to 2.8.2 (issue 136)

2 2

New wisotool 20100731: 44 new verbs (aa3, apb, ... masseffect2_demo, ... zen_of_sudoku_demo_steam)
by Dan Kegel 01 Aug '10

01 Aug '10

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except it prompts for your password so it can mount the .iso file, and it prompts you to insert the disk if the .iso file is not found). Wisotool currently supports about 145 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. Thanks to everyone who contributed changes for this release. Not all of these games currently work under wine. Workarounds for specific Wine bugs are applied if available. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100618: Austin English If iso isn't present, offer to make one for the user Generic Steam installer New verbs: aa3 (America's Army 3) apb (All Points Bulletin) arx_fatalis_demo_steam bookworm_adventures_deluxe_demo_steam daytona_usa_evolutions dc2ba (Dora's Carnival 2: Boardwalk Adventure) eets_demo_steam fallout3_goty (Fallout 3: Game of the Year edition) ffxivbench (Final Fantasy XIV benchmark) fifa10 fifa10_demo joint_task_force_demo_steam longest_journey_demo_steam lost_planet_dx10_demo_steam lost_planet_dx9_demo_steam metro2033 multiwinia_demo_steam napoleon_total_war_demo_steam painkiller_demo_steam sega_rally_2 singularity ssdd2 (SpongeBob SquarePants Diner Dash 2 Demo) starcraft2 total_war_and_empire_demo_steam twfc (Transformers: War for Cybertron) wowtrial (World of Warcraft trial) zen_of_sudoku_demo_steam Dan Kegel: Allow specifying a .verb file on commandline New verbs: algodoo_demo deadspace lotsn (Monkey Island: Launch of the Screaming Narwhal) masseffect2_demo secondlife_beta Eleazar Galano: New verbs: cnc3_demo (Command and Conquer 3 Demo) cnc4 fifaonline3_beta hphbp, hphbp_demo (Harry Potter Half Blood Prince) lhp (Lego Harry Potter) moh_beta (Medal of Honor) nfsshift nfsshift_demo oblivion sf4bench Jon Angelo: New verb hod3_jp_demo Thai Nguyen: New verb smbx

1 0