August 2010 - Wine-devel - list.winehq.org

Re: avifil32: Fix EditStreamSetInfo wine checks
by testbot＠testbot.winehq.org 15 Aug '10

15 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4442 Your paranoid android. === W98SE (32 bit api) === No test summary line found === WNT4WSSP6 (32 bit api) === No test summary line found === W2KPROSP4 (32 bit api) === No test summary line found === W2K3R2SESP2 (32 bit api) === No test summary line found === WVISTAADM (32 bit api) === No test summary line found === W2K8SE (32 bit api) === No test summary line found === W7PRO (32 bit api) === No test summary line found === W7PROX64 (32 bit api) === No test summary line found === W7PROX64 (64 bit api) === Timeout

1 0

Re: [2/2] ws2_32, WS2_sendto: Avoid error when sending zero byte buffer (try 2)
by Mike Kaplinskiy 14 Aug '10

14 Aug '10

Several things: - Don't set errno. For good practice it's more or less read-only. - All the tests have to pass after each patch, so if your tests fail (which they probably should) without your patch, add todo_wine and then remove them in the followup patch (or just send the tests second). - The tests you provided pass without this patch so I'm not convinced that your fix is necessary. errno 107 = ENOTCONN, so while 0 length sends work just fine, they only work when non-zero sends also work. i.e. invalid sends get turned to valid sends on windows when the length is 0. It might be better to test calling WSASendTo with 0 length on unconnected tcp (or udp if tcp doesn't work) sockets. Good luck, Mike. On Sat, Aug 14, 2010 at 5:45 AM, Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> wrote: > This solves #19397. > > > > >

1 0

Re: [(try 2) 02/11] d3d10: Implement D3D10CreateBlob().
by Stefan Dösinger 13 Aug '10

13 Aug '10

Am 11.08.2010 um 21:51 schrieb Rico Schüller: > --- a/dlls/d3d10/d3d10_private.h > +++ b/dlls/d3d10/d3d10_private.h > @@ -212,6 +212,17 @@ struct d3d10_effect > struct d3d10_effect_technique *techniques; > }; > > > +extern const struct ID3D10BlobVtbl d3d10_blob_vtbl DECLSPEC_HIDDEN; Do you need the declaration of the vtable in the header? As far as I can see you're not using it anywhere outside d3d10_main.c.

3 2

Fwd: Should we expect Liberation fonts to be installed?
by Paul "TBBle" Hampson 12 Aug '10

12 Aug '10

Sorry, I failed at Gmail again. >_< ---------- Forwarded message ---------- From: Paul "TBBle" Hampson <Paul.Hampson(a)pobox.com> Date: 12 August 2010 13:52 Subject: Re: Should we expect Liberation fonts to be installed? To: Scott Ritchie <scott(a)open-vote.org> On 8 August 2010 13:02, Scott Ritchie <scott(a)open-vote.org> wrote: > On 08/03/2010 01:57 PM, Scott Ritchie wrote: >> I was looking through our fairly large collection of open font bugs and >> realized that things might be a lot simpler if we took some opinionated >> positions and just declared certain fonts to be dependencies and >> expected all packagers to provide them. >> >> This is similar to bundling our own Tahoma, except much less work. >> >> >> This bug, for instance, prevents Photoshop from working unless there is >> an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 >> >> Wine doesn't seem to respect system-level fontconfig aliases, so even >> though Liberation Sans is installed on the system Photoshop won't try to >> use it in place of Arial. >> >> But if however we assumed that Liberation Sans was installed, we could >> make things much better: a link/substitution for Arial->Liberation Sans >> could be provided in our own registry (and similarly for Times New Roman >> and Courier). An alternative is to simply symlink to the Liberation >> Fonts in /usr/share/wine/fonts as though they were our own shipped fonts >> (like Tahoma). >> >> This would make Photoshop think Arial was present and keep it >> functional. Ideally the real Arial would be displayed if it was >> installed (eg through winetricks corefonts or by installing the >> distro-provided corefonts package). >> >> >> A related question is whether to show "Arial" in the list of fonts (eg >> notepad) when we're actually just providing a substituted Arial. My >> inclination says no, however I'm not sure how it works internally and >> what an application would expect. >> > > Assuming for a moment this is a good idea, what's the best > implementation? My inclination is to say some registry font links, but > I'm not completely familiar with how that works. > > Will font links in the registry be ignored when the real font is present? (Wine-specific) Font Replacements will be ignored when the real font is present. Those're the ones in HKCU\Software\Wine\Fonts\Replacements and probably the ones you want to use. (Which could be supplanted or supplemented by working FontConfig alias support...) (GDI) Font Links (ie. the same registry entries Windows uses) are fallbacks for missing glyphs. Those're the ones in HKLM\SOFTWARE\Microsoft\FontLink\SystemLink Font Substitutes _probably_ don't get ignored if a real font with that name exists. Those're the ones in HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes and they're pretty purpose-specific. The only entries we want for them in Wine are the ones described at http://blogs.msdn.com/b/michkap/archive/2005/03/20/399322.aspx (which should probably be the default in Wine anyway, at least the Tahoma entry.) (Which by-the-by highlights a mistake in my previous suggestion towards bug 13829) -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com On 12 August 2010 13:52, Paul "TBBle" Hampson <Paul.Hampson(a)pobox.com> wrote: > (Wine-specific) Font Replacements will be ignored when the real font > is present. Those're the ones in HKCU\Software\Wine\Fonts\Replacements > and probably the ones you want to use. (Which could be supplanted or > supplemented by working FontConfig alias support...) To be clear, I think the best first-step solution for this bug is for Wine's Font Replacements code to read the aliases from FontConfig as well as its own registry keys when building its list. (The latter being taken over the former) That would make the problem magically go away on systems that do include appropriately-substitutable fonts. -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com

2 2

Re: Windows Imaging Component
by Roderick Colenbrander 12 Aug '10

12 Aug '10

On Thu, Aug 12, 2010 at 4:54 AM, Georgij Kirichenko <kirichenkoga(a)gmail.com> wrote: > This patch add support for decoding Dds, Ppm(and pgm, pbm) and Tga files th > Windows Imaging Component. Each format you are adding requires its own patch. > This patch use dynamic linked FreeImage library, but i'am can't static link > this library. First of all, I'm not so sure we want to use FreeImage. The initial thing about which I'm not sure is the license. You can use it under either a commercial license or under the GPL. The last one at least is usable for us as it would make all of Wine GPL when you link to it. I'm not sure about the 'free image public license terms'. It is not something like a BSD license, but more complicated. Someone would have to look at it whether that would even be usable (commercial versions like Crossover would have issues). >From what I remember TGA, and the PPM family are at least easy (not sure about DDS though, but I believe it is easy as well). If there are good standalone libs like libjpeg, libpng and friends for such libraries which are either BSD or LGPL licensed (or something similar that would be fine). We might also want to do them ourselves if we wanted (and they are relatively trivial). Lets wait for what others are saying. Roderick

1 1

Re: Windows Imaging Component
by Kirill K. Smirnov 12 Aug '10

12 Aug '10

1 0

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.
by David Adam 12 Aug '10

12 Aug '10

Hello, some comments about this patch + if (hr != S_OK) return FALSE; + else return TRUE; could be simplified as return SUCCEEDED(hr); + trace("HRESULT when creating instance (%x)\n", hr); Since tests are assumed to pass, we dont care about debug informations. So, traces are useless in tests. [It is my opinion. Better developpers could give an opposite opinion] + todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not set\n"); Why is this cast useful? A+ David 2010/8/9 Austin Lund <austin.lund(a)gmail.com> > > > > >

6 9

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
by Vitaliy Margolen 12 Aug '10

12 Aug '10

On 08/11/2010 08:58 PM, Austin Lund wrote: > > > +static BOOL test_InitAudio(void) > +{ > + hr = IDirectMusicPerformance8_InitAudio(idmusicperformance,NULL,&pDirectSound,NULL,1,128,0x3f,NULL); > + if (hr != S_OK) return FALSE; > + else return TRUE; > +} Please put spaces after comas, as you do in the rest of the file. What are those magic numbers? Please use constants. If they are missing, add them to appropriate header file first. Same thing with return as in prior function.. > +static void test_PChannelInfo(void) Already covered in another thread. Vitaliy.

2 2

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
by James McKenzie 11 Aug '10

11 Aug '10

Austin Lund wrote: Why the try2? It is always nice to put why you are doing this in the git commit notes. AJ is on vakay and will not be back until next week so there are NO reviews ongoing this week, except developer peer ones. James McKenzie

2 1

Re: [PATCH] qmgr/tests: Detect, when the service is disabled
by testbot＠testbot.winehq.org 11 Aug '10

11 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4405 Your paranoid android. === W98SE (32 bit qmgr) === qmgr.c:46: Test failed: CoCreateInstance failed: 80040154

1 0