August 2010 - Wine-devel - list.winehq.org

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 3)
by testbot＠testbot.winehq.org 04 Aug '10

04 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4245 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: regedit: Added Hebrew translation
by Alexandre Julliard 03 Aug '10

03 Aug '10

Yaron Shahrabani <sh.yaron(a)gmail.com> writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > + WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile at least the files you are changing, if you can't do a full build. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 2/4] include/shlobj.h: SHILCreateFromPath takes both CSTR and WSTR
by Alexandre Julliard 03 Aug '10

03 Aug '10

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This is different from the latest PSDK, but Wine's SHILCreateFromPath > accepts both types, so we shouldn't make compiler warnings about it. If there are warnings with the Windows headers there should be warnings with the Wine ones too. -- Alexandre Julliard julliard(a)winehq.org

1 0

wiki slightly broken still?
by Dan Kegel 03 Aug '10

03 Aug '10

Creating new wiki pages seems broken today...

9 15

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)
by Vitaliy Margolen 03 Aug '10

03 Aug '10

On 08/02/2010 05:48 PM, Jeff Cook wrote: > Moved check to conform with C90. > > + if (mastelem) { > + /* Master control */ ... > + } else { Please follow file's format. Vitaliy

1 0

Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)
by Vitaliy Margolen 03 Aug '10

03 Aug '10

On 08/02/2010 05:50 PM, Jeff Cook wrote: > - > + You adding trailing spaces here. > + } else { > + default_used = 1; > } > Please follow files' format - curly braces go on separate line. Also you don't need braces for one line "else". Vitaliy.

1 0

Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)
by Vitaliy Margolen 03 Aug '10

03 Aug '10

On 08/02/2010 05:49 PM, Jeff Cook wrote: > --- > dlls/winealsa.drv/waveinit.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > - int scan_devices = (fixedpcmdev == -1); > + /* we always want to scan_devices; otherwise, if a default is set and the > + appropriate registry keys are not set, only the default device will be seen > + by wine. This is undesirable, for instance, if you have separate cards for > + capture and playback, like a USB microphone for capture */ > + int scan_devices = 1; Please make it possible to force old behavior via registry. This was done for a reason - some devices were crashing during initialization, some were taking way too long to initialize. Vitaliy

1 0

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc
by Henri Verbeet 03 Aug '10

03 Aug '10

On 31 July 2010 08:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This workaround isn't ideal, Yeah, I don't think this is much of an improvement.

4 4

Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)
by Alexandre Julliard 03 Aug '10

03 Aug '10

David Hedberg <david.hedberg(a)gmail.com> writes: > +static LRESULT resize_namespacetree(NSTC2Impl *This) > +{ > + RECT rc; > + TRACE("%p\n", This); > + > + GetClientRect(This->hwnd_main, &rc); > + SetWindowPos(This->hwnd_tv, HWND_TOP, rc.left, rc.top, > + rc.right, rc.bottom, SWP_SHOWWINDOW); Again, that's not the correct usage of SetWindowPos. You don't want to show or activate it. What you probably want is MoveWindow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GetVolumeInformationA: please test this on MS-Windows
by Andrew Eikum 03 Aug '10

03 Aug '10

On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Andrew, > >>Run on a Win98SE VM. The E drive is a CDROM drive. > Thank you very much for the result. I added the broken(GetLastError()) for Win9x > based on your data. > > Now is your chance to repeat the test with > https://testbot.winehq.org/JobDetails.pl?Key=4014 > (either as .patch file or the binary from testbot). > This is valuable because testbot skips most new tests, lacking another drive, > giving no proof that the fixed patch indeed works without errors on win9x. > If it fails, please report to wine-devel as I already submitted the new patch. Hi Jörg, No failures with the testbot executable. Run under the same Win98SE VM, again from the E: drive. Andrew

3 7