September 2010 - Wine-devel

Re: [msxml3/tests] Step to the next item on failure as well
by testbot＠testbot.winehq.org 15 Sep '10

15 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property
by Paul Vriens 15 Sep '10

15 Sep '10

On 09/14/2010 07:20 AM, Nikolay Sivov wrote: > Properly set default value for SelectionLanguage property > Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account) shows that the reports are filled (12000+ lines) with: domdoc.c:5649: Tests skipped: can't create CLSID_DOMDocument40 instance This makes sure that the reports are not even considered valid: wine:/home/winehq/opt/winetest/queue/errvyhFy$ more error dissect:error:/home/winehq/opt/winetest/queue/errvyhFy: report reached file limit (runaway test?) -- Cheers, Paul.

1 1

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword
by Dmitry Timoshkov 15 Sep '10

15 Sep '10

Marcus Meissner <marcus(a)jet.franken.de> wrote: > + if (!unk) { > + FIXME("hr was %d, but unk is NULL?\n", hr); > + return E_FAIL; > + } IDropTarget_QueryInterface() should be fixed instead. -- Dmitry.

3 5

[PATCH] shell32: use flexible arrays to avoid fortify failures
by Mike Frysinger 15 Sep '10

15 Sep '10

Newer versions of gcc/glibc with fortify checks enabled will complain about the handling of the network's szNames field. Currently it is always defined with a length of one which means writing more then a single byte will trigger: In function 'strcpy', inlined from '_ILCreateEntireNetwork' at dlls/shell32/pidl.c:1762:15: warning: call to __builtin___strcpy_chk will always overflow destination buffer and then at runtime, we hit an abort(). Since this field is really serving as the header to an arbitrary buffer, using a flexible array instead should solve the issue. Signed-off-by: Mike Frysinger <vapier(a)gentoo.org> --- note: i couldnt find a statement of what C standard wine aims for. if it is attempting pre-c99, then this will have to be done differently. perhaps introducing a project-wide define like "VARARRAY" which expands into [] for c99+ and [1] for older ... dlls/shell32/pidl.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/pidl.h b/dlls/shell32/pidl.h index 3dbfaa6..bbfacef 100644 --- a/dlls/shell32/pidl.h +++ b/dlls/shell32/pidl.h @@ -172,12 +172,12 @@ typedef struct tagPIDLDATA struct tagFileStruct file; struct { WORD dummy; /*01*/ - CHAR szNames[1]; /*03*/ + CHAR szNames[]; /*03*/ } network; struct { WORD dummy; /*01*/ DWORD dummy1; /*02*/ - CHAR szName[1]; /*06*/ /* terminated by 0x00 0x00 */ + CHAR szName[]; /*06*/ /* terminated by 0x00 0x00 */ } htmlhelp; struct tagPIDLCPanelStruct cpanel; struct tagValueW valueW; -- 1.7.2

3 4

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK
by Dmitry Timoshkov 15 Sep '10

15 Sep '10

Vladimir Panteleev <thecybershadow(a)gmail.com> wrote: > diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c > index aac8a4d..ee99710 100644 > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -1221,6 +1221,11 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg ) > else if (DC_HASDEFID == HIWORD(dw = SendMessageW (hwndDlg, DM_GETDEFID, 0, 0))) > { > HWND hwndDef = GetDlgItem(hwndDlg, LOWORD(dw)); > + if (!hwndDef && LOWORD(dw)==IDOK) > + { > + SendMessageW( hwndDlg, WM_COMMAND, IDOK, 0 ); > + return TRUE; > + } > if (!hwndDef || !IsWindowEnabled(hwndDef)) > return TRUE; > SendMessageW( hwndDlg, WM_COMMAND, MAKEWPARAM( LOWORD(dw), BN_CLICKED ), It would be cleaner to use an existing SendMessage() instead of introducing a duplicate. -- Dmitry.

2 4

Re: msxml3: Implement property SelectionNamespaces for XPath (try #3)
by testbot＠testbot.winehq.org 15 Sep '10

15 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5234 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

WineAPI wiki progress.
by Max TenEyck Woodbury 14 Sep '10

14 Sep '10

The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Please take a look at it and tell me if you think the content is useful and how it could be improved. None of the analysis of the file content is in place. I plan to start with analysis of the '.spec' files. That should make some of the information on the API available. - Max

1 0

Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.
by Henri Verbeet 14 Sep '10

14 Sep '10

On 14 September 2010 20:28, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/secur32/schannel.c | 30 ++++++++++++++++++++---------- > 1 files changed, 20 insertions(+), 10 deletions(-) > Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good to have a dependency on mail.google.com.)

2 1

Re: [PATCH 1/2] secur32: Improved error handling in schan_DecryptMessage.
by Henri Verbeet 14 Sep '10

14 Sep '10

On 14 September 2010 20:27, Piotr Caban <piotr(a)codeweavers.com> wrote: > + else if (ret == GNUTLS_E_DECRYPTION_FAILED) ... > + return SEC_E_MESSAGE_ALTERED; Are those really the same?

2 1

Re: secur32: Reorganize data returned by schan_DecryptMessage.
by Juan Lang 14 Sep '10

14 Sep '10

Hi Piotr, - TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", + FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? --Juan

2 1