September 2010 - Wine-devel

Console issues in recent git
by Jerome Leclanche 14 Sep '10

14 Sep '10

Anyone else's terminal emulators really acting up since the last git batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if there is a wine process running, until it's killed. This is probably a konsole bug, but still... CC eric. -- J. Leclanche

9 22

Desktop window doesn't span entire screen in multi-monitor setup?
by Damjan Jovanovic 14 Sep '10

14 Sep '10

$ xrandr -q Screen 0: minimum 320 x 200, current 2732 x 768, maximum 8192 x 8192 GetWindowRect(GetDesktopWindow(), &r); r.left, r.top, r.right, r.bottom are: 0 0 1366 768 This causes WindowFromPoint() to fail (returns NULL) when the point is on my second monitor, which causes X11 -> Wine drag and drop to also fail since it uses WindowFromPoint(). It seems wineserver doesn't allow the point to fall outside the window from which the search starts, which causes the point to be rejected because the desktop window doesn't contain it. What's the problem here, that the desktop window is too small, or that the window search criteria are too strict? Damjan Jovanovic

2 1

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers
by Chris Robinson 14 Sep '10

14 Sep '10

On Monday, September 13, 2010 12:55:43 pm Owen Rudge wrote: > + if (*v < -1.0f) d = -128; > + if (*v < 0.0f) d = *v * 128.0f; > + if (*v >= 0.0f) d = *v * 127.0f; > + if (*v > 1.0f) d = 127; The way these checks are written out can cause problems, particularly with the first two because the if(*v < 0.0f) occurs after the if(*v < -1.0f) check, so it won't properly clamp values below -1.0. Something like this: if (*v < -1.0f) d = -128; else if (*v < 0.0f) d = *v * 128.0f; else if (*v > 1.0f) d = 127; else if (*v >= 0.0f) d = *v * 127.0f; should do fine (along with the 16- and 32-bit variants; the 24-bit one looks fine). You also don't need to keep the float as a pointer, though I imagine the optimizer can handle that.

2 4

Re: [1/2] windowscodecs: support ICO files with embedded PNGs (try 2)
by Vincent Povirk 14 Sep '10

14 Sep '10

I'm in the process of reorganizing the ICO decoder to address bug 24301 and take advantage of the rest of WIC. I'd prefer to leave this out until then. It's hard enough as it is, without having to keep PNG icons working too. On Tue, Sep 14, 2010 at 12:20 AM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * windowscodecs: support ICO files with embedded PNGs > > Try 2 uses IWICStream regions instead of reading the file into memory. > > Damjan Jovanovic > > > >

2 1

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property
by testbot＠testbot.winehq.org 14 Sep '10

14 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5209 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WXPPROSP3 (32 bit domdoc) === Timeout === W2K3R2SESP2 (32 bit domdoc) === Timeout === WVISTAADM (32 bit domdoc) === Timeout === W2K8SE (32 bit domdoc) === Timeout === W7PRO (32 bit domdoc) === Timeout === W7PROX64 (32 bit domdoc) === Timeout === W7PROX64 (64 bit domdoc) === Timeout

1 0

Re: [3/4] msxml3: Fix IXMLDOMNode::get_namespaceURI() for empty URIs
by testbot＠testbot.winehq.org 14 Sep '10

14 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5208 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/4] msxml3: Fix IXMLDOMNode::get_prefix() for empty prefix
by testbot＠testbot.winehq.org 14 Sep '10

14 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5207 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [1/4] msxml3: Support elements with namespaces
by testbot＠testbot.winehq.org 14 Sep '10

14 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5206 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/2] ws2_32: Fail when select is called with an invalid fd.
by Mike Kaplinskiy 14 Sep '10

14 Sep '10

On Sun, Sep 12, 2010 at 5:23 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > > @@ -3193,6 +3193,10 @@ int WINAPI WS_select(int nfds, WS_fd_set *ws_readfds, > return SOCKET_ERROR; > } > > + for (i=0; i<count; i++) > + if (pollfds[i].fd == -1) > + return SOCKET_ERROR; You're leaking pollfds here. (As a nitpick - braces for for's that contain more than one line are nice) Mike.

1 0

Re: [Wine] [1.2]-S.T.A.L.K.E.R.:SoC - Remapping keys?
by Jesse Palser 14 Sep '10

14 Sep '10

On 9/9/10 8:48 AM, Jesse Palser wrote: > > [1.2]-S.T.A.L.K.E.R.:SoC - Remapping keys? > > Hi, > > I am running Wine 1.2 on Ubuntu 10.04 32bit Linux. > > I wish to remap the movement keys in: > S.T.A.L.K.E.R.: Shadow of Chernobyl, > but when I try, it always maps "Pause" ? You will have to ask this in the Steam support forums. Wine does not activate or deactivate keys. James McKenzie ------------------------------------------------------------------------------------------------------- Hi, I am not talking about activating/deactivating registration keys. I am talking about the control mapping of keyboard keys in the game. Currently when I try to remap a keyboard key in this game, it always selects "Pause" regardless of which keyboard key I press. I would like to map the arrow key for movement, and can not do that. Any ideas? Using Wine 1.2 on Ubuntu 10.04 32bit Linux. Thanks! Jesse

2 1