October 2011 - Wine-devel - list.winehq.org

Re: d3dx9_36: Buffer size does not depend on the size of the created buffer
by Henri Verbeet 17 Oct '11

17 Oct '11

This is because the buffer is supposed to be created by D3DXCreateBox().

1 0

Re: riched20: Prevent setting an invalid default format rect
by Thomas Faber 17 Oct '11

17 Oct '11

Hey, On 2011-10-15 12:10, Thomas Faber wrote: > The patch fixes this by adding checks to ME_SetDefaultFormatRect to > use the minimal rectangle that is still valid in this case. I've made some tests (will post them later) and it turns out this rectangle is also invalid in Windows in this case, so this is not the correct solution. Please ignore the patch, I will try to come up with a better one soon. Regards, Tom

1 0

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen 15 Oct '11

15 Oct '11

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

Fwd: [Announce] Google Code-in 2011
by Austin English 14 Oct '11

14 Oct '11

---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Fri, Oct 14, 2011 at 15:28 Subject: [Announce] Google Code-in 2011 To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, We’re pleased to announce that we are planning to run the Google Code-in contest again this November. We had a successful contest last year with 20 mentoring organizations and 361 participating students. We will again be giving 13-17 year old students around the world an opportunity to get involved with open source projects doing tasks ranging from documentation to outreach to coding programs. We’re looking forward to a fun contest this year and hope you’ll consider participating as a mentor and/or org admin yourself, and spreading the word to friends, family, and colleagues about the program. Please check out the timeline [0] for more details on the program. We will soon be accepting applications for open source organizations to become mentoring organizations for this year’s contest. There will be a separate email thread to this list inviting you to apply to be a mentoring organization on Monday, 17 October. Please take some time to discuss with your respective organizations about whether you feel you have the time and mentor capacity to participate this year. We won’t kid you: working with teengers can be demanding. It’s important that your mentors/org be prepared to put the time in over the holiday, but if you participate you will all have the satisfaction of sharing your project and your passion for open source with a truly amazing collection of young people, and getting them started in our community. We've put together an Information Page [1] for this year's program to give you some lessons learned from last year's program. *Please* look this over before deciding to apply to participate in the program. We encourage you to join the Google Code-in contest discussion list [2] and announcement list [3]. Please see our blog post [4] for further details and contact us directly if you have specific questions that aren’t answered in the FAQs [5]. [0] - http://www.google-melange.com/gci/events/google/gci2011 [1] - http://code.google.com/p/google-code-in/wiki/GCIAdminMentorInformation [2] - http://groups.google.com/group/gci-discuss [3] - http://groups.google.com/group/gci-announce [4] - http://google-opensource.blogspot.com/2011/10/google-code-in-are-you-in.html [5] - http://www.google-melange.com/gci/document/show/gci_program/google/gci2011/… Cheers, The Google OSPO Team -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en. -- -Austin

1 0

Re: [6/6] wined3d: Catch nop palette updates
by Henri Verbeet 14 Oct '11

14 Oct '11

This looks questionable. Which applications does this help?

2 3

Re: 79927: [3/3] cmd: Make RENAME work for read-only files
by Dan Kegel 14 Oct '11

14 Oct '11

gcc complains here: builtins.c: In function 'WCMD_rename': builtins.c:1782:9: error: unused variable 'attribs' [-Werror=unused-variable] On Fri, Oct 14, 2011 at 2:27 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/383 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_2 > > Errors: > builtins.c: In function 'WCMD_rename': > builtins.c:1782:9: error: unused variable 'attribs' [-Werror=unused-variable] > make[1]: *** [builtins.o] Error 1 > make: *** [programs/cmd] Error 2 > make: *** Waiting for unfinished jobs.... > >

2 1

Re: ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released. (try 3)
by Saulius Krasuckas 14 Oct '11

14 Oct '11

Hello, Octavian. * On Tue, 11 Oct 2011, Octavian Voicu wrote: > > try 3: > - fix test failure by moving error check from *_DeleteAttachedSurface to > ddraw_surface_delete_attached_surface, after another check (thanks Henri). > > try 2: > - use IUnknown_Release(attached_iface) instead of manual dispatch, > as suggested by Henri; > - change type of attached_iface from void* to IUnknown* to reflect > fact that it's a pointer to an interface; > - add test to show that attaching a surface only attaches a specific > interface and return error if DeleteAttachedSurface is called with > another interface than the attached one (instead of detaching the > surface anyway). > > Fixes a bug that causes a stencil buffer leak in the game The Longest Journey. > Problem can be seen in the console output log attached to bug #11819. > This patch doesn't fix the original bug, but now game exits cleanly. > > The root of the problem is that when releasing a surface, its attached > surfaces are detached using IDirectDraw7_DeleteAttachedSurface, regardless > of what interface was originally attached. I am troubled by seeing (via test.winehq.org) your ddraw:refcount tests to account only results for "VMware SVGA 3D" adapter/driver (and only those with 3D acceleration disabled), I guess. But if this driver is 3D-enabled or just present real physical adapter (with no 3d acceleration) then ddraw:refcount contains 6 static failures such as: refcount.c:214: Test failed: AddAttachedSurface returned 8876000a refcount.c:235: Test failed: AddAttachedSurface returned 8876000a refcount.c:237: Test failed: Got refcount 1, expected 2 refcount.c:262: Test failed: AddAttachedSurface returned 8876000a refcount.c:275: Test failed: AddAttachedSurface returned 8876000a refcount.c:277: Test failed: Got refcount 1, expected 2 refcount: 112 tests executed (0 marked as todo, 6 failures), 0 skipped This relation can be easily tracked by looking at d3d9:visual or (if they aren't present) at opengl32:opgenl tests. Eg. failures occuring here: * Intel(R) 82865G Graphics Controller http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/xp_af-… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/xp_af-… * NVIDIA GeForce FX 5200 http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_s… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_s… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/xp_s2-… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/xp_s2-… * ATI Radeon HD 4800 Series (telling it has no IDirect3D[7] support for DDraw) http://test.winehq.org/data/a843acef5567bc30901612ce5013da543259b21b/win7_w… http://test.winehq.org/data/a843acef5567bc30901612ce5013da543259b21b/win7_w… * VMware SVGA II http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/2000_f… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/2000_f… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/2000_f… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/2000_f… * VMware SVGA 3D (telling it has not IDirect3D[7] support for DDraw) http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_f… http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_f… All other cases succeed. AFAICS all of them represent the only driver (with 3D support turned off): * VMware SVGA 3D http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_w… visual.c:194: Driver string: "vm3dum.dll" visual.c:195: Description string: "VMware SVGA 3D (Microsoft Corporation - WDDM)" visual.c:197: Device name string: "\\.\DISPLAY1" visual.c:199: Driver version 7.14.1.40 visual.c:12627: Tests skipped: Creating the device failed visual: 5 tests executed (0 marked as todo, 0 failures), 1 skipped. with following results: http://test.winehq.org/data/d0c38ece9db657431559024abb34285cd8b717b6/win7_w… refcount: 121 tests executed (0 marked as todo, 0 failures), 0 skipped. IMHO, it would be nice to conform to real world configuration. Wish you best luck with fixing your tests:) S.

3 2

Re: [2/6] wined3d: Pass the destination surface to blitters
by Henri Verbeet 14 Oct '11

14 Oct '11

On 13 October 2011 01:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, struct wined3d_surface *surface) > + static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, struct wined3d_surface *src, > + const struct wined3d_surface *dst) Whitespace error. The parameter you're adding isn't used anywhere, not even in the same patchset. Perhaps more important though is the point that "set_shader" is pretty much the wrong interface for blitters and should go away. Note that the blitter interface is something I'm actually working on as part of the ddraw work, it's just that other things keep coming up.

2 3

One more review: wineps.drv: Implement PS_USERSTYLE on printers
by Daniel Santos 14 Oct '11

14 Oct '11

Is anybody intimately familiar with the life cycle of device context and pens? I don't necessarily mean that you went to bed with either of them, but that would be OK too. I mean, this is the 2010s, we're supposed to be modern here. Specifically, I want to make sure I'm not leaking my dynamically allocated memory block. This block is allocated when the pen is selected (not when it's created). Thanks in advance Daniel

1 1

Re: 79921: ntdll: Move adding VPROT_READ for Solaris to the same place where it's done for FreeBSD. Take 2.
by Dan Kegel 14 Oct '11

14 Oct '11

Fails to apply here: $ patch -p1 < vprot.patch patching file dlls/ntdll/virtual.c Hunk #1 FAILED at 187. 1 out of 2 hunks FAILED -- saving rejects to file dlls/ntdll/virtual.c.rej On Thu, Oct 13, 2011 at 10:02 PM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/373 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed git > > Errors: > error: patch failed: dlls/ntdll/virtual.c:187 > error: dlls/ntdll/virtual.c: patch does not apply > >

2 1