October 2011 - Wine-devel - list.winehq.org

Re: shell32/tests: Better check the result of SHGetDesktopFolder
by Austin English 12 Oct '11

12 Oct '11

2011/10/12 André Hentschel <nerv(a)dawncrow.de>: > Might fix the crash in some NT4 systems > --- > dlls/shell32/tests/brsfolder.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/tests/brsfolder.c b/dlls/shell32/tests/brsfolder.c > index 7b87967..6e5e73b 100644 > --- a/dlls/shell32/tests/brsfolder.c > +++ b/dlls/shell32/tests/brsfolder.c > @@ -331,7 +331,8 @@ static void test_selection(void) > > hr = SHGetDesktopFolder(&desktop_object); > ok (SUCCEEDED(hr), "SHGetDesktopFolder failed with hr 0x%08x\n", hr); > - if (FAILED(hr)) { > + ok (desktop_object, "Expected desktop_object to be a valid interface\n"); > + if (FAILED(hr) || !desktop_object) { > skip("SHGetDesktopFolder failed - skipping\n"); > return; > } > -- > > Best Regards, André Hentschel Causes a compiler warning on Buildbot: Errors: brsfolder.c: In function 'test_selection': brsfolder.c:334:5: error: passing argument 1 of 'winetest_ok' makes integer from pointer without a cast [-Werror] make[1]: *** [brsfolder.o] Error 1 -- -Austin

1 0

Warning report for wine-1.3.30-55-g583e887
by Jerome Leclanche 12 Oct '11

12 Oct '11

It would be nice to fix the "array subscript is above array bounds" warning spam for 1.4.0. They make up 90% of the warnings. Apart from those, theres 25 more warning blocks to fix, most of them unused-but-set-variables. JL

5 5

Re: [Corrected^2] dlls/ntdll/serial.c: Generate a single EV_TXEMPTY when the\ TX buffer turns empty
by Alexandre Julliard 12 Oct '11

12 Oct '11

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > @@ -807,8 +808,22 @@ typedef struct async_commio > static NTSTATUS get_irq_info(int fd, serial_irq_info *irq_info) > { > NTSTATUS status = STATUS_NOT_IMPLEMENTED; > -#ifdef TIOCGICOUNT > struct serial_icounter_struct einfo; You can't move this out of the #idef. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d8/tests: skip the visual test if d3d cannot be initialized
by Henri Verbeet 12 Oct '11

12 Oct '11

On 12 October 2011 01:51, Austin English <austinenglish(a)gmail.com> wrote: > Current d3d8 does a win_skip(), while d3d9 does a skip(). This unifies > the behavior to match the d3d9 behavior. > I seem to recall this being intentional, so that you get a failure if your setup has e.g. no OpenGL.

2 1

Re: [4/4] wined3d: Don't allow fbo blits to frontbuffers that need fixups.
by Henri Verbeet 12 Oct '11

12 Oct '11

On 11 October 2011 22:31, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > static BOOL fbo_blit_supported(const struct wined3d_gl_info *gl_info, enum wined3d_blit_op blit_op, > const RECT *src_rect, DWORD src_usage, WINED3DPOOL src_pool, const struct wined3d_format *src_format, > - const RECT *dst_rect, DWORD dst_usage, WINED3DPOOL dst_pool, const struct wined3d_format *dst_format) > + const RECT *dst_rect, DWORD dst_usage, WINED3DPOOL dst_pool, const struct wined3d_format *dst_format, > + const struct wined3d_surface *dst_surface) I don't think we want this. Does this actually ever happen?

2 1

Re: 79794: Help Test Please: use uniscribe in the single line edit control
by Dan Kegel 12 Oct '11

12 Oct '11

Hi Aric, failed again on second run, http://buildbot.kegel.com:8010/builders/runtests-default/builds/209 Failing tests are comctl32_test.exe.so listview.c comctl32_test.exe.so updown.c user32_test.exe.so edit.c On Tue, Oct 11, 2011 at 1:26 PM, Dan Kegel <dank(a)kegel.com> wrote: > Hey Aric, > don't know if I trust the bot at the moment, but it says the tests > failed here... > I'll rerun them to see if the failure is repeatable. > > ---------- Forwarded message ---------- > From: <buildbot(a)kegel.com> > Date: Tue, Oct 11, 2011 at 1:21 PM > Subject: Re: 79794: Help Test Please: use uniscribe in the single line > edit control > To: dank(a)kegel.com, wine-tests-results(a)winehq.org > > > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default > while building Wine. > Full details are available at: > http://buildbot.kegel.com/builders/runtests-default/builds/186 (though > maybe not for long, as I'm still reinstalling the buildbot > periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > alarum: Timeout! Killing child ../../../wine. > alarum: failed command was ../../../wine comctl32_test.exe.so listview.c > alarum: ../../../wine terminated abnormally > make: *** [listview.ok] Error 99 > alarum: Timeout! Killing child ../../../wine. > alarum: failed command was ../../../wine comctl32_test.exe.so updown.c > alarum: ../../../wine terminated abnormally > make: *** [updown.ok] Error 99 > * Call to xpconnect wrapped JSObject produced this error: * > * Call to xpconnect wrapped JSObject produced this error: * > alarum: failed command was ../../../wine user32_test.exe.so edit.c > edit.c:1138: Test failed: expected 1 got 0 > edit.c:1156: Test failed: expected 1 got 0 > edit.c:1174: Test failed: expected 1 got 0 > make: *** [edit.ok] Error 3 > GnuTLS error: GnuTLS internal error. >

2 1

Re: [PATCH 5/5] server/named_pipe.c: remove the ps_disconnected_server state, if DisconnectNamedPipe is called, the server i
by Marvin 12 Oct '11

12 Oct '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14844 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === pipe.c:1603: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 203 === W2KPROSP4 (32 bit pipe) === pipe.c:1603: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 997

1 0

Re: [PATCH 4/5] kernel32, ntdll: implement most of GetNamedPipeHandleState (try 2)
by Marvin 12 Oct '11

12 Oct '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14843 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === pipe.c:1559: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 203 === W2KPROSP4 (32 bit pipe) === pipe.c:1559: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 997

1 0

Re: [2/4] wined3d: reject ARB shader blits if the destination is not fbo attachable
by Henri Verbeet 12 Oct '11

12 Oct '11

On 11 October 2011 22:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > + { > + if (!((dst_format->flags & WINED3DFMT_FLAG_FBO_ATTACHABLE) || (dst_usage & WINED3DUSAGE_RENDERTARGET))) > + return FALSE; > + } > + else if (!(dst_usage & WINED3DUSAGE_RENDERTARGET)) > + { > + return FALSE; > + } This is redundant. Formats are never FBO-attachable if we don't have FBOs. It's not clear this is what you want either way though. This pretty much looks like a copy/paste from fbo_blit_supported(), and the WINED3DUSAGE_RENDERTARGET check there is to allow formats that don't have a FBO-attachable internal format, but were created with the rtInternal format (which should always be attachable). There's really no equivalent check for backbuffer ORM, it just renders something and hopes we can read it back.

2 1

Re: [1/4] wined3d: Use an rbtree for the blit programs
by Henri Verbeet 12 Oct '11

12 Oct '11

Why do you need this?

2 3