October 2011 - Wine-devel - list.winehq.org

Solved: Problems with drawing text in 1.3.29
by Damian Dixon 07 Oct '11

07 Oct '11

I have narrowed the issue down to a difference in behaviour between Windows and Wine. The problem boils down to the following code: NONCLIENTMETRICS ncm; memset(&ncm, 0, sizeof(NONCLIENTMETRICS)); ncm.cbSize = sizeof(NONCLIENTMETRICS); VERIFY(SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &ncm, 0)); I used the font's returned from this call for drawing text and this caused the crash. The problem is that I upgraded to VS2010 and changed the target to WINVER=0x600. This means that I needed to change my code to the following. NONCLIENTMETRICS ncm; memset(&ncm, 0, sizeof(NONCLIENTMETRICS)); ncm.cbSize = sizeof(NONCLIENTMETRICS); #if(WINVER >= 0x0600) OSVERSIONINFO osvi; memset(&osvi,0,sizeof(osvi)); osvi.dwOSVersionInfoSize = sizeof(osvi); GetVersionEx(&osvi); if (osvi.dwMajorVersion < 6) ncm.cbSize -= sizeof(ncm.iPaddedBorderWidth); #endif VERIFY(SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &ncm, 0)); Note: On windows my application does not actually crash or stop working with my original code and the text is displayed at a size I would kind of expect it to be. I will raise a bug for this one... as a difference in behaviour. On 7 October 2011 08:50, Damian Dixon <damian.dixon(a)gmail.com> wrote: > Thanks for the suggestions. > > I've narrowed one of the issues down to WineEngGetGlyphOutline > in dlls/gdi32/freetype.c. > > The pitch is 6640 and the height is 53003. This means that a buffer of > ~335Mb has been allocated and then memset. > > This is where the slow down is occurring (because of the memset). I suspect > the resultant crash is also because of this. > > I would suggest that limits need to be placed on the maximum pitch and > height. > > > I do not however believe that this is the root cause just one of the > symptoms. > > > > On 5 October 2011 18:37, Marcus Meissner <marcus(a)jet.franken.de> wrote: > >> On Wed, Oct 05, 2011 at 04:53:18PM +0100, Damian Dixon wrote: >> > Hi, >> > >> > I was attempting to use Wine 1.3.29 (in OpenSUSE 11.4 x86) and because >> of >> > issues pulled the source from git last night and still have problems. >> > >> > I am having performance issues with DrawText (5 odd seconds to draw a >> simple >> > string) and the occasional X Error and crash. >> > >> > The X Error is consistent and is as follows: >> > >> > fixme:advapi:SetSecurityInfo stub >> > X Error of failed request: BadLength (poly request too large or >> internal >> > Xlib length error) >> > Major opcode of failed request: 151 (RENDER) >> > Minor opcode of failed request: 17 (RenderCreateGlyphSet) >> > Serial number of failed request: 41091 >> > Current serial number in output stream: 41571 >> > Process of pid=0023 has terminated >> > >> > >> > The crash less consistent but is dependent upon the amount of text I >> attempt >> > to draw. >> > >> > The last version I know this worked in was 1.1.39. >> > >> > I've a few things to still try out before I attempt to create an RBT. >> >> To get a backtrace and be able to dump some datastructures, run with >> >> WINEDEBUG=+synchronous wine foo.exe >> >> This will bring it into the debugger once the condition happens. >> >> CIao, MArcus >> > >

1 0

Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)
by Jeremy White 07 Oct '11

07 Oct '11

Hi Folks, I try to send out a periodic message to the wine-devel mailing list outlining the 'corporate' structure of Wine and how some decisions are made. We work with the Software Freedom Conservancy. They manage the pieces of Wine that benefit from a formal organization, such as managing money, holding Trademarks, and so on. The primary activity we have conducted with them over the past several years is managing money - about $3,000 each year. They manage all funds donated to Wine - the donate button goes into a bank account they manage and any larger private donations go there as well. For decisions on how to spend funds, we've adopted a loose set of guidelines. That is, we have a decision group and we require a majority of members to approve any spending. Alexandre and I are the current members of that group. We also claim the right to appoint anyone else to replace or augment the decision group. We CC all decisions to an auditor. We have recently asked Michael Stefanuic to replace Zachary Goldberg in that role. A critical requirement, we feel, is that a non CodeWeavers staff member be fully aware of all decisions made. We choose this strategy rather than a fully public process so that we can apply discretion and protect privacy of people that ask for help with travel funding. The SFC will recognize a 'revolt' by the Wine project. That is, the designated decision group can be overthrown, once you figure out our evil plans, if the SFC is persuaded that the majority of Wine contributors agree on that point. Patch count in the Wine tree will be the primary mechanism to recognize a contributor. Finally, all spending by the SFC on Wine's behalf for the last few years has been related to Wineconf. That has primarily been to help defray travel costs for Wine contributors to come to Wineconf. Wine's income has been around $3,000 / year for the past few years; we tend to spend down much of the balance each year for Wineconf. Cheers, Jeremy p.s. One note - the SFC also manages the GSOC payments, although I believe that they ostensibly manage that on behalf of Google, not really Wine. That is generally coordinated by Wine's GSOC coordinator, and Alexandre and I have nothing to do with it.

3 4

Wine Gecko 1.4-beta1
by Jacek Caban 07 Oct '11

07 Oct '11

Hi all, I've just uploaded new Gecko builds [1]. To use it, you need the attached patch and the build installed to the right place [2]. As usually, everything that uses MSHTML is worth testing. All testing and feedback will be appreciated. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.4-beta1/ [2] http://wiki.winehq.org/Gecko

2 3

Re: mshtml: Implement IHTMLDOMNode replaceChild
by Jacek Caban 07 Oct '11

07 Oct '11

Hi Alistair, On 10/7/11 4:50 AM, Alistair Leslie-Hughes wrote: > + HTMLDOMNode *nodeNew; > + HTMLDOMNode *nodeOld; Please use names consistent with the rest of the file. + if(NS_FAILED(nsres)) { + nsnode = nodeNew->nsnode; + } That seems questionable, why do you pretend to success on failure? Jacek

1 0

Re: [2/5] urlmon: Improved MapUrlToZone{Ex2} and GetSecurityId support
by Jacek Caban 07 Oct '11

07 Oct '11

Hi Thomas, On 10/6/11 6:42 PM, Thomas Mullaly wrote: > --- > dlls/urlmon/sec_mgr.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/urlmon/tests/sec_mgr.c | 30 +++++++++++++++++++++++++++++- > 2 files changed, 68 insertions(+), 3 deletions(-) + if(hres == S_FALSE){ + DWORD scheme_type; + BOOL has_host; + + hres = IUri_GetScheme(uri,&scheme_type); + if(FAILED(hres)) { + SysFreeString(scheme); + return hres; + } + + hres = IUri_HasProperty(uri, Uri_PROPERTY_HOST,&has_host); + if(FAILED(hres)) { + SysFreeString(scheme); + return hres; + } + + /* Known hierarchical scheme types must have a host. If they don't Windows + * assigns URLZONE_INVALID to the zone. + */ + if((scheme_type != URL_SCHEME_UNKNOWN&& scheme_type != URL_SCHEME_FILE) +&& is_hierarchical_scheme(scheme_type)&& !has_host) { + *zone = URLZONE_INVALID; It looks like get_zone_from_domains would be more logical place for this. It already does GetScheme call and you could just handle differently GetHost returning empty host. if(FAILED(hres)) return hres == 0x80041001 ? E_INVALIDARG : hres; + else if(zone == URLZONE_INVALID) + return E_INVALIDARG; You don't need 'else' here since if the previous if expression is true, we return anyways. Jacek

1 0

Re: mmdevapi/tests: Add format tests.
by Andrew Eikum 07 Oct '11

07 Oct '11

Hi J�rg, Thanks for adding these tests. It would have been nicer to split the patch up into discrete chunks. That would make the patch much easier to review. Overall it looks pretty good. Some remarks follow... > BTW, I've not touched > render.c:223: Test failed: IsFormatSupported(0xffffffff) call returns 8889000e > capture.ok has a similar random failure. I believe that test is bogus. It > should avoid ending up calling the exclusive mode "audio endpoint" and hope/show > that the shared mode mixer aka. "audio engine" reports E_INVALIDARG. Perhaps > using ~AUDCLNT_SHAREMODE_EXCLUSIVE is a means to enforce this, even though > that's actually an enum, not a flag. Yeah, that's a pretty uninteresting test. If it's flaky, I don't see any compelling reason to keep it around. > + unk = (void*)0xDEADF00D; > hr = IAudioClient_GetService(ac, &IID_IAudioStreamVolume, (void**)&unk); > ok(hr == AUDCLNT_E_NOT_INITIALIZED, "Uninitialized GetService call returns %08x\n", hr); > + todo_wine ok(broken(unk != NULL), "GetService %08x &out pointer %p\n", hr, unk); This test is strange. broken() basically means "should fail on Windows, should not fail in Wine." It's used when some particular version of Windows does something unexpected which we are uninterested in duplicating. Do you expect unk to always be non-NULL? If so, then just test for that without the broken() macro. > > +static void test_formats(AUDCLNT_SHAREMODE mode) The code in this function is very difficult to follow. I wonder if it couldn't be written more clearly with explicit conditions and a bit more code duplication. > + ok((hr == S_FALSE)^(pwfx2 == NULL), "hr %x<->suggest %p\n", hr, pwfx2); > + if (pwfx2 == (WAVEFORMATEX*)0xDEADF00D) /* bug in Wine */ > + pwfx2 = NULL; Would be nicer to both fix the bug in Wine and have a test showing the correct behavior. > @@ -1378,7 +1535,7 @@ START_TEST(render) > hr = CoCreateInstance(&CLSID_MMDeviceEnumerator, NULL, CLSCTX_INPROC_SERVER, &IID_IMMDeviceEnumerator, (void**)&mme); > if (FAILED(hr)) > { > - skip("mmdevapi not available: 0x%08x\n", hr); > + win_skip("mmdevapi not available: 0x%08x\n", hr); If the user has an invalid driver, CoCreateInstance() will fail to create the enumerator object. I think that's valid behavior, so we shouldn't fail. Andrew

3 3

DLLCanUnloadNow Question
by Alistair Leslie-Hughes 07 Oct '11

07 Oct '11

Hi, The Following sample code causes a crash under WINE, but not in windows. IUnknown *p LoadLibrary("mscoree.dll") GetProcAddress("CreateDebuggingInterfaceFromVersion") CreateDebuggingInterfaceFromVersion(..., (void**)&p) <-- Com Reference FreeLibrary("mscoree.dll") p->QueryInterface(....); <-- Cause Crash under WINE. The DLL shouldn't be unloaded since mscoree.DLLCanUnloadNow() return S_FALSE; Is this a bug with the unloading of DLL's? Is there way to stop the unloading of a DLL? I know the logic isn't the best, but I'm seeing this type of behavior in an application. Best Regards Alistair Leslie-Hughes

2 1

Problems with drawing text in 1.3.29
by Damian Dixon 07 Oct '11

07 Oct '11

Hi, I was attempting to use Wine 1.3.29 (in OpenSUSE 11.4 x86) and because of issues pulled the source from git last night and still have problems. I am having performance issues with DrawText (5 odd seconds to draw a simple string) and the occasional X Error and crash. The X Error is consistent and is as follows: fixme:advapi:SetSecurityInfo stub X Error of failed request: BadLength (poly request too large or internal Xlib length error) Major opcode of failed request: 151 (RENDER) Minor opcode of failed request: 17 (RenderCreateGlyphSet) Serial number of failed request: 41091 Current serial number in output stream: 41571 Process of pid=0023 has terminated The crash less consistent but is dependent upon the amount of text I attempt to draw. The last version I know this worked in was 1.1.39. I've a few things to still try out before I attempt to create an RBT. However I would like to know if anyone else is experiencing similar problems and f they have solved the problem. Thanks Damian

3 3

Re: [PATCH] winecoreaudio.drv: Reimplement IAudioClock::GetPosition()
by Alexandre Julliard 06 Oct '11

06 Oct '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/winecoreaudio.drv/mmdevdrv.c | 27 +++++++++------------------ > 1 files changed, 9 insertions(+), 18 deletions(-) This fails for me: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so wave.c && touch wave.ok wave.c:498: Test failed: waveOutGetPosition(0): returned 19845 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(0): returned 19845 samples (19845 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(0): returned 900 ms, (19845 bytes), should be 1000 (22050 bytes) wave.c:535: Test failed: waveOutGetPosition(0): SMPTE test failed wave.c:546: Test failed: waveOutGetPosition(0): MIDI test failed wave.c:557: Test failed: waveOutGetPosition(0): TICKS test failed wave.c:498: Test failed: waveOutGetPosition(0): returned 19845 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(0): returned 19845 samples (19845 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(0): returned 900 ms, (19845 bytes), should be 1000 (22050 bytes) wave.c:535: Test failed: waveOutGetPosition(0): SMPTE test failed wave.c:546: Test failed: waveOutGetPosition(0): MIDI test failed wave.c:557: Test failed: waveOutGetPosition(0): TICKS test failed wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19845 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19845 samples (19845 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 900 ms, (19845 bytes), should be 1000 (22050 bytes) wave.c:535: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:546: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:557: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19845 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19845 samples (19845 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 900 ms, (19845 bytes), should be 1000 (22050 bytes) wave.c:535: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:546: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:557: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed make: *** [wave.ok] Error 24 -- Alexandre Julliard julliard(a)winehq.org

1 0

[patch] Fake display interface
by Jari Vetoniemi 06 Oct '11

06 Oct '11

Yeah, I'm aware of virtual desktop and used to create scripts to launch applications using wine explorer \desktop=WIDTHxHEIGHT or whatever the parameters were, it works well. But means that you have to create always new shell script, and it also can prevent desktop integration for certain application. If you globally enable that also, it means that every application opens on the same virtual desktop. Also virtual desktop won't fake the display resolutions to application which is useful in certain cases. 2011/9/2 Hin-Tak Leung <hintak_leung(a)yahoo.co.uk>: > --- On Fri, 2/9/11, Jari Vetoniemi <mailroxas(a)gmail.com> wrote: > >> Hello, >> >> I personally hate when applications decide to change my >> screen >> resolution without asking me, or some applications just >> won't run >> inside window. >> So I did fake display interface for the winex11.drv. It >> allows you to >> send any display resolution and frequency to the >> application, but it >> does not change resolution. >> It's small and simple patch, and won't probably ever be >> included into >> the mainline wine. However I'll post it here as it might be >> useful for >> some. >> >> To enable, create string key UseFakeDisp with value Y in >> H_C_U/Software/Wine/X11 Driver >> Default fake resolution is 800x600 60HZ, you can change >> default with >> registry keys FakeDispHeight, FakeDispWidth, FakeDispFreq >> You can also use env variable >> WINE_FAKEDISP=WIDTHxHEIGHT_FREQ (eg. >> WINE_FAKEDISP=1024x768_60) >> >> Might improve it later to use the same syntax for default >> resolution >> and allow multiple fake resolutions to be defined with ; >> separator. >> This is also useful for dual head setups where you may want >> to run >> game or application fullscreen on other monitor while still >> keeping >> the other alive. >> There is also interesting side effect: While some >> applications throw >> error or won't run on resolutions they don't support, some >> applications that don't support them still run with the >> resolution >> specified. Eg. I can run Ys games with 1440x900 resolution >> where they >> normally would not run, and they look great. > > In winecfg there is a way of configuring wine to run under its own desktop window (and having any window application's windows running inside that), instead of having the unix host's window manager managing the window application's window. Have you tried using that? Granted it is a bit awkward for what you want to do (having to go into winecfg to change the desktop's resolution and resetting it afterwards, instead of passing the resolution in per application), but may be improving on that functionality in winecfg could get your code included eventually somehow. >

3 8