October 2011 - Wine-devel - list.winehq.org

Re: [3/4] wined3d: reject ffp blits if the destination is not fbo attachable
by Henri Verbeet 12 Oct '11

12 Oct '11

On 11 October 2011 22:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > + { > + if (!((dst_format->flags & WINED3DFMT_FLAG_FBO_ATTACHABLE) || (dst_usage & WINED3DUSAGE_RENDERTARGET))) > + return FALSE; > + } > + else if (!(dst_usage & WINED3DUSAGE_RENDERTARGET)) > + { > + return FALSE; > + } Same consideration as for 2/4. Guess I should have caught this when bccfd7cc introduced it.

1 0

Re: [PATCH] dsound: Don't claim to support hardware buffers
by Marvin 11 Oct '11

11 Oct '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14829 Your paranoid android. === W2K3R2SESP2 (32 bit dsound) === dsound.c:329: Test failed: IDirectSound_CreateSoundBuffer() failed to create a secondary buffer 88780032

1 0

Re: [PATCH] dsound: Don't claim to support hardware buffers
by Chris Robinson 11 Oct '11

11 Oct '11

Hi. On Tuesday, October 11, 2011 3:31:59 PM Andrew Eikum wrote: > The specific drvcaps values and error code were tested against Windows > 7. How does this affect the primary buffer? Is it not allowed to be a hardware buffer either?

1 0

Re: [PATCH 1/7] msi/custom.c: unify thread handling of different custom action types (resend)
by Hans Leidekker 11 Oct '11

11 Oct '11

On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote: +static HRESULT get_action_info( msi_custom_action_info *info, INT *type, + BSTR *source, BSTR *target, BSTR *name, + IWineMsiRemotePackage **package ) { - IClassFactory *cf = NULL; - IWineMsiRemoteCustomAction *rca = NULL; - HRESULT r; - - r = DllGetClassObject( &CLSID_WineMsiRemoteCustomAction, - &IID_IClassFactory, (LPVOID *)&cf ); - if (FAILED(r)) - { - ERR("failed to get IClassFactory interface\n"); - return ERROR_FUNCTION_FAILED; - } - - r = IClassFactory_CreateInstance( cf, NULL, &IID_IWineMsiRemoteCustomAction, (LPVOID *)&rca ); - if (FAILED(r)) - { - ERR("failed to get IWineMsiRemoteCustomAction interface\n"); - return ERROR_FUNCTION_FAILED; - } - - r = IWineMsiRemoteCustomAction_GetActionInfo( rca, guid, type, handle, dll, funcname, package ); - IWineMsiRemoteCustomAction_Release( rca ); - if (FAILED(r)) - { - ERR("GetActionInfo failed\n"); - return ERROR_FUNCTION_FAILED; + IWineMsiRemotePackage *rp; + HRESULT res; + *source = *target = *name = NULL; + + res = create_msi_remote_package( NULL, (void **) &rp ); + if (FAILED( res )) + return res; + res = IWineMsiRemotePackage_SetMsiHandle( rp, alloc_msihandle( &info->package->hdr ) ); You should check for failure from alloc_msihandle. + if (FAILED( res )) + goto error; + + *source = SysAllocString( info->source ); + *target = SysAllocString( info->target ); + *name = SysAllocString( info->action ); + if (!*source || !*target || !*name) { + res = E_OUTOFMEMORY; + goto error; } - + + *package = rp; + *type = info->type; + return ERROR_SUCCESS; This should become S_OK. You are mixing up return types in more places.

2 1

Re: [PATCH 5/7] msi/custom.c: get rid of MSIRUNNINGACTION
by Hans Leidekker 11 Oct '11

11 Oct '11

> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, > +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, > LPCWSTR target, const INT type, LPCWSTR action) > { > WCHAR *exe, *arg; > msi_custom_action_info *info; > > - if (!(exe = msi_dup_property( package->db, source ))) return ERROR_SUCCESS; > + if (!(exe = msi_dup_property( package->db, source ))) return NULL; Are you sure this should be an error? Native might ignore a missing property. > -static UINT HANDLE_CustomType53_54(MSIPACKAGE *package, LPCWSTR source, > +static msi_custom_action_info *HANDLE_CustomType53_54(MSIPACKAGE *package, LPCWSTR source, > LPCWSTR target, const INT type, LPCWSTR action) > { > msi_custom_action_info *info; > WCHAR *prop; > - UINT r; > > TRACE("%s %s\n", debugstr_w(source), debugstr_w(target)); > > prop = msi_dup_property( package->db, source ); > - if (!prop) return ERROR_SUCCESS; > + if (!prop) return NULL; Same here.

2 1

re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field
by Dan Kegel 11 Oct '11

11 Oct '11

Hi Bernhard, Build fails here: loader.c: In function ‘test_section_mapping’: loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] cc1: all warnings being treated as errors make[1]: *** [loader.o] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/kernel32/tests' make: *** [dlls/kernel32/tests] Error 2 http://buildbot.kegel.com:8010/builders/runtests-default/builds/159 Can you fix and resubmit the series?

3 4

Re: [3/3] ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released. (try 2)
by Alexandre Julliard 11 Oct '11

11 Oct '11

Octavian Voicu <octavian.voicu(a)gmail.com> writes: > Fixes a bug that causes a stencil buffer leak in the game The Longest Journey. > Problem can be seen in the console output log attached to bug #11819. > This patch doesn't fix the original bug, but now game exits cleanly. > > The root of the problem is that when releasing a surface, its attached > surfaces are detached using IDirectDraw7_DeleteAttachedSurface, regardless > of what interface was originally attached. It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so dsurface.c && touch dsurface.ok dsurface.c:1603: Test failed: DeleteAttachedSurface returned 887601cc dsurface.c:3534: Tests skipped: IDirectDraw7_CreateSurface failed, hr = 0x88760091, format D3DFMT_X8B8G8R8 dsurface.c:3534: Tests skipped: IDirectDraw7_CreateSurface failed, hr = 0x88760091, format D3DFMT_X8B8G8R8 dsurface.c:3534: Tests skipped: IDirectDraw7_CreateSurface failed, hr = 0x88760091, format D3DFMT_A2R10G10B10 dsurface.c:3534: Tests skipped: IDirectDraw7_CreateSurface failed, hr = 0x88760091, format D3DFMT_A8L8 make[1]: *** [dsurface.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState
by Juan Lang 11 Oct '11

11 Oct '11

Hi Bernhard, nit: - todo_wine - ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, + todo_wine ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, This change is a no-op. --Juan

2 1

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState
by Marvin 11 Oct '11

11 Oct '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14813 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === pipe.c:1559: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 203 === W2KPROSP4 (32 bit pipe) === pipe.c:1559: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 997

1 0

Re: [PATCH 3/3] vbscript: Added Hex function tests
by Marvin 11 Oct '11

11 Oct '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14804 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0