November 2011 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] kernel32: implement GetLogicalProcessorInformation
by Marvin 25 Nov '11

25 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15626 Your paranoid android. === WNT4WSSP6 (32 bit glpi) === Timeout === W2KPROSP4 (32 bit glpi) === Timeout

1 0

Re: cmd: Use WCMD_output_asis*() for strings that are not supposed to contain formating directives.
by Frédéric Delanoy 24 Nov '11

24 Nov '11

On Thu, Nov 24, 2011 at 00:30, Francois Gouget <fgouget(a)free.fr> wrote: > Using WCMD_output*() instead could cause crashes. > --- > > For instance if a filename is '%s'. > This patch should not interfere with the previous one. > - WCMD_output(newline); > + WCMD_output_asis(newline); ... > static const WCHAR newLine2[] = {'\n','\n','\0'}; > - if (!bare) WCMD_output (newLine2); > + if (!bare) WCMD_output_asis (newLine2); ... > - WCMD_output(anykey); > + WCMD_output_asis(anykey); No need to change those, since we control those strings, and those are generic strings with no '%' directive. > - WCMD_output (version_string); > + WCMD_output_asis (version_string); This one does contain a %s ( WCMD_VERSION,"CMD Version %s\n"), but we control the version string as well (currently Wine version), so shouldn't probably be changed. > @@ -430,13 +430,13 @@ static DIRECTORY_STACK *WCMD_list_directory (DIRECTORY_STACK *inputparms, int le > strcatW(&temp[toWrite], space); > toWrite++; > if (toWrite > 99) { > - WCMD_output(temp); > + WCMD_output_asis(temp); > toWrite = 0; > strcpyW(temp, nullW); > } > padding--; > } > - WCMD_output(temp); > + WCMD_output_asis(temp); > } It's just doing padding with plain spaces, so no changes needed here. The remaining hunks should be OK. Frédéric

2 2

Re: winhttp: Resolve the server name only on the first request.
by Alexandre Julliard 24 Nov '11

24 Nov '11

Hans Leidekker <hans(a)codeweavers.com> writes: > - send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_RESOLVING_NAME, connect->servername, strlenW(connect->servername) + 1 ); > + if (connect->sockaddr.ss_family == 0xffff) > + { This won't work on Mac OS, ss_family is a byte: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/sw/include/freetype2 -I/sw/include -I/sw/include -g -O2 -o request.o request.c request.c: In function 'open_connection': request.c:931: warning: comparison is always false due to limited range of data type -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: Stub IDirectInputJoyConfig8 interface.
by Michael Stefaniuc 24 Nov '11

24 Nov '11

Hello Vitaliy, On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: > --- > dlls/dinput/dinput_main.c | 7 ++ > dlls/dinput/dinput_private.h | 2 + > dlls/dinput/joystick.c | 195 +++++++++++++++++++++++++++++++++ > include/dinputd.h | 243 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 447 insertions(+), 0 deletions(-) > create mode 100644 include/dinputd.h we are trying to get rid off the LPJUNK, IDirectInputJoyConfig8 * is so much more nicer than LPDIRECTINPUTJOYCONFIG8. While the above is more of a nit-pick (and an easy search and replace patch for me) the QueryInterface implementation is not correct: - Query for IID_IUnknown is not supported. - Use IDirectInputJoyConfig8_AddRef() on the interface without the cast - You can save the round trip over impl_from_IDirectInputJoyConfig8() as iface and &This->IDirectInputJoyConfig8_iface are the exact same thing. bye michael

2 2

Sugestion about wine
by Kane Jade 24 Nov '11

24 Nov '11

Perhaps the program Zynamics BinNavi is useful to analyze the win32 applications, etc: Zynamics BinNavi is the primary binary code reverse engineering tool based on graph visualization Description BinNavi is a binary code reverse engineering tool that was built to assist vulnerability researchers who look for vulnerabilities in disassembled code. With BinNavi you can analyze disassembled x86, ARM, PowerPC, and MIPS code using the powerful built-in static code analysis techniques. In cases where static code analysis is not enough, you can use the built-in debuggers to get a live view on the program you are analyzing. Use Cases - Do *control flow based code analysis* of disassembled x86, ARM, MIPS, and PowerPC code - *Cut down on complexity* by removing unimportant code from functions - Use *powerful remote debuggers* to debug programs on different operating systems - Use Differential Debugging to *quickly locate relevant code* - Create and assign user-defined tags to *mark important functions and basic blocks* - Use *advanced code analysis algorithms* to keep track of data and code - Manage all your reverse engineering projects in *one central database* - Write *scripts and plugins to extend BinNavi* to meet your specific goals - Rename and *annotate variables and functions* to make them self-explanatory - Use the REIL meta-language to *write platform-independent program analysis code* To learn more about the features and use cases of BinNavi please take a look at the BinNavi manual<http://www.zynamics.com/binnavi/manual/index.htm> . I think that it is easier to see how they are running operations on files connected with the BinNavi program. Since is a transparent, simpler and interesting debugger. link http://www.zynamics.com/binnavi.html Forgive this text is translated by translatica.pl.

2 1

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation
by Marvin 24 Nov '11

24 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15612 Your paranoid android. === WNT4WSSP6 (32 bit glpi) === Timeout === W2KPROSP4 (32 bit glpi) === Timeout

1 0

Re: cmd: Print error messages on stderr, not on stdout.
by Frédéric Delanoy 24 Nov '11

24 Nov '11

On Thu, Nov 24, 2011 at 00:29, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > I consider messages like 'Not Yet Implemented' and 'No Argument' to be > errors so that they should go to stderr. But maybe there's a strong > argument for not doing it that way. Your point is valid. I changed some/most of those myself some time ago. However the test suite fails with your patch applied (e.g. for the incomplete "for" construct). Some of the hunks might be applied though, but you'd have to run the test suite to be sure. Frédéric

1 0

Re: [PATCH] wininet: Initialize netconn_stream's content_length
by Jacek Caban 23 Nov '11

23 Nov '11

Hi Andy, On 11/22/11 5:49 AM, Andy Clayton wrote: > The size that net_conn_read reads is limited by netconn_stream's > remaining content_length, so if the content_length is zero it reads > nothing. It also means that the read size it returns is 0, which > typically indicates that the socket was closed. As a result of the > change from 193da884ad9b982d9b740b15453aa8d3c19b054f, > HTTP_ReceiveRequestData acts on the read size of 0 and closes the > connection. HttpSendRequest calls HTTP_ReceiveRequestData if there is no > post data, closing the connection with none of the response data ever > being read. > > This patch fixes this case by initializing netconn_stream's > content_length to ~0. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=27816 > This doesn't seem right. At the point where we call HTTP_ReceiveRequestData, content_length is supposed to be set based on response header. The bug must be somewhere else. Jacek

2 3

Re: po: Update French translation (try 2)
by Frédéric Delanoy 22 Nov '11

22 Nov '11

2011/11/22 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > try 2: xB -> xO > --- > po/fr.po | 52 +++++++++++++++++++--------------------------------- > 1 files changed, 19 insertions(+), 33 deletions(-) Seems you have committed the initial version. I'll change 'bytes' to 'octets' on next po update round, therefore you may forget about this patch. Frédéric

1 0

Re: po: Update French translation
by Francois Gouget 22 Nov '11

22 Nov '11

On Mon, 21 Nov 2011, Frédéric Delanoy wrote: [...] > msgid "%1!u!MB used, %2!u!MB available" > -msgstr "%u MB utilisés, %u MB disponibles" > +msgstr "%1!u! MB utilisés, %2!u! MB disponibles" [...] > msgctxt "unit kilobyte" > msgid "kB" > -msgstr "" > +msgstr "kB" > > #: winefile.rc:122 > msgctxt "unit megabyte" > msgid "MB" > -msgstr "" > +msgstr "MB" > > #: winefile.rc:123 > msgctxt "unit gigabyte" > msgid "GB" > -msgstr "" > +msgstr "GB" kB, MB and GB should be translated to ko, Mo and Go respectively. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

2 3