November 2011 - Wine-devel - list.winehq.org

Re: [PATCH 5/5] jscript: Use bytecode interpreter for logical negation expression
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15516 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: ieframe: Fixed tests on IE9
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15514 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3165: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3132: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

2 1

Using native msvc*.dll: all or nothing?
by Dan Kegel 18 Nov '11

18 Nov '11

Given errors like err:module:find_forwarded_export function not found for forward 'msvcrt.__CxxFrameHandler3' used by L"C:\\windows\\system32\\msvcr90.dll". If you are using builtin L"msvcr90.dll", try using the native one instead. I'm starting to get the feeling that, if you're going to install any flavor of Microsoft C++ runtime libraries, you should install them all. Is that more or less correct? i.e. should winetricks add a verb that installs all of vcrun6, vcrun2003, vcrun2005, vcrun2008, and maybe vcrun2010 and encourage users to do that instead of installing the individual libraries?

2 1

Re: Re: Re: added remaining functions, data structures, definitions required by http api to include/
by Juan Lang 17 Nov '11

17 Nov '11

Hi Arash, >> I'm also concerned whether this was the product of copy/paste, which >> isn't allowed. Was it? > about that copy/paste stuff, > well I guess we eventually produce an almost identical header file with one > in the SDK > I mean everything in the header file is already exposed to the user and "IS" > part of API > am I not right? I might agree with you, but lawyers might not. As a result, we don't allow copy/paste code in Wine, even in headers. > just one more question if you don't mind! > should I use winsock for socket programming or native linux's? and > for some library I may need (regex for example) is there any restriction or > convection or something like that or I can use any third party lib? Native linux sockets are typically used, unless there's good reason for them not to be. 3rd party libraries are harder to work with. You typically have to choose something which you expect will be installed on every common platform, built appropriate configure checks to determine if the library is present at compile time, make your code fail gracefully if not, and dynamically load the library at runtime. Static linking is also viable, if you expect the library is commonly available, and if the license is compatible: LGPL and BSD are, GPL is not, just to give a few examples. It'd help more if we knew precisely what you're working on, and what you need e.g. regex for. --Juan

1 0

FOSDEM 2012 - CrossDesktop DevRoom Call for Talks
by Pau Garcia i Quiles 17 Nov '11

17 Nov '11

Hi, FOSDEM is one of the largest gatherings of Free Software contributors in the world and happens each February in Brussels (Belgium). One of the tracks will be the CrossDesktop DevRoom, which will host Desktop-related talks. We are now inviting proposals for talks about Free/Libre/Open-source Software on the topics of Desktop development, Desktop applications and interoperativity amongst Desktop Environments. This is a unique opportunity to show novel ideas and developments to a wide technical audience. Topics accepted include, but are not limited to: Enlightenment, Gnome, KDE, XFCE, Windows, Mac OS X, general desktop matters, applications that enhance desktops and web (when related to desktop). Talks can be very specific, such as developing mobile applications with Qt Quick; or as general as predictions for the fusion of Desktop and web in 5 years time. Topics that are of interest to the users and developers of all desktop environments are especially welcome. The FOSDEM 2011 schedule might give you some inspiration: http://archive.fosdem.org/2011/schedule/track/crossdesktop_devroom Please include the following information when submitting a proposal: your name, the title of your talk (please be descriptive, as titles will be listed with around 250 from other projects) and a short abstract of one or two paragraphs. The deadline for submissions is December 20th 2011. FOSDEM will be held on the weekend of 4-5 February 2012. Please submit your proposals to: crossdesktop-devroom(a)lists.fosdem.org ( https://lists.fosdem.org/listinfo/crossdesktop-devroom ) -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: mshtml: fix MSVC build in htmllocation.c
by Nikolay Sivov 17 Nov '11

17 Nov '11

On 11/17/2011 15:18, Thomas Faber wrote: > This removes the use of two Variable Length Arrays. > Instead of filling a local buffer, then allocating a new one using > SysAllocString[Len], the strings are now directly written to the latter > buffer. > Note that the 'len' variable in hunk 2 does not need to count in the > terminating null in this case because SysAllocStringLen automatically > adds one. > - WCHAR buf[url.dwSchemeLength + 1]; > + WCHAR *buf; > + buf = *p = SysAllocStringLen(NULL, url.dwSchemeLength + 1); > memcpy(buf, url.lpszScheme, url.dwSchemeLength * sizeof(WCHAR)); > buf[url.dwSchemeLength] = ':'; > - *p = SysAllocStringLen(buf, url.dwSchemeLength + 1); You don't need 'buf' variable after that.

1 0

Antw.: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by André Hentschel 17 Nov '11

17 Nov '11

I would love to see such a tool, i could use it for some actctx tests in ntdll Gesendet mit meinem HTC ----- Reply message ----- Von: "Saulius Krasuckas" <saulius2(a)ar.fi.lt> An: "Alexandre Julliard" <julliard(a)winehq.org> Cc: <wine-devel(a)winehq.org> Betreff: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece. Datum: Do., Nov. 17, 2011 18:49 On Thu, 17 Nov 2011, Alexandre Julliard wrote: > > The test requires a PE binary because obviously we can't test PE > protections on Unix binaries. That doesn't mean it doesn't exist. Just > build a crosstest: > > $ wine ntdll_crosstest.exe info.c > info.c:1296: Test failed: mbi.Protect is 0x8, expected 0x4 IIRC, some of tests already craft minimal PE binaries in manual way. So it would be nice to have some tool inside the tree to generate PEs independetly, no? Several years ago I've tried testing GetStdHandle() from within two PE binaries with different header flags set (IMAGE_SUBSYSTEM_WINDOWS_[GC]UI). For a start I have copied some code of manual PE crafting to build PE header. Then there came .text section's order. I realized it's sufficient to write small assembler file, run it through the gas crosscompiler, disasm it and parse the results to have _not only_ binary data for rebuilding PE, but also symbolic one. I wrote some awk-script then to convert .S file into C-function this way. With it it was easy to adjust options for crosscompiling gas/ld tools to get PE with needed structure. But maybe there is point in creating some universal in-tree tool? Or integrate the functionality into winegcc (or else) so as not to depend on a crosscompiling suite but still have readable and easy changeable source. Guys, what do you think? S.

1 0

Re: Re: added remaining functions, data structures, definitions required by http api to include/http
by Juan Lang 17 Nov '11

17 Nov '11

> can you be more specific please? Yes: +#ifndef __HTTP_H__ +#define __HTTP_H__ Don't do that, it's already #ifdef protected. +/*#if _WIN32_WINNT >= 0x0501*/ Dead code, just leave it out. +typedef struct _HTTP_REQUEST_V2 +{ + /* TODO : anonymous structure is not supported by C standard */ + /* struct HTTP_REQUEST_V1; */ For one thing, that's what the DUMMYSTRUCTNAME macro is for. For another, by omitting it, you've made the structure binary incompatible with the PSDK one for C code. Clearly that's wrong. I stopped reviewing here, you have many examples of the above error. I'm also concerned whether this was the product of copy/paste, which isn't allowed. Was it? --Juan

1 0

Re: [PATCH 1/1] ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets (try 2, resend).
by Juan Lang 17 Nov '11

17 Nov '11

Hi Erich, + * Bind the given socket exclusively to a specific interface. I know the style around here is to comment minimally, but I didn't find it clear what the behavior of this function is. For one thing, +static int interface_bind( int fd, struct sockaddr *addr ) (snip) + int ret = FALSE; (snip) + ret = TRUE; You're using #defines used with BOOL, so a BOOL return value would be a little clearer IMO. int, in the context of socket functions, often uses 0 => success, -1 => failure. Still, even with that change, + if (in_sock->sin_addr.s_addr == htonl(WS_INADDR_ANY)) + { + /* Not binding to specific interface, use default route */ + goto cleanup; + } + optlen = sizeof(sock_type); + if (getsockopt(fd, SOL_SOCKET, SO_TYPE, &sock_type, &optlen) == -1 + || sock_type != SOCK_DGRAM) + { + /* Not a UDP socket, interface-specific bind is irrelevant. */ + goto cleanup; These two blocks will use the default return value, FALSE, and it wasn't clear to me from the function name or comment that it should return FALSE in this case. Not that doing so is incorrect: just that it isn't obvious that that's the way it should behave. In this case, I feel a comment indicating that the function returns TRUE iff the function bound to a specific device, and that FALSE doesn't necessarily mean failure, is merited. Also, + /* Obtain the size of the IPv4 adapter list and allocate structure memory */ + if (GetAdaptersInfo(NULL, &adap_size) != ERROR_BUFFER_OVERFLOW) Why do all this outside the #ifdef SO_BINDTODEVICE guard? I'd rather you just had a different implementation of the function when SO_BINDTODEVICE isn't present that issues the warning and does nothing else. I'll let Alexandre comment on whether the approach itself is appropriate. Thanks, --Juan

2 1

Re: [PATCH 2/2] mshtml: Added tests of handling ActiveX objects without IQuickActivate interface implemented
by Alexandre Julliard 17 Nov '11

17 Nov '11

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/activex.c | 133 > ++++++++++++++++++++++++++++++------------ > 1 files changed, 95 insertions(+), 38 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so activex.c && touch activex.ok wine: Unhandled page fault on read access to 0x00000008 at address 0x6a76d2a6 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x6a76d2a6). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6a76d2a6 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010206( R- -- I - -P- ) EAX:01824650 EBX:00000000 ECX:00000008 EDX:00000000 ESI:01824650 EDI:00000000 Stack dump: 0x0032fab0: 01824650 6ad31584 0182459c 018244c8 0x0032fac0: 018244c8 00000000 0032faf8 6a45f2cd 0x0032fad0: 018244c8 00000003 6ad316db 00000000 0x0032fae0: 018244c8 0032fb28 001ab708 01828bd8 0x0032faf0: 0171af60 00000000 0032fb48 6a4b7d29 0x0032fb00: 018244c8 00000000 0032fb28 6a617b0f Backtrace: =>0 0x6a76d2a6 in xul (+0xb2d2a6) (0x0032fac8) 1 0x6a45f2cd in xul (+0x81f2cc) (0x0032faf8) 2 0x6a4b7d29 in xul (+0x877d28) (0x0032fb48) 3 0x6a4b9648 in xul (+0x879647) (0x0032fb98) 4 0x6a4b73db in xul (+0x8773da) (0x0032fbc8) 5 0x555e04e7 NSContainer_Release+0x76(This=0x17978b8) [/home/julliard/wine/wine/dlls/mshtml/nsembed.c:1886] in mshtml (0x0032fbf8) 6 0x55585435 CustomDoc_Release+0x1c4(iface=0x135c8c) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2315] in mshtml (0x0032fc38) 7 0x5557f2e4 HTMLDocument_Release+0x13(iface=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:433] in mshtml (0x0032fc58) 8 0x687657a4 release_doc+0x23(doc=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:1945] in mshtml_test (0x0032fc78) 9 0x6876a445 func_activex+0x18b4() [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:2060] in mshtml_test (0x0032fd58) 10 0x68763202 main+0x3a1(argc=*** Invalid address 0x00000008 *** , argv=*** Invalid address 0x0000000c *** Internal symbol error: unable to access memory location 0xc) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe28) 11 0x687becf5 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe70) 12 0x6848858c call_process_entry+0xb() in kernel32 (0x0032fe88) 13 0x6848953f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1090] in kernel32 (0x0032fec8) 14 0x68375dd0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x68378abd call_thread_func+0x7c(entry=0x684894e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 16 0x68375dae call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x6834dece start_process+0x1d(kernel_start=0x684894e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 18 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x6a76d2a6: call *0x8(%edx) -- Alexandre Julliard julliard(a)winehq.org

2 1