February 2011 - Wine-devel - list.winehq.org

Re: po: Update French translation
by Paul Vriens 08 Feb '11

08 Feb '11

On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: > #: avifil32.rc:27 > +#, fuzzy > msgid "Waveform: %s" > msgstr "Waveform : %s" > > #: avifil32.rc:28 > +#, fuzzy > msgid "Waveform" > msgstr "Waveform" Hi, Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are ignored for translations: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1898f22ca5d2d79750e98… -- Cheers, Paul.

2 1

Re: [PATCH 3/5] d3dx9_36: Implemented ID3DXConstantTable_SetVector and ID3DXConstantTable_SetVectorArray
by Matteo Bruni 08 Feb '11

08 Feb '11

> + if (is_vertex_shader(This->desc.Version)) > + IDirect3DDevice9_SetVertexShaderConstantF(device, desc.RegisterIndex + i, (float *)fvector, > + desc.RegisterCount); You should probably just use 1 instead of desc.RegisterCount in SetVertexShaderConstantF, as you are already in a loop for each vector. Also, why are you casting a (float *) to a (float *)? Especially after creating a float array just for that. However, making you use a temporary array to convert struct D3DXVECTOR4 to (float *) was somewhat my bad suggestion I believe. My concern was that the structure maybe didn't have its fields packed (with some padding between the fields of the structure for alignment reasons) and just casting the struct pointer to (float *) would not give correct results. Looking at the definition of D3DXVECTOR4 (and assuming it is correct), it appears to not be the case, so you can simply cast it to (float *). Then you can remove the for loop altogether and just set min(count, desc.RegisterCount) registers in the Set{Vertex/Pixel}ShaderConstantF call. Sorry for not being clear enough / giving wrong directions. Please add a "(try n)" suffix to the email subject when you're sending new versions of a patch.

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9039 Your paranoid android. === W7PROX64 (64 bit win) === win.c:3480: Test failed: SetForegroundWindow() failed

2 1

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9028 Your paranoid android. === WNT4WSSP6 (32 bit clipping) === clipping.c:438: Test failed: expected 0,0-0,0, got 0,0-800,600

3 2

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9030 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

1 0

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9029 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

1 0

Re: mstask/tests: make sure return values are used (LLVM/Clang)
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9011 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: gdi32: Text output of records EMR_EXTTEXTOUTA/W depend on field iGraphicsMode
by Austin English 08 Feb '11

08 Feb '11

On Mon, Feb 7, 2011 at 15:49, Alexander Kochetkov <al.kochet(a)gmail.com> wrote: > Fix for bug #22996, and likely for bug #16557. > > BTW, I think, what the same problem exist with EMR_POLYTEXTOUTA/W records. Forgot the patch. -- -Austin

1 0

Re: inetcomm/tests: make sure to use return values (LLVM/Clang)
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9009 Your paranoid android. === WXPPROSP3 (32 bit mimeole) === No test summary line found

1 0

Re: comctl32/tests: Fixed variable type, removed sign comparison warning.
by Nikolay Sivov 07 Feb '11

07 Feb '11

On 2/8/2011 00:26, Marko Nikolic wrote: > --- > dlls/comctl32/tests/trackbar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/tests/trackbar.c b/dlls/comctl32/tests/trackbar.c > index ac67d50..714a321 100644 > --- a/dlls/comctl32/tests/trackbar.c > +++ b/dlls/comctl32/tests/trackbar.c > @@ -953,7 +953,7 @@ static void test_ignore_selection(HWND hWndTrackbar){ > static void test_initial_state(void) > { > HWND hWnd; > - DWORD ret; > + HRESULT ret; > > hWnd = create_trackbar(0, hWndParent); This is wrong, did you mean LRESULT?

1 0