February 2011 - Wine-devel - list.winehq.org

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt
by Matteo Bruni 09 Feb '11

09 Feb '11

> + /* We need the for loop, since we need to convert the integer to a float */ > + for (i = 0; i < count && i < desc.RegisterCount; i++) > + { > + row[0] = (float)n[i]; The cast is unneeded, and the comment above is too.

2 2

Re: d3dx9_36: make sure return values are used (LLVM/Clang)
by Matteo Bruni 09 Feb '11

09 Feb '11

hr = IDirect3DTexture9_GetLevelDesc(texture, 0, &desc); + ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, D3D_OK); Copy-paste error, it should be GetLevelDesc in the ok() message. :)

1 0

Re: user32: Add message tests for SetParent().
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9096 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: d3dx9_36: Implement a few tests for D3DXCreateBox
by Stefan Dösinger 09 Feb '11

09 Feb '11

Am Mittwoch 09 Februar 2011, 07:34:21 schrieb David Adam: > + wnd = CreateWindow("static", "d3dx9_test", 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL); The class "static" doesn't work on Windows 7, I am afraid you'll need a proper window class. And I think a CreateWindow failure should count as test failure, it's a stupid reason to skip the entire test. (The other d3dx9 tests may have the same issue)

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.
by Alexandre Julliard 09 Feb '11

09 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This test is supposed to show the root of the problem with the test > application attached to the bug 13951. It appears that the check performed > by server/window.c,is_top_level_window() is not correct (which leads to > a SetWindowPos() failure to set foreground window), and probably should be > replaced by simple (win->style & (WS_CHILD | WS_POPUP)) != WS_CHILD. Maybe, but the test doesn't really demonstrate that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mshtml/tests: make sure return values are used (LLVM/Clang)
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9073 Your paranoid android. === WXPPROSP3 (32 bit dom) === No test summary line found

1 0

Re: secur32/tests: make sure a return value is used (LLVM/Clang)
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9068 Your paranoid android. === WNT4WSSP6 (32 bit ntlm) === ntlm.c:1231: Test failed: AcquireCredentialsHande() returned SEC_E_INVALID_TOKEN ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:1031: Test failed: MakeSignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1061: Test failed: Crypt trailer not as expected. ntlm.c:1075: Test failed: Crypt message not as expected. ntlm.c:1097: Test failed: DecryptMessage returned SEC_E_MESSAGE_ALTERED, not SEC_E_OK. ntlm.c:1099: Test failed: Failed to decrypt message correctly. ntlm.c:1127: Test failed: MakeSignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1135: Test failed: VerifySignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK ntlm.c:1139: Test failed: EncryptMessage returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1157: Test failed: Crypt message not as expected. ntlm.c:1176: Test failed: DecryptMessage returned SEC_E_INVALID_TOKEN, not SEC_E_OK.

1 0

Re: comctl32/tests: Use a function instead of a macro for CheckSize test
by Vitaliy Margolen 09 Feb '11

09 Feb '11

On 02/08/2011 04:45 PM, EG Galano wrote: > This fixes the warnings: > comctl32/tests/tab.c:525: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:545: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:568: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:1015: warning: logical `&&' with non-zero > constant will always evaluate as true > > for me on Debian gcc 4.3.2 Time to file bug for the compiler. Yes macro looks bad and that's not the way I would have done it now, but there is not a single place where "non-zero constant" is used directly with logical AND. Also what Nikolay said. Vitaliy.

1 0

Re: comctl32/tests: Use a function instead of a macro for CheckSize test
by Nikolay Sivov 08 Feb '11

08 Feb '11

On 2/9/2011 02:45, EG Galano wrote: Main problem with that - you will lost ok() context in test output, line numbers will be always the same. Look like it's resolved in other places - a thin macro to pass a line number to a function and ok_(, <linenumber>) test inside.

1 0

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)
by Juan Lang 08 Feb '11

08 Feb '11

Hi Janne, + handle = NULL; + ZeroMemory(&overlapped, sizeof(overlapped)); + overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); + ret = gNotifyAddrChange(&handle, &overlapped); + ok(ret == ERROR_IO_PENDING, "NotifyAddrChange returned %d, expected ERROR_IO_PENDING\n", ret); + ok(handle != INVALID_HANDLE_VALUE, "NotifyAddrChange returned invalid file handle\n"); This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrChange succeeded and attempt to do a wait on an invalid handle value, resulting in a crash. Thanks, --Juan

2 1