March 2011 - Wine-devel - list.winehq.org

Re: windowscodecs: DibDecoder_CreateInstance() is unused so remove it.
by Vincent Povirk 16 Mar '11

16 Mar '11

I think this will be needed by d3dx9, though it hasn't been fully wired up yet.

1 0

Re: kernel32: Implement and test GetVolumePathNamesForVolumeName. (try 2)
by Alexandre Julliard 16 Mar '11

16 Mar '11

Hans Leidekker <hans(a)codeweavers.com> writes: > + for (i = 0; i < output->NumberOfMountPoints; i++) > + { > + if (output->MountPoints[i].DeviceNameOffset) > + { > + const WCHAR *device = (const WCHAR *)((const char *)output + output->MountPoints[i].DeviceNameOffset); > + UINT device_len = output->MountPoints[i].DeviceNameLength / sizeof(WCHAR); > + int drive = map_dos_device( device, device_len ); > + > + if (drive != -1) > + { > + len += 4; > + if (volumepathname && len < buflen) > + { > + path[0] = 'A' + drive; > + path[1] = ':'; > + path[2] = '\\'; > + path[3] = 0; > + path += 4; > + } > + } > + } This won't allow you to support GUID volume names. I think you should query all mount points that match the device, not just the DOS drives. Either way you should use MOUNTMGR_QUERY_POINTS instead of trying every drive one by one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Gecko 1.2.0 released
by Jacek Caban 16 Mar '11

16 Mar '11

Hi all, The new Wine Gecko release is out and already used by Wine git version. Let me conclude shortly what has changed (more detailed updates can be found in my previous mails). It mostly means that you have to download it from Wine Sourceforge [1] and put it into the right directory [2] as always after each Gecko update. One important change is that there is msi file instead of cab file. Also starting with Wine 1.3.15, packages should be updated to depend on the new Gecko. Packagers may consider compiling Gecko themselves as building process no longer has ugly dependencies. Thanks to everyone who helped with the release! BTW, the nice thing is that accidentally we've released just after IE9. That's what I call a quick response :) Cheers, Jacek [1] https://sourceforge.net/projects/wine/files/Wine%20Gecko/1.2.0/ [2] http://wiki.winehq.org/Gecko

2 2

Re: mshtml, shdocvw: Initialize OLEINPLACEFRAMEINFO.cb for IOleInPlaceSite::GetWindowContext
by Jacek Caban 16 Mar '11

16 Mar '11

Hi Thomas, On 3/16/11 11:21 AM, Thomas Faber wrote: > Hi, > > the documentation for the OLEINPLACEFRAMEINFO structure [1] says > that the 'cb' member must be initialized before passing the structure > to IOleInPlaceSite::GetWindowContext (where the rest of it will be > filled). > In addition to the fix, I have updated the corresponding > tests to check this member instead of setting it, and they pass > on Windows as expected [2]. I've used a>= compare for future > version compatibility. Comparing to the exact value is better in this case. If the value will ever change, we want to know that and tests failures will help us notice it. Jacek

1 0

Re: d3dx9_36 [try 3]: Add a few tests for D3DXCreateBox
by Matteo Bruni 16 Mar '11

16 Mar '11

Most of the objections from the previous try still stand: check your whitespaces (whitespace after every comma, whitespaces around operators, whitespace after "if" or "for" keywords), you have to be consistent. Comparing indices doesn't make much sense now that you don't check vertices, I think you should drop that too. You could probably instead check for min and max x, y and z vertices coordinates, verifying that the box has the expected dimensions.

1 0

correct comctl32 implementation
by Andrew Green 15 Mar '11

15 Mar '11

I have been researching how i could implement the gsoc Theming - Implement Wine theming support. Though I'm a bit confused what is wanted. So is the case that completely separate dll's should be written for different versions and be loaded by side-by-side assembly. So you would end up with "comctl32v5.dll","comctl32v6.dll","comctl32v7.dll"? Would these be 3 different code basses or should they be made to share most of there code? >From what I understand uxtheme already loads XP theme files. So would all the work be isolated to creating different versions of comdlg32 and comctl32? Also does wine support side by side assembly? I did a very quick google search and i didn't see anything. I hope I'm not asking too much at once and/or too silly questions.

4 7

Re: [2/4] kernel32: Create a temp file with full access rights.
by Nikolay Sivov 15 Mar '11

15 Mar '11

On 3/15/2011 14:07, Dmitry Timoshkov wrote: > Installer in the bug 26288 requests FILE_ALL_ACCESS permission on a temp file > it just created. > --- > dlls/kernel32/path.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c > index e72848c..beeb14c 100644 > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -703,7 +703,7 @@ UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix, UINT unique, LPWSTR > do > { > sprintfW( p, formatW, unique ); > - handle = CreateFileW( buffer, GENERIC_WRITE, 0, NULL, > + handle = CreateFileW( buffer, GENERIC_READ|GENERIC_WRITE|GENERIC_EXECUTE, 0, NULL, > CREATE_NEW, FILE_ATTRIBUTE_NORMAL, 0 ); > if (handle != INVALID_HANDLE_VALUE) > { /* We created it */ Is it possible to add a test for that?

2 1

Re: mshtml: Report an error when navigation fails
by Piotr Caban 15 Mar '11

15 Mar '11

On 03/14/11 16:59, Piotr Caban wrote: > --- > dlls/mshtml/navigate.c | 110 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 110 insertions(+), 0 deletions(-) Please ignore this patch. It doesn't work as native do. Cheers, Piotr

1 0

Re: [PATCH 3/3] mshtml: Notify parser about script evaluation
by Marvin 15 Mar '11

15 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9959 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/4] server: Do not limit execute file access to .exe and .com files.
by Dmitry Timoshkov 15 Mar '11

15 Mar '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > - if (len >= 4 && > - (!strcasecmp( name + len - 4, ".exe" ) || !strcasecmp( name + len - 4, ".com" ))) > - { > - if (mode & S_IRUSR) > - mode |= S_IXUSR; > - if (mode & S_IRGRP) > - mode |= S_IXGRP; > - if (mode & S_IROTH) > - mode |= S_IXOTH; > - } > + if (mode & S_IRUSR) > + mode |= S_IXUSR; > + if (mode & S_IRGRP) > + mode |= S_IXGRP; > + if (mode & S_IROTH) > + mode |= S_IXOTH; Please ignore this patch, I need to figure out at which point the exec permissions are dropped. Other patches in the sequence do not depend on this one (and actually are all independent changes). -- Dmitry.

1 0