March 2011 - Wine-devel - list.winehq.org

Two more summer of code ideas
by Dan Kegel 15 Mar '11

15 Mar '11

I added sandboxing and message-mode pipes to http://wiki.winehq.org/SummerOfCode (Yes, it's literally a pipe dream :-) - Dan

2 1

Re: comctl32: Update progress bar only if it moves
by Nikolay Sivov 14 Mar '11

14 Mar '11

On 3/15/2011 00:16, Maarten Lankhorst wrote: > --- > Hopefully helps a little with lord of the rings online installer. It > seems to be fanatical about updating the position, which may result in > too many unnecessary redraws. Patch is wrong. This is inefficient but it's how native control works, it invalidates progress bar no matter what if position is changed. I tested so far PBM_DELTAPOS, PBM_SETPOS, PBM_STEPIT. So this change can break subclass processing for example, when application expects WM_PAINT.

1 0

Re: d3dx9_36: Start effect parsing.
by Henri Verbeet 14 Mar '11

14 Mar '11

2011/3/13 Rico Schüller <kgbricola(a)web.de>: > + if (tag != 0xfeff0901) Looks like the kind of thing you'd want a constant or inline function for. If I were to guess, the feff part means it's an effect (similar to the ffff for d3d9 pixel shaders and the fffe for d3d9 vertex shaders), and 0901 for version 9.1 (also similar to the d3d9 shader version token).

2 2

Re: [PATCH 5/5] shdocvw/tests: Added IShellBrowser, IBrowserService and IDocObjectService existance tests
by Marvin 14 Mar '11

14 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9936 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 2/5] shdocvw: Added IShellBrowser interface stub
by Huw Davies 14 Mar '11

14 Mar '11

On Mon, Mar 14, 2011 at 05:03:37PM +0100, Piotr Caban wrote: > +static HRESULT WINAPI ShellBrowser_QueryInterface( > + IShellBrowser* iface, > + REFIID riid, > + void **ppvObject) > +{ > + ShellBrowser *This = impl_from_IShellBrowser(iface); > + *ppvObject = NULL; > + > + if(IsEqualGUID(&IID_IShellBrowser, riid)) > + *ppvObject = &This->IShellBrowser_iface; > + > + if(*ppvObject) { > + TRACE("%p %s %p\n", This, debugstr_guid(riid), ppvObject); > + IUnknown_AddRef((IUnknown*)*ppvObject); > + return S_OK; > + } > + You probably want to add support for IID_IUnknown here too. Huw.

1 0

Re: [PATCH 2/2] winmm: Parse MCI colon notation as in T:MM:SS:F
by Alexandre Julliard 14 Mar '11

14 Mar '11

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > @@ -975,18 +975,31 @@ static WORD MCI_GetMessage(LPCWSTR lpCmd) > */ > static BOOL MCI_GetDWord(DWORD* data, LPWSTR* ptr) > { > - DWORD val; > - LPWSTR ret; > + DWORD val, total = 0; > + LPWSTR ret, src = *ptr; > + int shift = 0; > > - val = strtoulW(*ptr, &ret, 10); > + colonized: > + val = strtoulW(src, &ret, 10); > + if (ret == src) return FALSE; > > switch (*ret) { > case '\0': break; > + case '\t': > case ' ': ret++; break; > + case ':': { > + if ((val >= 256) || (shift >= 24)) return FALSE; > + total |= val << shift; > + shift += 8; > + src = ret + 1; > + goto colonized; > + } Please use a proper loop, not a goto. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] winecoreaudio: Fix 64-bits incompatibilities
by Alexandre Julliard 14 Mar '11

14 Mar '11

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > Dear 64bit users, > > here I turned a couple of DWORD into DWORD_PTR by analogy with other such patches. > I'm using a 32bit bit system where it makes no difference, so please check. > I'm wondering why, if such types make a difference on 64 bit, there > aren't crashes seen on testhq or otherwise reported. Why was this > not spotted earlier? 64-bit is not supported on Mac OS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Patch hw cursor Wine 1.3.15
by Vitaliy Margolen 14 Mar '11

14 Mar '11

On 03/13/2011 02:31 PM, Valentino Dell'Aica wrote: > Hi I've modified a patch for hw cursor in wine so it can work on wine 1.3.15 You have number of problems with your patch formatting with are outlined here: http://wiki.winehq.org/SubmittingPatches > + hwgl = getenv("WINE_CURSOR"); Wine uses registry for things like this. It should be a static variable set once. > + WINE_FIXME("Out of memory.\n"); For wine libraries this should be "FIXME". Also just printing fixme isn't a good error handling. And can you explain why for every button press/release you creating/removing cursor? This is highly inefficient. And what are you trying to archive with it anyway? Vitaliy.

3 2

GSOC CMD parser.
by Joel Teichroeb 14 Mar '11

14 Mar '11

I'm quite interested in the idea on the wiki of improving the CMD parser and fixing the bugs. I brought this up in the IRC and it was mentioned that there was some discussion of using bison/flex for parsing. I don't think that would be feasible for me to do in just three months but I'm wondering if that is the direction that is wanted for the CMD parser. It does not seem like there are enough issues with the current implementation to justify scrapping the current parser. The way I would go about this task would be to fix all the outstanding bugs, and add test cases for them, then find as many other bugs using and batch scripts from other open source projects. Thoughts and comments would be wonderful. Joel Teichroeb.

2 1

Re: riched20/tests: Beginnings of EM_SETMARGINS test
by Marvin 14 Mar '11

14 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9910 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0