March 2011 - Wine-devel - list.winehq.org

Re: [2/2] comctl32/listview: Fix edit box text limit
by Marvin 26 Mar '11

26 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10152 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259

1 0

Re: [1/2] comctl32/listview: Adjust dispinfo text buffer length
by Marvin 26 Mar '11

26 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10151 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:397: Test failed: buffer size 264 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259 listview.c:353: Test failed: text limit 260, expected 259

1 0

GSoC: Implement the Explorer
by Jay Yang 26 Mar '11

26 Mar '11

Hello, Since my first proposal got no response at all, I thought I'd offer another possible project I'm interested in. I looked a little into the "Implement the Explorer" project idea listed on the Summer of Code page on the wine wiki. I have a few questions as to what parts need to be implemented. Clearly, as stated by the description on the Summer of Code page, we have winefile, which does some of the things expected of explorer, but how far is winefile from a correct explorer implementation? Also would implementing Shell Extensions be a good Summer of Code project? In particular, I think it would be nice to have things like TortiseSVN working in wine. Thanks -- Jay Yang

3 4

Re: ole32/tests: Test for correct storage creation.
by Dmitry Timoshkov 26 Mar '11

26 Mar '11

Roman Dadkov <romand(a)etersoft.ru> wrote: > + IStorage_Commit(stg, STGC_DEFAULT); > + IStorage_Release(stg); > + GetHGlobalFromILockBytes(ilb, &hMem); It would be helpful to test the results of the above calls too. > + todo_wine > + ok(!memcmp((BYTE*)hMem, StandardMagic, 8), "Incorrect storage creation\n"); > + todo_wine > + ok(!memcmp(((BYTE*)hMem+8), NullableField, 16), "Incorrect storage creation. Field is not reset\n"); > + todo_wine > + ok(!memcmp(((BYTE*)hMem+34), NullableField, 10), "Incorrect storage creation. Field is not reset\n"); What is this supposed to show? -- Dmitry.

2 1

Re: Ubuntu's next release and raising hard ulimit on ubuntu
by Dan Kegel 26 Mar '11

26 Mar '11

Nope, this isn't about the select() limit. The soft limit on file handles should stay at 1024 so apps that use select() don't break. Apps like wine that have already switched away from select should be able to raise their soft limit if they want more file desciptors. Wine already does this. But ubuntu is misconfigured by default with a hard limit identical to the soft limit. It's time for ubuntu to fix this by raising the default hard limit on file desciptors in /etc/security/limits.conf. Users who need this can edit that file to make their games work, but they shouldn't have to. (Topposted from my cellphone) On Mar 25, 2011 8:03 AM, "Paul Chitescu" <paulc(a)voip.null.ro> wrote: On Friday 25 March 2011 03:26:25 pm Dan Kegel wrote: > Scott, correct me if I'm wrong, but does Natt... This is not an Ubuntu limitation but rather of the (g)libc API implementation. At least on glibc it is possible to increase the FD_SETSIZE at build time. Been there, done that, got the T-shirt. No need for header patching. http://yate.null.ro/websvn/filedetails.php?repname=yate&path=%2Ftrunk%2Feng… Caveat: FD_... operations take longer if FD_SETSIZE is increased. On all relevant platforms it is possible to check if a fd is above the limit. The application code must do so. Best is to internally replace select() with poll() on platforms that support it.

1 1

Ubuntu's next release and raising hard ulimit on ubuntu
by Dan Kegel 26 Mar '11

26 Mar '11

Scott, correct me if I'm wrong, but does Natty still have the hard limit of 1024 files open per process? If so, should be ask people to go vote for https://bugs.launchpad.net/ubuntu/+source/linux/+bug/663090 ? Getting that limit raised might avoid increasing numbers of support requests from users who can't figure out why Wine can't run their p2p downloader ( http://bugs.winehq.org/show_bug.cgi?id=25015 ).

3 2

Re: urlmon: Use unescaped Urls for FTP actions (try 3)
by Nikolay Sivov 25 Mar '11

25 Mar '11

On 3/26/2011 01:22, André Hentschel wrote: > Jacek gave me some advice and we made sure we have no other option to unescape the url. > --- > dlls/urlmon/ftp.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c > index c9d43b8..5857818 100644 > --- a/dlls/urlmon/ftp.c > +++ b/dlls/urlmon/ftp.c > @@ -60,12 +60,18 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request > { > FtpProtocol *This = impl_from_Protocol(prot); > BSTR url; > + DWORD len; > HRESULT hres; > > hres = IUri_GetAbsoluteUri(uri,&url); > if(FAILED(hres)) > return hres; > > + len = strlenW(url); No need to slow down with strlenW, it's a BSTR. > + hres = UrlUnescapeW((LPWSTR)url, NULL,&len, URL_UNESCAPE_INPLACE); > + if(FAILED(hres)) > + return hres; > + Leak! And why a cast by the way?

1 0

[GSoC] Continue work on Games Explorer
by Mariusz Pluciński 25 Mar '11

25 Mar '11

Hello, wine-devel In the last year's GSoC, I was working on implementation of Games Explorer features under Wine. I have successfully created it's own interfaces and made them working. However, the task proved harder than I thought before, so I did not create a user-interface part of the library. My idea for this summer is to finish the implementation of gameux.dll - writing the Shell Extension for GE. It would behave almost exact as the Windows equivalent - it should be able to display registered games as shell items, with possibility to run them, see the statistics etc. Having this should give user-experience a great deal. However, in my opinion it would be also a good way to check and extend the existing implementation of shell32. As far as I know, there is currently no real shell extension being part of Wine, so the working one would increase compatibility a much. There will be probably a problem with making my extension usable for user, as there's no working explorer currently in Wine. However, as I see, the implementation of explorer is one of popular proposal this year. In my opinion, it would be good idea to cooperate my work on GE Shell Extension with the person who will implement explorer.exe (if both ideas will be selected for realization). This would probably improve the quality of both projects. Summarizing, my project assumes following things to do: - write testing set to run under Windows. Tests will read the data from GE using it's shell interfaces. - creating stubs for shell interfaces. This will include following interfaces IShellFolder(2/3?), IShellView, IPersistFolder, IEnumIDList, IContextMenu, and probably a few other. I have created some stubs at the end of last GSoC, but never committed them, as they were requiring a few improvements. - implementing interfaces using the existing infrastructure inside of gameux.dll. Routines giving access to list of installed games were written by me last year, but there are still some missing parts which must be filled to let shell interfaces return proper data. - extending and fixing parts of shell32 (or other libraries) if required. This is mostly undefined part of task, but I've listed it here, cause I suppose this could take significant part of project's time. If there will be still time after finishing the points above, I would like to add one feature from my last-year proposal: a legacy games support. When Microsoft introduced the Games Explorer in Vista, they provided a big set of definitions of currently existing games to make them visible in GE, without requirement of modifications in games. My idea is to extend Wine's Application Database to allow it serve as legacy games database for our GE. This would increment an user experience from using the tool. My name is Mariusz Pluciński. I'm 20 years old student of Information Technology in Gdańsk University of Technology in Poland. Last year I was successfully participating in GSoC in Wine project (project name was "Implementation of Windows Game Explorer equivalent "), so my knowledge seems to be enough to continue work with even better results. Comments are welcome -- Best regards Mariusz Pluciński

1 0

[GSoC] Implementing missing DirectInput8 features
by Lucas Zawacki 25 Mar '11

25 Mar '11

Hello, I'm Lucas Fialho Zawacki a Computer Science undergrad at UFRGS university in Brazil. I'm very interested in working with Wine for the Google Summer of Code and have decided to approach the implementation of DirectInput8 missing features. I'm a long time Wine user, but I'd never looked at it from a developer point of view, so for the past few days I have been reading Wine's developer documentation and familiarizing myself with it's architecture and with the parts I intend to work on. At the moment, I don't have a clear understanding of how the implementation should be done so I'm reading a lot of material about dinput and dinput8 and building some documentation to help me. After some polishing I hope to be able to contribute it to Wine too. A little word about me. I've been using the C programming language for almost three years, so I'm very familiar with it. For the last two years I've worked on a research project as a C/C++ programmer, implementing a decision system for a F180 Small Size League Robot Soccer Team (see http://small-size.informatik.uni-bremen.de/) and http://code.google.com/p/robopet/ . I'm a heavy Linux user and I'm very comfortable with it's tools used for programming. That's it. I'm eager to get your feedback about this. My proposal will be ready in a few days. -- http://www.twitter.com/lfzawacki http://www.linesocode.wordpress.com

2 2

Re: [PATCH 07/15] d3dx9: Add ID3DXBaseEffect interface.
by Henri Verbeet 25 Mar '11

25 Mar '11

2011/3/23 Rico Schüller <kgbricola(a)web.de>: > + FIXME("íface %p, desc %p stub\n", This, desc); Typo?

2 1