March 2011 - Wine-devel - list.winehq.org

Re: [PATCH 03/15] d3dx9: Use size of variable instead of type.
by Nikolay Sivov 25 Mar '11

25 Mar '11

On 3/23/2011 13:49, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > len = MultiByteToWideChar(CP_ACP, 0, srcfile, -1, NULL, 0); > - srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); > + srcfileW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(*srcfileW)); > MultiByteToWideChar(CP_ACP, 0, srcfile, -1, srcfileW, len); No need to zero, if it will be filled with next call. This could a subject of next patch of course.

2 1

[GSoC] Merge winecfg and Control Panel
by Tony Zhang 25 Mar '11

25 Mar '11

Hi everyone, I am a senior student double majoring in Computer Science and Math at Northern Illinois University (currently applying the CS Master Program at NIU) and I would like to participate in merging winecfg and control panel through the Google Summer of Code program. I have used wine since wine 0.9 and 'm now using wine 1.3. I like the idea that all config tools should be grouped and managed at one place, and it would be nice to have them similar to the classical windows control panel (like the control panel in wine 1.3). About my programming background, I believe I know (and love) C the best. I have not had any internships before, but I'm currently working as an undergraduate Research Assistant at NIU. It is a Proton Computed Tomography (Proton CT) project and the main language in use is C, so I do have some experience of using C in a large-scale project. I have briefly walked through Owen Rudge's code of splitting out the Desktop Integration tab into its own control panel, but have no luck in getting a decent understanding of it. So I'm hoping some of you can point me to some documents that related to this task so I can have an overall understanding of the challenges of this task. Sincerely, -- Tony (Chi Zhang)

3 5

wine 1.3.16: wrc compiler and LANGUAGE
by Gilles Depeyrot 24 Mar '11

24 Mar '11

Hi, I am testing compiling an application that uses winelib with 1.3.16 (currently compiled with 1.2.2). I have an issue with the resource compiler (wrc) which doesn't understand the LANGUAGE line. When I compile resource files, I get errors resembling: file.rc:22:21: Error: syntax error The corresponding line in the file is: LANGUAGE LANG_FRENCH, SUBLANG_FRENCH If I comment the line, the compilation succeeds. Best regards, Gilles

4 7

Re: browseui/tests: COM cleanup in autocomplete.c.
by Marvin 24 Mar '11

24 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10131 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:250: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154

1 0

Re: winex11.drv/opengl.c: add improved error handling to pglXMakeCurrent() call
by Chris Robinson 24 Mar '11

24 Mar '11

On Wednesday, March 23, 2011 9:00:25 PM Joshua Beck wrote: > This patch was made against the origin, so if you've applied my previous > patch, remove that one before applying this one. > This patch makes the error message use ERR_(winediag) instead of just > ERR and is closer in style to the other error messages in opengl.c. There's some trailing whitespace in the patch.

1 0

Re: winex11.drv/opengl.c: add error handling to pglXMakeCurrent() call
by Roderick Colenbrander 24 Mar '11

24 Mar '11

Hi Joshua, Was about to submit a similar patch (had a few tiny fixes in my tree left), but this patch is mostly fine with me. Except I would print to 'winediag' like some of the other errors for software / indirect rendering are doing. So do something like 'Unable to active OpenGL context, like something your drivers have not been configured properly' (look what the other messages are like). Roderick On Thu, Mar 24, 2011 at 2:34 AM, Joshua Beck <jxb091000(a)utdallas.edu> wrote: > This patch should make it easier for those with driver problems to find the > problem when running Wine. > --Josh > > > >

1 0

Duplicate AppDB Entry
by Jeremy Nowka 24 Mar '11

24 Mar '11

"Barnes And Noble EReader" v2.5 and "Nook for PC" are the same program. I feel that the two AppDB entries should be combined for easier access by the general public. I feel that the information should be merged to "Nook for PC" because this is the common name for version 2.5. The version number for "Nook for PC" should be changed to reflect the actual version, 2.5.

2 1

re: [GSoC] Merge winecfg and Control Panel
by Dan Kegel 23 Mar '11

23 Mar '11

Also... it would be nice if there were a central commandline way of changing wine settings, kind of like 'net' is a central way of manipulating networking. I've been thinking that winecfg should have a commandline interface, too, and making it accept winetricks settings directly. Something like that would also make a good soc project.

4 3

Re: [1/2] uxtheme: Add OpenThemeDataEx (try 2)
by Dmitry Timoshkov 23 Mar '11

23 Mar '11

André Hentschel <nerv(a)dawncrow.de> wrote: > Applied Dmitry's suggestions > -HTHEME WINAPI OpenThemeData(HWND hwnd, LPCWSTR pszClassList) > +HTHEME WINAPI OpenThemeDataEx(HWND hwnd, LPCWSTR classlist, DWORD flags) > { > - WCHAR szAppBuff[256]; > - WCHAR szClassBuff[256]; > - LPCWSTR pszAppName; > - LPCWSTR pszUseClassList; > + WCHAR appbuff[256]; > + WCHAR classbuff[256]; > + LPCWSTR appname; > + LPCWSTR useclasslist; > HTHEME hTheme = NULL; You are changing too much. Just use lowercase named variables for new code, not touching existing ones. > - TRACE("(%p,%s)\n", hwnd, debugstr_w(pszClassList)); > + TRACE("(%p,%s, %u)\n", hwnd, debugstr_w(classlist), flags); flags above is still printed in decimal. > + > + if(flags) > + FIXME("unhandled Flags: %x\n", flags); -- Dmitry.

1 0

Re: [PATCH 2/4] comdlg32: Add stub implementation of the Common Item dialogs.
by Nikolay Sivov 23 Mar '11

23 Mar '11

On 3/21/2011 16:37, David Hedberg wrote > + */ > + > +#include<stdarg.h> > + > +#define COBJMACROS > +#define NONAMELESSUNION > +#define NONAMELESSSTRUCT > + > +#include "windef.h" > +#include "winbase.h" > +#include "winuser.h" > +#include "wingdi.h" > + > +#include "commdlg.h" > +#include "cdlg.h" > + > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(commdlg); > + > +typedef struct FileDialogImpl { > + IFileDialog2 IFileDialog2_iface; > + IFileOpenDialog IFileOpenDialog_iface; > + IFileSaveDialog IFileSaveDialog_iface; > + LONG ref; > +} FileDialogImpl; Maybe it's better to use a union and enum type field here, if it can't be open and save at the same time. > + > +/************************************************************************** > + * IFileDialog implementation > + */ > +static inline FileDialogImpl *impl_from_IFileDialog2(IFileDialog2 *iface) > +{ > + return (FileDialogImpl *)((char*)iface - FIELD_OFFSET(FileDialogImpl, IFileDialog2_iface)); > +} > + Use CONTAINING_RECORD macro please. > +static HRESULT WINAPI IFileDialog2_fnQueryInterface(IFileDialog2 *iface, > + REFIID riid, > + void **ppvObject) > +{ > > + } > + else > + FIXME("Unknown interface requested.\n"); It's better to dump guid here. > +} > + > +static ULONG WINAPI IFileDialog2_fnRelease(IFileDialog2 *iface) > +{ > + FileDialogImpl *This = impl_from_IFileDialog2(iface); > + LONG ref = InterlockedDecrement(&This->ref); > + TRACE("%p - ref %d\n", This, ref); > + > + if(!ref) > + { > + TRACE("Freeing object.\n"); > + HeapFree(GetProcessHeap(), 0, This); > + } > + > + return ref; > +} No need for additional trace I think, ref == 0 is enough to indicated that. > +static HRESULT FileDialog_constructor(IUnknown *pUnkOuter, REFIID riid, void **ppv, REFCLSID type) > +{ > + FileDialogImpl *fdimpl; > + HRESULT hr; > + TRACE("%p, %s, %p\n", pUnkOuter, debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_POINTER; > + if(pUnkOuter) > + return CLASS_E_NOAGGREGATION; > + > + fdimpl = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(FileDialogImpl)); > + if(!fdimpl) > + return E_OUTOFMEMORY; Zero initialization is useless here. > + > + fdimpl->IFileDialog2_iface.lpVtbl =&vt_IFileDialog2; > + > + if(IsEqualCLSID(type,&CLSID_FileOpenDialog)) > + fdimpl->IFileOpenDialog_iface.lpVtbl =&vt_IFileOpenDialog; > + else > + fdimpl->IFileSaveDialog_iface.lpVtbl =&vt_IFileSaveDialog; > + > + IUnknown_AddRef((IUnknown*)fdimpl); > + hr = IUnknown_QueryInterface((IUnknown*)fdimpl, riid, ppv); > + IUnknown_Release((IUnknown*)fdimpl); > + That looks strange, you only need one QueryInterface here.

2 4