May 2011 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 4)
by Alexandre Julliard 05 May '11

05 May '11

Charles Davis <cdavis(a)mymail.mines.edu> writes: > + case 0x05: > + data = "CdRomPeripheral"; > + snprintf(buffer, sizeof(buffer), "Cdrom%d", cdrom_no++); > + break; This needs to be set to the device name that mountmgr has assigned to it. That's the point of doing this in mountmgr: making sure that all the information derives from a single source. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH try3] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 05 May '11

05 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > try3: I've included better content draining in this patch (that I was > hoping to do as follow-up previously, due to already big size of the > patch). That fixes observed test failures. Older wininet implementations > don't have it, so the test fails for them. I'm getting a different failure now: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:1074: Test failed: Read 0 bytes instead of 13 make: *** [http.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load().
by Nikolay Sivov 04 May '11

04 May '11

On 5/3/2011 08:07, Adam Martinson wrote: > > Fixes bug 14864. > --- > dlls/msxml3/domdoc.c | 255 > ++++++++++++++++++++++++++------------------------ > 1 files changed, 134 insertions(+), 121 deletions(-) > > + case VT_ARRAY|VT_UI1: > + { > + SAFEARRAY* psa; > + BSTR bstr; > + psa = V_ARRAY(&source); > + bstr = bstr_from_xmlChar(psa->pvData); > + hr = domdoc_loadXML(iface, bstr, isSuccessful); > + SysFreeString(bstr); > + return hr; > + } > + break; Is it really supposed to be utf8 array? Or this will work cause one-byte chars match utf8? Also I don't like this method dependency, I think the proper way is to call IXMLDOMDocument3_loadXML(iface...) here. Or another way to avoid call through vtable - introduce something called domdoc_load_xml(This...) and use it in both places, but I think it's not worth it.

2 5

Re: [PATCH 2/2 try2] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 04 May '11

04 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > try2: Using GetTickCount64() for timestamps > > --- > dlls/urlmon/tests/protocol.c | 2 +- > dlls/urlmon/tests/url.c | 20 +- > dlls/wininet/http.c | 567 > ++++++++++++++++++++++++------------------ > dlls/wininet/internet.c | 2 +- > dlls/wininet/internet.h | 42 +++- > dlls/wininet/netconnection.c | 138 ++++------- > dlls/wininet/tests/http.c | 32 +-- > 7 files changed, 427 insertions(+), 376 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:2621: Test failed: expected 1 retrievals, got 0 http.c:2628: Test failed: count was wrong http.c:2629: Test failed: http data wrong http.c:2649: Test succeeded inside todo block: expected 1 retrievals make: *** [http.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: winscard/tests: Add test base functions of winscard.dll
by Marvin 04 May '11

04 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10722 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

FAQ translation possible?
by Frédéric Delanoy 04 May '11

04 May '11

Hi, I'm currently revising/translating WineHQ's website French translation. Translating the help, I remarked the FAQ is maintained in the wiki section. Wouldn't it make sense to move the FAQ to the wine website repository so as to ease translation? FAQ is probably one of the most important things to translate IMO. Is the wiki page somehow translatable (preferably using WineHQ's language cookie setting)? Or is it more important to remain it to the wiki for quick update/review? Frédéric Delanoy

3 5

signal(SIGCHLD,SIG_DFL) before exec()
by Ilya Basin 04 May '11

04 May '11

Hi list. I suffer from this bug: http://bugs.winehq.org/show_bug.cgi?id=27014 In wine sources there're not so many places where exec(3) family is used. In some places SIGCHLD and SIGPIPE are restored to default before calling exec(), in others they aren't. What's the difference? Can anyone explain me the why SIGCHLD not restored to default before calling execvp() here: http://source.winehq.org/source/libs/port/spawn.c?v=wine-1.3.19#L42 int spawnvp(int mode, const char *cmdname, const char *const argv[]) { ... if (mode == _P_OVERLAY) { execvp(cmdname, (char **)argv); /* if we get here it failed */ #ifdef ENOTSUP if (errno != ENOTSUP) /* exec fails on MacOS if the process has multiple threads */ #endif return -1; } Because it's not forked and if execvp() fails, we end up with the default handler?

1 0

Re: [PATCH 2/2] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 03 May '11

03 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > +static DWORD64 collector_timeout; > + > +static DWORD64 current_time(void) > +{ > + ULARGE_INTEGER timeout; > + SYSTEMTIME st; > + FILETIME ft; > + > + GetSystemTime(&st); > + SystemTimeToFileTime(&st, &ft); > + > + timeout.u.LowPart = ft.dwLowDateTime; > + timeout.u.HighPart = ft.dwHighDateTime; > + > + return timeout.QuadPart; > +} That's a lot of complexity for a timestamp, GetTickCount() would work just as well, as long as you do the comparisons correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] d3d8/tests: Fix some failure messages in test_depth_stencil_size().
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10709 Your paranoid android. === WXPPROSP3 (32 bit device) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\d3d8_test.exe, error 32

2 1

Re: [PATCH 4/5] d3d8/tests: Add a Reset test.
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10710 Your paranoid android. === WXPPROSP3 (32 bit device) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\d3d8_test.exe, error 32

1 0