May 2011 - Wine-devel - list.winehq.org

msvcrt: Add tests to show that utime() can take a NULL-pointer for the utimbuf structure field
by Joerg-Cyril.Hoehle＠t-systems.com 03 May '11

03 May '11

Louis, >Anything i could do to improve to get it in? Perhaps http://source.winehq.org/patches/ shows that you should get rid of the one apply failure. Basically, your patch does the right thing, as MSDN says "If times is a NULL pointer, the modification time is set to the current local time." -- like POSIX. >-#if(0) /* FIXME: this test crashes wine, remove this line when wine is fixed */ People here prefer if(0) so that the compiler can still validate the form of the code. I've been even been using if (winetest_debug>1) so I can direct testbot to run the additional test. Finally, why not merge the two? After all, it's one change, and several tests. Why do you call it test_utime() since you don't verify the effects of utime()? Regards, Jörg Höhle

1 0

Re: [PATCH 2/4] wintrust: Added CryptSIPPutSignedDataMsg implementation (for PE files)
by Piotr Caban 03 May '11

03 May '11

On 05/03/11 13:07, Piotr Caban wrote: > --- > dlls/wintrust/crypt.c | 66 ++++++++++++++++++++++++++++++++++++++++++------ > 1 files changed, 57 insertions(+), 9 deletions(-) Patches 2 and 3 in this series are not correct. Please ignore them.

1 0

Re: [PATCH 3/4] d3dx9: Implement ID3DXBaseEffect::GetPixelShader().
by Henri Verbeet 03 May '11

03 May '11

2011/5/3 Rico Schüller <kgbricola(a)web.de>: > +#define SAFE_ADDREF(x) if(x) IUnknown_AddRef(x) > +#define SAFE_RELEASE(x) if(x) IUnknown_Release(x) That's not so safe, actually. Consider e.g. what happens when "x" has side effects, or when you write something like "if (cond) SAFE_ADDREF(x); else return;". If you really want this an inline function should do just as well, but for the handful of uses I see in this series it just obfuscates the code.

1 0

msvcrt: Add tests to show that utime() can take a NULL-pointer for the utimbuf structure field
by Louis Lenders 03 May '11

03 May '11

See http://www.winehq.org/pipermail/wine-patches/2011-April/101371.html Anything i could do to improve to get it in?

1 0

Re: ddraw (try 2): Add a few tests for Setcooperativelevel
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10695 Your paranoid android. === WNT4WSSP6 (32 bit ddrawmodes) === ddrawmodes.c:800: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 ddrawmodes.c:803: Test failed: SetCooperativelevel(DDSCL_CREATEDEVICEWINDOW | DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN) returned: 80070057 ddrawmodes.c:828: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/2] d3d9/tests: Added a test for resetting an invisible, inactive window to fullscreen mode.
by Marvin 02 May '11

02 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10677 Your paranoid android. === WXPPROSP3 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K3R2SESP2 (32 bit device) === device: unhandled exception c0000005 at 0040320F === WVISTAADM (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K8SE (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PRO (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (64 bit device) === Timeout

2 1

Re: [PATCH 2/2] wined3d: Turn off message filtering temporarily in the Reset() method to allow certain messages (e.g. WM_ACTIVATEAPP) through.
by Henri Verbeet 02 May '11

02 May '11

On 2 May 2011 13:18, John Edmonds <pocketcookies2(a)gmail.com> wrote: > Toki Tori and RUSH both depend on receing WM_ACTIVATEAPP before they will start. These messages are currently getting filtered out. > This resolves bug #25640. It doesn't look right to me to filter messages during IWineD3DDevice_ReleaseFocusWindow() but not IWineD3DDevice_AcquireFocusWindow(). Maybe it just shouldn't filter at all.

2 2

Working on UpdateSemantics or D3DXWeldVertices in D3DX9?
by Michael Mc Donnell 02 May '11

02 May '11

Hi Guys! I'm doing Google Summer of Code 2011 and found out that some of the functions I was to implement have been implemented while my application was being processed. This means I have to find some other functions in D3DX9 to implement. I see that UpdateSemantics and D3DXWeldVertices are unimplemented in D3DX9, and was wondering if anyone is working on these? Cheers, Michael

1 0

Re: comctl32: avoid using ZeroMemory()
by Marcus Meissner 02 May '11

02 May '11

On Mon, May 02, 2011 at 10:52:50AM -0500, Austin English wrote: > Avoids a Clang bug: > http://bugs.winehq.org/show_bug.cgi?id=26754 clang cannot even survive a simple memset() to 0? Ciao, Marcus

2 1

Re: [2/2] comctl32/mru: Ignore size field when creating with -W calls
by Alexandre Julliard 02 May '11

02 May '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -210,11 +210,11 @@ typedef INT (CALLBACK *MRUStringCmpFnA)(LPCSTR lhs, LPCSTR rhs); > typedef INT (CALLBACK *MRUStringCmpFnW)(LPCWSTR lhs, LPCWSTR rhs); > typedef INT (CALLBACK *MRUBinaryCmpFn)(LPCVOID lhs, LPCVOID rhs, DWORD length); > > -typedef struct tagCREATEMRULISTA > +typedef struct tagMRUINFOA > { > DWORD cbSize; > - DWORD nMaxItems; > - DWORD dwFlags; > + UINT uMax; > + UINT fFlags; > HKEY hKey; > LPSTR lpszSubKey; > union Please do the renamings as a separate patch. -- Alexandre Julliard julliard(a)winehq.org

2 1