June 2011 - Wine-devel - list.winehq.org

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation
by Marvin 15 Jun '11

15 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11754 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] user32/tests: Added client-side raw input functions tests (try 2)
by Marvin 15 Jun '11

15 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11753 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH] winspool.drv: Removed a superflous NULL check (Coverity)
by Marvin 15 Jun '11

15 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11752 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Add sub-message to a commit
by GOUJON Alexandre 15 Jun '11

15 Jun '11

Hi, I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9b… I know that I can specify this text at the beginning of a patch I want to send to wine-patches (befor the '---'). But here, I'm interested in how to do that on the git server side. git commit -a or git commit -m let me specify a 'global' commit message. I googled some key words and RTFMs but didn't find anything relevant. Any hints on how to do that ? I can ask AJ directly but 1) it may be considered as rude and selfish 2) some people may be interested by the answer Thanks in advance

3 3

Re: [6/7] dxdiagn: Add additional adapter identifier properties for DxDiag_DisplayDevices subcontainers.
by Marvin 15 Jun '11

15 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11745 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

TaskDialog implementation
by Patrick Gauthier 15 Jun '11

15 Jun '11

Hello everyone, I'd like to port my re-implementation of task dialogs (http://www.korosoft.net/projects/tdemu/) to WINE, actually I have posted a small patch yesterday (merely rearranges some source around, preparatory work) which sadly did not seem to get accepted. I'm going to take my code and clean it to WINE's source code standards, however I do not see how I could split it in many patches as everything is dependant on everything else. As this is quite a big amount of work, I would like to have some guidance (what must I do to be sure it is accepted) so that I do not end up doing all that for nothing - starting by knowing why my patch from yesterday was not accepted (what did I do wrong). Thanks for your time and help.

7 8

re: dxdiag: Add code for XML information output
by Dan Kegel 15 Jun '11

15 Jun '11

Andrew Nguyan's commit, http://www.winehq.org/pipermail/wine-cvs/2011-June/078592.html used the construct static BOOL output_xml_information(struct dxdiag_information *dxdiag_info, const WCHAR *filename) { const struct information_block { const WCHAR *tag_name; struct information_field { const WCHAR *tag_name; const WCHAR *value; } fields[50]; } output_table[] = { {SystemInformation, { {Time, dxdiag_info->system_info.szTimeEnglish}, ... Isn't Wine was supposed to avoid non-static struct initializers? I think it'll get "warning: initializer element is not computable at load time" with --std=c89 --pedantic.

2 1

Re: [PATCH 3/5] ddraw: Add iface count for IDirectSurfaceImpl.
by Henri Verbeet 15 Jun '11

15 Jun '11

2011/6/14 <rbarkauskas(a)codeweavers.com>: > +static void ddraw_surface_add_iface(IDirectDrawSurfaceImpl *This) > +{ > + ULONG refCount = InterlockedIncrement(&This->numIfaces); Please use wined3d code style for new code. I.e., This -> surface, refCount -> refcount, numIface -> iface_count, space after control statements, etc.

1 0

Re: [PATCH 2/5] ddraw: Adjust reference counts of created surfaces in ddraw_set_surface_version.
by Henri Verbeet 15 Jun '11

15 Jun '11

2011/6/14 <rbarkauskas(a)codeweavers.com>: > + switch(version) > + { > + case 4: > + IDirectDrawSurface4_AddRef(&surface->IDirectDrawSurface4_iface); > + break; > + case 3: > + case 2: > + case 1: > + IDirectDrawSurface_AddRef(&surface->IDirectDrawSurface_iface); > + break; > + } > + IDirectDrawSurface7_Release(&surface->IDirectDrawSurface7_iface); Why do you need this here instead of in the relevant surface creation functions? (I suppose because of the mipmaps, but I think it may be better to do all this when the surface is created instead of afterwards.)

1 0

Re: [PATCH 5/5] ddraw: Separate IDirectDrawSurface2 reference count.
by Alexandre Julliard 15 Jun '11

15 Jun '11

rbarkauskas(a)codeweavers.com writes: > @@ -766,6 +766,8 @@ DestroyCallback(IDirectDrawSurface7 *surf, > > /* Destroy the surface */ > while(ref) ref = IDirectDrawSurface7_Release(surf); > + ref = Impl->ref2; > + while(ref) ref = IDirectDrawSurface2_Release(&Impl->IDirectDrawSurface2_iface); Ref counts should only be accessed through the interlocked functions. -- Alexandre Julliard julliard(a)winehq.org

1 0