June 2011 - Wine-devel - list.winehq.org

Re: [3/6] server: Implement RegisterHotKey/UnregisterHotKey.
by Octavian Voicu 13 Jun '11

13 Jun '11

Hello, Shouldn't you also increment SERVER_PROTOCOL_VERSION in include/wine/server_protocol.h? Octavian

2 2

Re: [6/6] user32: Test that QS_HOTKEY is properly set and cleared.
by Marvin 13 Jun '11

13 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11709 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [3/6] server: Implement RegisterHotKey/UnregisterHotKey.
by Marvin 13 Jun '11

13 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11708 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/6] user32: Add a test to find the queue containing hotkey messages.
by Marvin 13 Jun '11

13 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11707 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/6] user32: Ignore painting messages in the hotkey test using a wndproc.
by Marvin 13 Jun '11

13 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11706 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

re: cmd: add support for todo_wine constructions in testing infrastructure
by Dan Kegel 13 Jun '11

13 Jun '11

I agree @todo_space@ should go; it's never used, so it's dead code now. Tempting to say that removing it should be a separate patch, rather than combining that with adding a new feature. Since all the @keywords@ are poorly documented, I'm glad to see an unused one go. Your generic @todo_wine@ keyword seems useful. The current code is a bit ugly. If you're going to add a nice is_todo_wine_line() helper, it might make sense to do a cleanup patch that cleans up the @keyword@ recognition in general first. (Why the verbose array declaration instead of a "constant"? etc.) I see you're making every line of the .exp file count as a test. That seems ok. There's a fair bit of code duplication; I wonder if you could avoid that by refactoring things a bit. To avoid adding dead code, it might be nice to see a test that actually uses your new keyword. - Dan

2 4

Re: comctl32/tests: Added first TaskDialog test.
by Nikolay Sivov 13 Jun '11

13 Jun '11

On Sun, Jun 12, 2011 at 9:32 AM, Patrick Gauthier <webmaster(a)korosoft.net> wrote: > This patch relies on my previous patch that sets the ordinals right. > > Given that these functions would only be available on COMCTL32 v6.x, > Vista+, I added a win_skip if the APIs are not present. However unless > the test EXE has a manifest on Windows I think it might never find them. > Hey, Patrick. Look at tests/listview.c for example to see how I load version 6 with activation context API. It doesn't work for some reason for XP SP3 (a glitch I don't understand), but works fine for everything else. All you need is v6util.h. Without version 6 activation this test is useless to run in auto mode, it will never find TaskDialog entry points. Thanks for your interest.

3 5

Re: wineboot: Add a command line option to suppress the GUI window.
by Alexandre Julliard 13 Jun '11

13 Jun '11

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > programs/wineboot/wineboot.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) That's not going to do anything useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Handle SC_SCREENSAVE in DefWindowProc. (try 2)
by Alexandre Julliard 13 Jun '11

13 Jun '11

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > @@ -1606,6 +1607,12 @@ LRESULT NC_HandleSysCommand( HWND hwnd, WPARAM wParam, LPARAM lParam ) > FreeLibrary( hmodule ); > } > } > + else > + { > + const char *argv[3] = { "xdg-screensaver", "activate", NULL }; > + spawnvp( _P_NOWAIT, argv[0], argv ); > + } This should be consolidated with the support in explorer, and probably moved to the graphics driver. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] shell32/tests: verify known folders available in system
by Alexandre Julliard 13 Jun '11

13 Jun '11

Mariusz Pluciński <vshader(a)gmail.com> writes: > + StringFromGUID2(folderid, sGuid, sizeof(sGuid)/sizeof(sGuid[0])); > + hr = IKnownFolderManager_GetFolder(mgr, folderid, &folder); > + ok(hr==S_OK, "cannot get folder (id: %s, hr: 0x%08x)\n", wine_dbgstr_w(sGuid), hr); > + > +#define CHECK_KNOWN_FOLDER(id, csidl) \ > + check_single_known_folder(__LINE__, mgr, folderid, &id, csidl, # id, # csidl); > + > + CHECK_KNOWN_FOLDER(FOLDERID_AddNewPrograms, NO_CSIDL) > + CHECK_KNOWN_FOLDER(FOLDERID_AdminTools, CSIDL_ADMINTOOLS) > + CHECK_KNOWN_FOLDER(FOLDERID_AppUpdates, NO_CSIDL) ... This should be a loop over an array. -- Alexandre Julliard julliard(a)winehq.org

1 0