September 2011 - Wine-devel

Re: winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol (resend)
by Alexandre Julliard 07 Sep '11

07 Sep '11

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Hi, > > [unmodified & sent alone. There's no apply failure in testbot.] > > With this patch, MacOS will be the first to correctly implement the allowed ordering of Get and ReleaseBuffer according to my rendering tests (see bug #27937). > > [...capture mode] >>I believe that ReleaseBuffer(0) always returns S_OK, like in the render case. > Verified indeed. But I've not finalized capture code yet (I'm not > familiar with capture, so it takes more time). > > Because my patch changes the type of getbuf_last, I had to slightly modify AudioCaptureClient already: > @@ -1781,7 +1797,7 @@ static HRESULT WINAPI AudioCaptureClient_GetBuffer(IAudioCaptureClient *iface, > *flags = 0; > This->written_frames += *frames; > This->inbuf_frames -= *frames; > - This->getbuf_last = TRUE; > + This->getbuf_last = 1; This fake patch fragment in the message confuses git apply. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] cmd: Remove attrib from builtins list
by Frédéric Delanoy 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 09:09, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > This series remove attrib from the builtins list. Only the brief description in the global help is kept. > An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the > requested help is obtained by invoking the command with the /? option as for native cmd.exe. > --- > programs/cmd/cmd.rc | 1 - > programs/cmd/wcmd.h | 91 +++++++++++++++++++++++------------------------ > programs/cmd/wcmdmain.c | 1 - > 3 files changed, 45 insertions(+), 48 deletions(-) You should probably commit the po changes as well, as is usually done

3 4

Re: [PATCH 2/2] cmd: Launch the command with the /? option for external commands shipped with cmd.exe
by Frédéric Delanoy 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 09:10, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + WCHAR space_slashdot_ask[] = {' ', '/','?','\0'}; space_slash_questionmark would probably be a more appropriate name

1 0

Re: winecfg: Specify a context for the 'Letter' paper size. (try 2)
by Octavian Voicu 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget <fgouget(a)free.fr> wrote: > Actually, paper size is the more common term. ... > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc ... > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper size#Letter" While paper size is probably the most commonly used meaning within Wine, it seems pretty obvious to me that in this context "Letter" means "letter of the alphabet", because it refers to the letter that is used for mapping drives in winecfg (A, B, ... Z). Octavian

1 0

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy 07 Sep '11

07 Sep '11

"help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

2 1

Re: [3/3] msxml3: Support creating IXMLParser Interface
by Marvin 07 Sep '11

07 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android. === WNT4WSSP6 (32 bit xmlparser) === xmlparser.c:39: Test failed: failed to create IXMLParser

1 0

buildbot status
by Dan Kegel 07 Sep '11

07 Sep '11

- stability problems The buildbot cluster is not ready for prime time yet. My ubuntu 11.04-based slaves tend to lock up within a day with either an OOM failure, an X livelock, or something else. So I brought an ubuntu 10.04.3 slave online and moved the buildmaster off onto its own machine; let's see what breaks next. - Slave speed Here is the complete build-and-test time (and the build time alone) for four CPUs: 54 (48) celeron @ 2.80 GHz (headless, so it's not running all tests) 17 (10) E8400 @ 3.00GHz 14 (6) Q9300 @ 2.50GHz 12 (4) i7 920 @ 2.67GHz I will probably stick with slaves that are core 2 duo or better, so patches can get fast feedback.

5 15

Re: winecfg: Specify a context for the 'Letter' paper format.
by André Hentschel 07 Sep '11

07 Sep '11

Am 07.09.2011 00:48, schrieb Francois Gouget: > It's likely that letter does not always translate the same way for the paper format and the alphabet characters. > --- > > This is more to provide context for the translator than to avoid > conflicts. > > programs/winecfg/winecfg.rc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc > index 5689e7c..26cf504 100644 > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc > @@ -77,7 +77,7 @@ BEGIN > IDS_DRIVE_LETTERS_EXCEEDED "You cannot add any more drives.\n\nEach drive must have a letter, from A to Z, so you cannot have more than 26." > IDS_SYSTEM_DRIVE_LABEL "System drive" > IDS_CONFIRM_DELETE_C "Are you sure you want to delete drive C?\n\nMost Windows applications expect drive C to exist, and will die messily if it doesn't. If you proceed remember to recreate it!" > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper format#Letter" > IDS_COL_DRIVEMAPPING "Drive Mapping" > IDS_NO_DRIVE_C "You don't have a drive C. This is not so great.\n\nRemember to click 'Add' in the Drives tab to create one!\n" > END Isn't it the wrong context name? #msgctxt#Driveletter# would be better -- Best Regards, André Hentschel

1 0

re: dnsapi: Use internal name_skip function
by Dan Kegel 07 Sep '11

07 Sep '11

Hi André, your patch failed to build on an ubuntu 10.04 system here: ccache gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o name.o name.c In file included from ns_parse.c:39: ../../include/winbase.h:1583: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../../include/winbase.h:1584: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [ns_parse.o] Error 1 Inserting #include <stdarg.h> before including winbase.h makes the compiler happy. - Dan ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 6, 2011 at 3:41 PM Subject: Re: 78446: Subject: dnsapi: Use internal name_skip function To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/13 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

2 1

Testbot 64 bit mingw?
by Stefan Dösinger 06 Sep '11

06 Sep '11

Hi, The ddrawmodes test has a problem on W7PROX64 when running as a 64 bit binary. The test times out, and debugging showed that it freezes in crash_callbackA, in dlls/ddraw/tests/ddrawmodes.c. The function is supposed to crash, DirectDrawEnumerateA catches the exception and returns DDERR_INVALIDPARAMS. The line in question is: *(volatile char*)0 = 2; I can reproduce the freeze on my local system with the binaries built by the testbot. I cannot reproduce them with my own 64 bit binaries, or with the ones from http://test.winehq.org/builds. Thus I suspect that a problem with mingw is preventing the test from working. The 32 bit build works fine, even on a 64 bit Windows system. The mingw version I'm using on my local system: $ x86_64-pc-linux-gnu-gcc --version x86_64-pc-linux-gnu-gcc (Gentoo 4.5.2 p1.1, pie-0.4.5) 4.5.2 Stefan

1 0